Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fx:define and load fxml in separate thread where possible for play tab #3009

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

@Sheikah45 Sheikah45 changed the title Use fx:define and load fxml in separate thread where possible Use fx:define and load fxml in separate thread where possible for play tab Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #3009 (b195d31) into develop (a8bb3b7) will increase coverage by 0.02%.
The diff coverage is 77.69%.

❗ Current head b195d31 differs from pull request most recent head f5804ad. Consider uploading reports for the commit f5804ad to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3009      +/-   ##
=============================================
+ Coverage      61.35%   61.37%   +0.02%     
- Complexity      4591     4592       +1     
=============================================
  Files            554      553       -1     
  Lines          20131    20118      -13     
  Branches        1045     1040       -5     
=============================================
- Hits           12351    12348       -3     
+ Misses          7195     7191       -4     
+ Partials         585      579       -6     
Impacted Files Coverage Δ
...om/faforever/client/game/GamesTableController.java 51.28% <0.00%> (-0.42%) ⬇️
...ver/client/game/GamesTilesContainerController.java 59.21% <40.00%> (-2.44%) ⬇️
...om/faforever/client/game/PlayerCardController.java 74.78% <46.15%> (-8.37%) ⬇️
...aforever/client/replay/ReplayDetailController.java 79.13% <75.75%> (-3.00%) ⬇️
...m/faforever/client/game/GameTooltipController.java 87.80% <95.65%> (+7.80%) ⬆️
.../com/faforever/client/game/TeamCardController.java 69.11% <95.65%> (+4.73%) ⬆️
...om/faforever/client/game/GameDetailController.java 91.66% <100.00%> (+1.75%) ⬆️
...ent/teammatchmaking/TeamMatchmakingController.java 91.46% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8bb3b7...f5804ad. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 65fde4b into develop Jul 6, 2023
3 checks passed
@Sheikah45 Sheikah45 deleted the maintenance/play-tab-loading branch July 6, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant