Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AttackGroundTries and Othuy Lightning Storm #6166

Closed
wants to merge 26 commits into from
Closed

Fix AttackGroundTries and Othuy Lightning Storm #6166

wants to merge 26 commits into from

Commits on May 9, 2024

  1. Draft annotation for AttackGroundTries

    @lL1l1
    lL1l1 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    9893495 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Add state change and lost target debug log

    @lL1l1
    lL1l1 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    80aa368 View commit details
    Browse the repository at this point in the history

  2. Annotate DefaultProjWep's ReloadState OnLostTarget

    @lL1l1
    lL1l1 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    fdf7c45 View commit details
    Browse the repository at this point in the history

  3. Add comment for what breaks attackgroundtries

    @lL1l1
    lL1l1 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7f611de View commit details
    Browse the repository at this point in the history

  4. Don't check for target in firing state 

    Fixes lightning storm ground attacking
Previous commit prevents Scathis state locking up when losing target when in firing state that required this target check
    @lL1l1
    lL1l1 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    98161b7 View commit details
    Browse the repository at this point in the history

  5. Revert FiringState to steam behavior but with fix 

    fix for custom base class not being called, needed for lightning storm to work
    @lL1l1
    lL1l1 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e22538b View commit details
    Browse the repository at this point in the history

  6. Prevent skipping rack reload by losing target in firing state

    @lL1l1
    lL1l1 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    cf7f304 View commit details
    Browse the repository at this point in the history

  7. Update AttackGroundTries annotation 

    needs testing for IdleState OnFire, which is rarely called but is possible
    @lL1l1
    lL1l1 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    5e3be9a View commit details
    Browse the repository at this point in the history

  8. Don't let bombers retarget over time 

    Fixes their tracking of how many ground attacks they've done
    @lL1l1
    lL1l1 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    3c8c58b View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Annotate ResetTarget

    @lL1l1
    lL1l1 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3d04ae2 View commit details
    Browse the repository at this point in the history

  2. Update DefaultProjectileWeapon ResetTarget comments

    @lL1l1
    lL1l1 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7221521 View commit details
    Browse the repository at this point in the history

  3. Fix MuzzleVelocityReduceDistance condition

    @lL1l1
    lL1l1 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e775431 View commit details
    Browse the repository at this point in the history

  4. Annotate Current[Salvo|RackSalvo]Number

    @lL1l1
    lL1l1 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9623ee5 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. Annotate UnitWeapon functions 

    `SetFireControl`, `IsFireControl`, `WeaponHasTarget`, and `GetFireClockPct`
    @lL1l1
    lL1l1 committed May 18, 2024
    Configuration menu
    Copy the full SHA
    039dfe7 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Add sim freeze warnings for AttackerImpl

    @lL1l1
    lL1l1 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    dde57af View commit details
    Browse the repository at this point in the history

  2. More weapon behavior annotations

    @lL1l1
    lL1l1 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    feee00f View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Add weapon debugging code 

    Tracking of CanFire changes
Tracking of weapon fire rates
Tracking of engine calls in FireReadyState
Add fired shot/rack count debugging
    @lL1l1
    lL1l1 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    825bee2 View commit details
    Browse the repository at this point in the history

  2. Use correct rof for DisabledWhileReloadingThread

    @lL1l1
    lL1l1 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    b327268 View commit details
    Browse the repository at this point in the history

  3. Make fire recharge bar track the actual fire clock

    @lL1l1
    lL1l1 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    e760e8a View commit details
    Browse the repository at this point in the history

  4. Note that weapons do not track within MinRadius

    @lL1l1
    lL1l1 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    83c8da4 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Remove unused field in Cybran ACU laser bp

    @lL1l1
    lL1l1 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    66c3764 View commit details
    Browse the repository at this point in the history

  2. Format URB2301_Script.lua

    @lL1l1
    lL1l1 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    d272978 View commit details
    Browse the repository at this point in the history

  3. More debug logging

    @lL1l1
    lL1l1 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    4f8debd View commit details
    Browse the repository at this point in the history

  4. Add Salvo Retargeting feature 

    Check for a base class for FireReadyState OnLostTarget

fixes beam weapons not stopping immediately

Fix shooting 1 extra shot when retargeting a salvo with a salvoDelay
    @lL1l1
    lL1l1 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    3182f68 View commit details
    Browse the repository at this point in the history

  5. Simplify RenderFireClock

    @lL1l1
    lL1l1 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    3075443 View commit details
    Browse the repository at this point in the history

  6. Fix spelling

    @lL1l1
    lL1l1 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    32877f2 View commit details
    Browse the repository at this point in the history