Fix AttackGroundTries and Othuy Lightning Storm

engine/Core/Blueprints/WeaponBlueprint.lua

@@ -39,6 +39,8 @@
 ---@field ArtilleryShieldBlocks? boolean
 --- information about the audio files used by the weapon
 ---@field Audio WeaponBlueprintAudio
+--- How many times the engine calls OnFire for the weapon when attacking ground before moving on to the next ground attack order. Defaults to 3
+---@field AttackGroundTries?
 --- if the unit has no issued commands and has a weapon that has `AutoInitiateAttackCommand` set,
 --- then if it finds a suitable target it will issue an attack command to go after the target
 ---@field AutoInitiateAttackCommand? boolean
@@ -311,7 +313,7 @@
 ---@field ToggleWeapon? string
 --- The radius at which the weapon starts tracking the target. This does not mean that the weapon
 --- will fire. The weapon will only fire when a target enters the maxradius. This is a multiplier of
---- the weapon's `MaxRadius`.
+--- the weapon's `MaxRadius`. Weapons do not track targets within the weapon's `MinRadius`.
 ---@field TrackingRadius? number
 --- the second muzzle bone for a turret, used for arms on bots as weapons
 ---@field TurretBoneDualMuzzle? Bone

engine/Sim/CAiAttackerImpl.lua

@@ -1,5 +1,8 @@
 ---@meta
 
+-- The attacker implementation is unfinished, and using any of these methods freezes the sim!
+
+--- "tactical attack manager object"
 ---@class moho.CAiAttackerImpl_methods
 local CAiAttackerImpl = {}
 

engine/Sim/Unit.lua

@@ -122,6 +122,7 @@ function Unit:GetArmorMult(damageTypeName)
 end
 
 --- Returns the tactical attack manager object of this unit
+--- The attacker implementation is unfinished, so using this freezes the sim!
 ---@return Attacker
 function Unit:GetAttacker()
 end

engine/Sim/UnitWeapon.lua

@@ -8,7 +8,7 @@ local UnitWeapon = {}
 function UnitWeapon:BeenDestroyed()
 end
 
----
+--- Returns true if the weapon is aiming at the target as allowed by the FiringTolerance blueprint value and the target is within the weapon's range
 ---@return boolean
 function UnitWeapon:CanFire()
 end
@@ -96,8 +96,9 @@ end
 function UnitWeapon:GetCurrentTargetPos()
 end
 
---- Gets the firing clock percent, `0.0` - `1.0`
----@return number
+--- Returns the progress of the engine's firing clock determined by RateOfFire, usually from the blueprint
+---@see ChangeRateOfFire
+---@return number # within [0.0, 1.0]
 function UnitWeapon:GetFireClockPct()
 end
 
@@ -111,8 +112,9 @@ end
 function UnitWeapon:GetProjectileBlueprint()
 end
 
----
----@param label string
+--- Returns true if the given AimManipulator is the weapon's fire control
+---@see SetFireControl
+---@param label string label that was used to create the AimManipulator
 ---@return boolean
 function UnitWeapon:IsFireControl(label)
 end
@@ -122,7 +124,7 @@ end
 function UnitWeapon:PlaySound(params)
 end
 
----
+--- Force the weapon to recheck its targets. Also resets the counter for AttackGroundTries
 function UnitWeapon:ResetTarget()
 end
 
@@ -131,8 +133,8 @@ end
 function UnitWeapon:SetEnabled(enabled)
 end
 
----
----@param label string
+--- Set which AimManipulator will call OnFire for the weapon when that manipulator has finished tracking
+---@param label string label that was used to create the AimManipulator
 function UnitWeapon:SetFireControl(label)
 end
 
@@ -165,7 +167,8 @@ end
 function UnitWeapon:TransferTarget()
 end
 
----
+--- Returns true if the weapon currently has a target.
+--- This only updates at the end of a tick, so it shouldn't be used in behavior relating to OnLostTarget or OnGotTarget callbacks
 ---@return boolean
 function UnitWeapon:WeaponHasTarget()
 end

lua/sim/weapon.lua

@@ -334,6 +334,7 @@ Weapon = ClassWeapon(WeaponMethods) {
 
     ---@param self Weapon
     OnLostTarget = function(self)
+        LOG("weapon.lua:losttarget")
         local animator = self.unit.Animator
         if self.DisabledFiringBones and animator then
             for _, value in self.DisabledFiringBones do

lua/sim/weapons/DefaultBeamWeapon.lua

@@ -108,12 +108,12 @@ DefaultBeamWeapon = ClassWeapon(DefaultProjectileWeapon) {
         -- enable the beam
         beam:Enable()
 
-        -- non-continious beams that just end
+        -- non-continuous beams that just end
         if bp.BeamLifetime > 0 then
             self:ForkThread(self.BeamLifetimeThread, beam, bp.BeamLifetime or 1)
         end
 
-        -- continious beams
+        -- continuous beams
         if bp.BeamLifetime == 0 then
             self.HoldFireThread = self:ForkThread(self.WatchForHoldFire, beam)
         end