🔇 Comment out runtime_threads ⩼ threads #1457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drops the
entries from the resource overusage report added in #1428. As mentioned in #1404 (comment) and nipy/nipype#3290 (comment), I think the runtime threads are measuring something different than the estimated threads, so I don't think the comparison is intuitively meaningful. Also, the sheer number of nodes for which the runtime threads > estimated threads makes the report less manageable and obscures the memory overusage information.
After this change:
Before this change:
Checklist
Update index.md
).develop_v1.8_convergence
branch of the repository.visible errors.
Developer Certificate of Origin
Developer Certificate of Origin