Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Restore Apptainer tests #70

Merged
merged 31 commits into from
May 3, 2024

Conversation

shnizzedy
Copy link
Member

@shnizzedy shnizzedy commented Apr 11, 2024

Fixes

Related to #69 by @shnizzedy & Neurostars:Ammar_Ibrahim
Fixes #32 by @shnizzedy
Fixes #31 by @shnizzedy
Fixes #7 by @shnizzedy
Fixes #1 (comment) by @anibalsolon

Description

  • Updates CI to build and test in Apptainer instead of Singularity
  • Subclasses Apptainer backend from Singularity backend
  • Creates mock C-PAC :latest and :nightly images that include C-PAC API but not the various fMRI dependencies (AFNI, ANTs, FreeSurfer, FSL, etc.)
  • Fixes bugs in tests and in Singularity backend that were causing tests to fail

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the fix/FCP-INDI/cpac#69 branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy requested a review from a team April 11, 2024 13:19
@shnizzedy shnizzedy self-assigned this Apr 11, 2024
@shnizzedy shnizzedy changed the title ✅ Restore ~Singularity~ Apptainer tests ✅ Restore ~~Singularity~~ Apptainer tests Apr 11, 2024
@shnizzedy shnizzedy changed the title ✅ Restore ~~Singularity~~ Apptainer tests ✅ Restore Apptainer tests Apr 11, 2024
@shnizzedy shnizzedy added this to the v1.8.7 milestone Apr 30, 2024
@shnizzedy shnizzedy merged commit abff202 into fix/FCP-INDI/cpac#69 May 3, 2024
29 checks passed
@shnizzedy shnizzedy deleted the restore-singularity-tests branch May 3, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
1 participant