Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix cpac --platform singularity run without instance not found error #71

Merged
merged 43 commits into from
May 4, 2024

Conversation

shnizzedy
Copy link
Member

Fixes

Fixes #69 by @shnizzedy & Neurostars:Ammar_Ibrahim

Description

  • When running a C-PAC Apptainer/Singularity container through the Python API, give the path to the image (which works in old and new versions of the platforms) instead of a running-instance object (which only works in newer versions).
  • Update README.

Tests

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy linked an issue Apr 11, 2024 that may be closed by this pull request
@shnizzedy shnizzedy changed the title 🐛 cpac --platform singularity run without instance not found error 🐛 Fix cpac --platform singularity run without instance not found error Apr 11, 2024
@shnizzedy shnizzedy self-assigned this Apr 11, 2024
@shnizzedy shnizzedy added bug Something isn't working user-reported Singularity labels Apr 11, 2024
@shnizzedy shnizzedy marked this pull request as ready for review April 30, 2024 14:38
@shnizzedy shnizzedy added this to the v1.8.7 milestone Apr 30, 2024
@shnizzedy shnizzedy requested a review from a team May 1, 2024 20:09
@shnizzedy shnizzedy merged commit 48c2b3e into develop May 4, 2024
@shnizzedy shnizzedy deleted the fix/FCP-INDI/cpac#69 branch May 4, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Singularity user-reported
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🧠🌟 Running cpac run: instance not found
1 participant