Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“copy url button” added in details page. #89

Merged
merged 8 commits into from
Nov 2, 2020

Conversation

anujsingla
Copy link
Contributor

@anujsingla anujsingla commented Aug 19, 2020

#72
@jbernal0019 Please review.

I have updated a couple of packages
copyurl2
copyurl1

@anujsingla anujsingla changed the title WIP - copy url . “copy url button” added in details page. Sep 28, 2020
@jbernal0019
Copy link
Member

Hey @anujsingla I think there has been a confusion about the place for the “copy url button”. Actually it should go in the versions tab as each plugin version has its own url.

The overview tab UI should include in some way: 'creation_date', 'modification_date', 'name', 'title', 'stars', 'public_repo', 'license', 'type', 'icon', 'category', 'authors' (contributors), 'documentation'

In addition I think each plugin version should have its own card in the versions tab. Each card includes 'creation_date', 'version', 'dock_image', 'description', 'min_number_of_workers', 'max_number_of_workers', 'min_cpu_limit', 'max_cpu_limit', 'min_memory_limit', 'max_memory_limit', 'min_gpu_limit', 'max_gpu_limit' @mairin Is this something that was included in the mocks?

@anujsingla
Copy link
Contributor Author

Hey @jbernal0019 As per the new design #81
We need to show copy url button in the overview tab and I have already added in the Overview tab so I think we can merge this MR.
Please let me know if you need more details.

@jbernal0019
Copy link
Member

jbernal0019 commented Oct 16, 2020

Hey @anujsingla The copy url button should show the url of the individual plugin version shown on the new dropdown. If that's the case then yes, we can merge.

Please fix the conflicting files src/components/Plugin/Plugin.css so I can merge.

@anujsingla
Copy link
Contributor Author

@jbernal0019 Resolved conflicting files, Please merged it.

@jbernal0019 jbernal0019 merged commit 4cafa3e into FNNDSC:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants