Skip to content

Commit

Permalink
tests/isisd: bypass test_fuzz_isis_tlv when inet_ntop is broken
Browse files Browse the repository at this point in the history
On Alpine Linux edge, musl does not seem to be RFC 5952 4.2.2
compliant (how to print a single :0: in the IPv6 address).  Let's
skip that test, as we get false negatives when running against
that version of musl.

Credit for the idea for the fix and how to fix it is due to
chris@opensourcerouting.org.

Testing done:

make check on alpine linux passes now

Issue: #2375
Signed-off-by: Arthur Jones <arthur.jones@riverbed.com>
  • Loading branch information
ajones-rvbd committed Jun 6, 2018
1 parent a86dc99 commit 1808d46
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions tests/isisd/test_fuzz_isis_tlv.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,21 @@

import pytest
import platform
import socket

if platform.uname()[0] == 'SunOS':

##
# on musl, ntop compresses a single :0: -> :: which is against RFC
##
def inet_ntop_broken():
addr = '1:2:3:4:0:6:7:8'
return socket.inet_ntop(socket.AF_INET6,
socket.inet_pton(socket.AF_INET6, addr)) != addr


if platform.uname()[0] == 'SunOS' or inet_ntop_broken():
class TestFuzzIsisTLV:
@pytest.mark.skipif(True, reason='Test unsupported on SunOS')
@pytest.mark.skipif(True, reason='Test unsupported')
def test_exit_cleanly(self):
pass
else:
Expand Down

0 comments on commit 1808d46

Please sign in to comment.