Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: A couple more bgpd crash fixes for malformed packets (backport #14716) #14735

Merged
merged 2 commits into from
Nov 6, 2023

bgpd: Ignore handling NLRIs if we received MP_UNREACH_NLRI

250844b
Select commit
Failed to load commit list.
Merged

bgpd: A couple more bgpd crash fixes for malformed packets (backport #14716) #14735

bgpd: Ignore handling NLRIs if we received MP_UNREACH_NLRI
250844b
Select commit
Failed to load commit list.
NetDEF CI Pull Requests Testing / TopoTests Ubuntu 18.04 amd64 Part 3 succeeded Nov 5, 2023 in 14m 27s

Execution finished at mininet304 after 828.824 seconds

Bamboo CI Link
Execution details at https://ci1.netdef.org/browse/FRR-PULLREQ3-TP3U1804AMD64-551

Execution Summary

Failures
All tests passed

Success and Not classified
✔️ bgp_evpn_mh.test_evpn_mh test_evpn_es (39.607 s)
✔️ bgp_evpn_mh.test_evpn_mh test_evpn_ead_update (4.430 s)
✔️ bgp_evpn_mh.test_evpn_mh test_evpn_mac (42.927 s)
✔️ bgp_evpn_mh.test_evpn_mh test_evpn_df (5.136 s)
✔️ bgp_evpn_mh.test_evpn_mh test_evpn_uplink_tracking (14.642 s)
⚠️ bgp_evpn_overlay_index_gateway.test_bgp_evpn_overlay_index_gateway test_evpn_gateway_ip_basic_topo(16.207 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_overlay_index_gateway/test_bgp_evpn_overlay_index_gateway.py:274:
test_evpn_gateway_ip_basic_topo: s: Failing under new micronet framework, please debug and re-enable

✔️ bgp_evpn_overlay_index_gateway.test_bgp_evpn_overlay_index_gateway test_evpn_gateway_ip_basic_topo (16.207 s)
✔️ bgp_evpn_overlay_index_gateway.test_bgp_evpn_overlay_index_gateway test_evpn_gateway_ip_basic_topo (16.207 s)
⚠️ bgp_evpn_overlay_index_gateway.test_bgp_evpn_overlay_index_gateway test_evpn_gateway_ip_flap_rt5(0.004 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_overlay_index_gateway/test_bgp_evpn_overlay_index_gateway.py:302:
test_evpn_gateway_ip_basic_topo: s: Failing under new micronet framework, please debug and re-enable

✔️ bgp_evpn_overlay_index_gateway.test_bgp_evpn_overlay_index_gateway test_evpn_gateway_ip_flap_rt5 (0.004 s)
✔️ bgp_evpn_overlay_index_gateway.test_bgp_evpn_overlay_index_gateway test_evpn_gateway_ip_flap_rt5 (0.004 s)
⚠️ bgp_evpn_overlay_index_gateway.test_bgp_evpn_overlay_index_gateway test_evpn_gateway_ip_flap_rt2(0.004 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_overlay_index_gateway/test_bgp_evpn_overlay_index_gateway.py:365:
test_evpn_gateway_ip_basic_topo: s: Failing under new micronet framework, please debug and re-enable

✔️ bgp_evpn_overlay_index_gateway.test_bgp_evpn_overlay_index_gateway test_evpn_gateway_ip_flap_rt2 (0.004 s)
✔️ bgp_evpn_overlay_index_gateway.test_bgp_evpn_overlay_index_gateway test_evpn_gateway_ip_flap_rt2 (0.004 s)
⚠️ bgp_evpn_overlay_index_gateway.test_bgp_evpn_overlay_index_gateway test_memory_leak(1.602 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_overlay_index_gateway/test_bgp_evpn_overlay_index_gateway.py:394: Memory leak test/report is disabled

✔️ bgp_evpn_overlay_index_gateway.test_bgp_evpn_overlay_index_gateway test_memory_leak (1.602 s)
✔️ bgp_evpn_overlay_index_gateway.test_bgp_evpn_overlay_index_gateway test_memory_leak (1.602 s)
✔️ bgp_evpn_rt5.test_bgp_evpn test_protocols_convergence (8.175 s)
⚠️ bgp_evpn_rt5.test_bgp_evpn test_memory_leak(1.357 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_rt5/test_bgp_evpn.py:216: Memory leak test/report is disabled

✔️ bgp_evpn_rt5.test_bgp_evpn test_memory_leak (1.357 s)
✔️ bgp_evpn_rt5.test_bgp_evpn test_memory_leak (1.357 s)
✔️ bgp_evpn_vxlan_macvrf_soo_topo1.test_bgp_evpn_vxlan_macvrf_soo test_pe1_converge_evpn (31.052 s)
✔️ bgp_evpn_vxlan_macvrf_soo_topo1.test_bgp_evpn_vxlan_macvrf_soo test_pe2_converge_evpn (0.513 s)
✔️ bgp_evpn_vxlan_macvrf_soo_topo1.test_bgp_evpn_vxlan_macvrf_soo test_learning_pe1 (0.456 s)
✔️ bgp_evpn_vxlan_macvrf_soo_topo1.test_bgp_evpn_vxlan_macvrf_soo test_learning_pe2 (0.438 s)
✔️ bgp_evpn_vxlan_macvrf_soo_topo1.test_bgp_evpn_vxlan_macvrf_soo test_local_remote_mac_pe1 (0.470 s)
✔️ bgp_evpn_vxlan_macvrf_soo_topo1.test_bgp_evpn_vxlan_macvrf_soo test_local_remote_mac_pe2 (0.514 s)
✔️ bgp_evpn_vxlan_macvrf_soo_topo1.test_bgp_evpn_vxlan_macvrf_soo test_ip_pe1_learn (0.482 s)
✔️ bgp_evpn_vxlan_macvrf_soo_topo1.test_bgp_evpn_vxlan_macvrf_soo test_ip_pe2_learn (0.483 s)
✔️ bgp_evpn_vxlan_macvrf_soo_topo1.test_bgp_evpn_vxlan_macvrf_soo test_macvrf_soo (3.550 s)
⚠️ bgp_evpn_vxlan_macvrf_soo_topo1.test_bgp_evpn_vxlan_macvrf_soo test_memory_leak(1.827 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_vxlan_macvrf_soo_topo1/test_bgp_evpn_vxlan_macvrf_soo.py:832: Memory leak test/report is disabled

✔️ bgp_evpn_vxlan_macvrf_soo_topo1.test_bgp_evpn_vxlan_macvrf_soo test_memory_leak (1.827 s)
✔️ bgp_evpn_vxlan_macvrf_soo_topo1.test_bgp_evpn_vxlan_macvrf_soo test_memory_leak (1.827 s)
⚠️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_pe1_converge_evpn(0.008 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_vxlan_svd_topo1/test_bgp_evpn_vxlan_svd.py:153: Kernel requirements are not met, kernel version should be >= 5.7

✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_pe1_converge_evpn (0.008 s)
✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_pe1_converge_evpn (0.008 s)
⚠️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_pe2_converge_evpn(0.001 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_vxlan_svd_topo1/test_bgp_evpn_vxlan_svd.py:153: Kernel requirements are not met, kernel version should be >= 5.7

✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_pe2_converge_evpn (0.001 s)
✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_pe2_converge_evpn (0.001 s)
⚠️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_learning_pe1(0.001 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_vxlan_svd_topo1/test_bgp_evpn_vxlan_svd.py:153: Kernel requirements are not met, kernel version should be >= 5.7

✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_learning_pe1 (0.001 s)
✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_learning_pe1 (0.001 s)
⚠️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_learning_pe2(0.001 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_vxlan_svd_topo1/test_bgp_evpn_vxlan_svd.py:153: Kernel requirements are not met, kernel version should be >= 5.7

✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_learning_pe2 (0.001 s)
✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_learning_pe2 (0.001 s)
⚠️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_local_remote_mac_pe1(0.001 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_vxlan_svd_topo1/test_bgp_evpn_vxlan_svd.py:153: Kernel requirements are not met, kernel version should be >= 5.7

✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_local_remote_mac_pe1 (0.001 s)
✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_local_remote_mac_pe1 (0.001 s)
⚠️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_local_remote_mac_pe2(0.001 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_vxlan_svd_topo1/test_bgp_evpn_vxlan_svd.py:153: Kernel requirements are not met, kernel version should be >= 5.7

✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_local_remote_mac_pe2 (0.001 s)
✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_local_remote_mac_pe2 (0.001 s)
⚠️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_ip_pe1_learn(0.001 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_vxlan_svd_topo1/test_bgp_evpn_vxlan_svd.py:153: Kernel requirements are not met, kernel version should be >= 5.7

✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_ip_pe1_learn (0.001 s)
✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_ip_pe1_learn (0.001 s)
⚠️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_ip_pe2_learn(0.001 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_vxlan_svd_topo1/test_bgp_evpn_vxlan_svd.py:153: Kernel requirements are not met, kernel version should be >= 5.7

✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_ip_pe2_learn (0.001 s)
✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_ip_pe2_learn (0.001 s)
⚠️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_dvni(0.001 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_vxlan_svd_topo1/test_bgp_evpn_vxlan_svd.py:153: Kernel requirements are not met, kernel version should be >= 5.7

✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_dvni (0.001 s)
✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_dvni (0.001 s)
⚠️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_memory_leak(0.001 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_vxlan_svd_topo1/test_bgp_evpn_vxlan_svd.py:153: Kernel requirements are not met, kernel version should be >= 5.7

✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_memory_leak (0.001 s)
✔️ bgp_evpn_vxlan_svd_topo1.test_bgp_evpn_vxlan_svd test_memory_leak (0.001 s)
✔️ bgp_evpn_vxlan_topo1.test_bgp_evpn_vxlan test_pe1_converge_evpn (30.964 s)
✔️ bgp_evpn_vxlan_topo1.test_bgp_evpn_vxlan test_pe2_converge_evpn (0.457 s)
✔️ bgp_evpn_vxlan_topo1.test_bgp_evpn_vxlan test_learning_pe1 (0.418 s)
✔️ bgp_evpn_vxlan_topo1.test_bgp_evpn_vxlan test_learning_pe2 (0.441 s)
✔️ bgp_evpn_vxlan_topo1.test_bgp_evpn_vxlan test_local_remote_mac_pe1 (0.478 s)
✔️ bgp_evpn_vxlan_topo1.test_bgp_evpn_vxlan test_local_remote_mac_pe2 (0.504 s)
✔️ bgp_evpn_vxlan_topo1.test_bgp_evpn_vxlan test_ip_pe1_learn (0.534 s)
✔️ bgp_evpn_vxlan_topo1.test_bgp_evpn_vxlan test_ip_pe2_learn (0.492 s)
⚠️ bgp_evpn_vxlan_topo1.test_bgp_evpn_vxlan test_memory_leak(3.367 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP3U1804AMD64/topotests/bgp_evpn_vxlan_topo1/test_bgp_evpn_vxlan.py:429: Memory leak test/report is disabled

✔️ bgp_evpn_vxlan_topo1.test_bgp_evpn_vxlan test_memory_leak (3.367 s)
✔️ bgp_evpn_vxlan_topo1.test_bgp_evpn_vxlan test_memory_leak (3.367 s)
✔️ bgp_features.test_bgp_features test_ospf_convergence (26.349 s)
✔️ bgp_features.test_bgp_features test_bgp_convergence (0.549 s)
✔️ bgp_features.test_bgp_features test_bgp_shutdown (2.647 s)
✔️ bgp_features.test_bgp_features test_bgp_shutdown_message (0.313 s)
✔️ bgp_features.test_bgp_features test_bgp_no_shutdown (2.619 s)
✔️ bgp_features.test_bgp_features test_bgp_metric_config (1.440 s)
✔️ bgp_features.test_bgp_features test_bgp_metric_add_config (0.416 s)
✔️ bgp_features.test_bgp_features test_bgp_metric_subtract_config (0.371 s)
✔️ bgp_features.test_bgp_features test_bgp_set_metric (4.688 s)
✔️ bgp_features.test_bgp_features test_bgp_remove_metric_rmaps (1.255 s)
✔️ bgp_features.test_bgp_features test_bgp_norib (0.415 s)
✔️ bgp_features.test_bgp_features test_bgp_norib_routes (0.539 s)
✔️ bgp_features.test_bgp_features test_bgp_disable_norib (0.421 s)
✔️ bgp_features.test_bgp_features test_bgp_disable_norib_routes (0.529 s)
✔️ bgp_features.test_bgp_features test_bgp_delayopen_without (1.834 s)
✔️ bgp_features.test_bgp_features test_bgp_delayopen_singular (2.035 s)
✔️ bgp_features.test_bgp_features test_bgp_delayopen_dual (34.188 s)
✔️ bgp_flowspec.test_bgp_flowspec_topo test_bgp_convergence (5.504 s)
✔️ bgp_flowspec.test_bgp_flowspec_topo test_bgp_flowspec (0.517 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-1 test_BGP_GR_TC_51_p1 (37.420 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-1 test_BGP_GR_TC_53_p1 (18.168 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-1 test_BGP_GR_TC_4_p0 (22.223 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-1 test_BGP_GR_TC_5_1_2_p1 (26.393 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-1 test_BGP_GR_TC_6_1_2_p1 (14.049 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-2 test_BGP_GR_TC_8_p1 (19.710 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-3 test_BGP_GR_TC_19_p1 (20.291 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-3 test_BGP_GR_TC_20_p1 (23.468 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-3 test_BGP_GR_TC_31_1_p1 (18.110 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-3 test_BGP_GR_TC_31_2_p1 (23.616 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-3 test_BGP_GR_TC_9_p1 (17.609 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-3 test_BGP_GR_TC_17_p1 (22.479 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-3 test_BGP_GR_TC_43_p1 (50.116 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-3 test_BGP_GR_TC_44_p1 (42.438 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-3 test_BGP_GR_TC_45_p1 (51.548 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-4 test_BGP_GR_TC_46_p1 (38.841 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-4 test_BGP_GR_TC_47_p1 (32.319 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-4 test_BGP_GR_TC_48_p1 (32.319 s)
✔️ bgp_gr_functionality_topo1.test_bgp_gr_functionality_topo1-4 test_BGP_GR_TC_49_p1 (17.944 s)