Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: A couple more bgpd crash fixes for malformed packets (backport #14716) #14735

Merged
merged 2 commits into from
Nov 6, 2023

bgpd: Ignore handling NLRIs if we received MP_UNREACH_NLRI

250844b
Select commit
Loading
Failed to load commit list.
Merged

bgpd: A couple more bgpd crash fixes for malformed packets (backport #14716) #14735

bgpd: Ignore handling NLRIs if we received MP_UNREACH_NLRI
250844b
Select commit
Loading
Failed to load commit list.
NetDEF CI Pull Requests Testing / TopoTests Ubuntu 18.04 amd64 Part 2 succeeded Nov 5, 2023 in 34m 19s

Execution finished at mininet2402 after 2005.357 seconds

Bamboo CI Link
Execution details at https://ci1.netdef.org/browse/FRR-PULLREQ3-TP2U1804AMD64-551

Execution Summary

Failures
All tests passed

Success and Not classified
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_1_1 (6.218 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_2_1 (0.329 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_2_2 (5.722 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_2_3 (1.402 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_3_1 (0.335 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_3_2 (5.677 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_3_3 (1.441 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_4_1 (5.726 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_4_2 (4.718 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_5_1 (5.709 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_5_2 (1.402 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_5_3 (1.395 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_5_4 (1.394 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_6_1 (1.488 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_6_2 (1.440 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_6_3 (2.549 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_6_4 (1.433 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_7_1 (3.689 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_7_2 (1.410 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_7_3 (1.421 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_7_4 (2.475 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_8_1 (1.496 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_8_2 (1.445 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_8_3 (1.401 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_8_4 (1.405 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_9_1 (3.623 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_9_2 (1.416 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_9_3 (3.692 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_bgp_conditional_advertisement_tc_9_4 (1.444 s)
⚠️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_memory_leak(1.062 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TP2U1804AMD64/topotests/bgp_conditional_advertisement/test_bgp_conditional_advertisement.py:1290: Memory leak test/report is disabled

✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_memory_leak (1.062 s)
✔️ bgp_conditional_advertisement.test_bgp_conditional_advertisement test_memory_leak (1.062 s)
✔️ bgp_conditional_advertisement_static_route.test_bgp_conditional_advertisement_static_route test_bgp_conditional_advertisements_static_route (26.184 s)
✔️ bgp_conditional_advertisement_track_peer.test_bgp_conditional_advertisement_track_peer test_bgp_conditional_advertisement_track_peer (21.512 s)
✔️ bgp_confed1.test_bgp_confed1 test_bgp_convergence (7.919 s)
✔️ bgp_confed1.test_bgp_confed1 test_bgp_confed_ipv4_unicast (30.097 s)
✔️ bgp_confederation_astype.test_bgp_confederation_astype test_bgp_confederation_astype (8.584 s)
✔️ bgp_default_afi_safi.test_bgp-default-afi-safi test_bgp_default_ipv4_ipv6_unicast (7.530 s)
✔️ bgp_default_originate.test_bgp_default_originate_2links test_verify_bgp_default_originate_with_default_static_route_p1 (34.140 s)
✔️ bgp_default_originate.test_bgp_default_originate_2links test_verify_bgp_default_originate_with_aggregate_summary_p1 (8.448 s)
✔️ bgp_default_originate.test_bgp_default_originate_2links test_verify_default_originate_with_2way_ecmp_p2 (39.648 s)
✔️ bgp_default_originate.test_bgp_default_originate_topo1_1 test_verify_bgp_default_originate_in_IBGP_p0 (32.758 s)
✔️ bgp_default_originate.test_bgp_default_originate_topo1_1 test_verify_bgp_default_originate_in_EBGP_p0 (21.460 s)
✔️ bgp_default_originate.test_bgp_default_originate_topo1_1 test_verify_bgp_default_originate_in_IBGP_with_route_map_p0 (61.127 s)
✔️ bgp_default_originate.test_bgp_default_originate_topo1_1 test_verify_bgp_default_originate_in_EBGP_with_route_map_p0 (106.253 s)
✔️ bgp_default_originate.test_bgp_default_originate_topo1_2 test_verify_bgp_default_originate_route_map_in_OUT_p1 (59.881 s)
✔️ bgp_default_originate.test_bgp_default_originate_topo1_2 test_verify_bgp_default_originate_route_map_in_IN_p1 (53.241 s)
✔️ bgp_default_originate.test_bgp_default_originate_topo1_2 test_verify_default_originate_after_removing_default_originate_p1 (64.888 s)
✔️ bgp_default_originate.test_bgp_default_originate_topo1_2 test_verify_default_originate_route_with_GR_p1 (17.920 s)
✔️ bgp_default_originate.test_bgp_default_originate_topo1_3 test_verify_default_originate_after_BGP_and_FRR_restart_p2 (138.240 s)
✔️ bgp_default_originate.test_bgp_default_originate_topo1_3 test_verify_default_originate_after_shut_no_shut_bgp_neighbor_p1 (161.170 s)
✔️ bgp_default_originate.test_default_orginate_vrf test_verify_default_originate_route_with_non_default_VRF_p1 (75.825 s)
✔️ bgp_default_originate.test_default_orginate_vrf test_verify_default_originate_route_with_non_default_VRF_with_route_map_p1 (23.151 s)
✔️ bgp_default_originate.test_default_originate_conditional_routemap test_default_originate_delete_conditional_routemap (55.076 s)
✔️ bgp_default_originate.test_default_originate_conditional_routemap test_verify_default_originate_after_BGP_attributes_p1 (115.540 s)
✔️ bgp_default_originate_timer.test_bgp_default_originate_timer test_bgp_default_originate_timer (55.008 s)
✔️ bgp_default_originate_withdraw.test_bgp_default_originate_withdraw test_bgp_default_originate_with_default_received (11.312 s)
✔️ bgp_default_route.test_bgp_default-originate test_bgp_default_originate_route_map (5.549 s)
✔️ bgp_default_route_route_map_match.test_bgp_default-originate_route-map_match test_bgp_default_originate_route_map (8.389 s)
✔️ bgp_default_route_route_map_match2.test_bgp_default-originate_route-map_match2 test_bgp_default_originate_route_map (47.670 s)
✔️ bgp_default_route_route_map_match_set.test_bgp_default-originate_route-map_match_set test_bgp_default_originate_route_map (8.481 s)
✔️ bgp_default_route_route_map_set.test_bgp_default-originate_route-map_set test_bgp_default_originate_route_map (8.355 s)
✔️ bgp_disable_addpath_rx.test_disable_addpath_rx test_bgp_disable_addpath_rx (9.176 s)
✔️ bgp_distance_change.test_bgp_admin_dist test_bgp_admin_distance_ebgp_ecmp_p0 (56.721 s)
✔️ bgp_distance_change.test_bgp_admin_dist test_bgp_admin_distance_ibgp_p0 (37.073 s)
✔️ bgp_distance_change.test_bgp_admin_dist test_bgp_admin_distance_chaos_p2 (49.368 s)
✔️ bgp_distance_change.test_bgp_admin_dist_vrf test_bgp_admin_distance_ebgp_vrf_p0 (51.466 s)
✔️ bgp_distance_change.test_bgp_admin_dist_vrf test_bgp_admin_distance_ebgp_with_imported_rtes_vrf_p0 (14.643 s)
✔️ bgp_distance_change.test_bgp_distance_change test_bgp_maximum_prefix_invalid (6.514 s)
✔️ bgp_dont_capability_negotiate.test_bgp_dont_capability_negotiate test_bgp_dont_capability_negotiate (4.702 s)
✔️ bgp_dont_capability_negotiate.test_bgp_dont_capability_negotiate test_bgp_check_fqdn (8.395 s)
✔️ bgp_dynamic_capability.test_bgp_dynamic_capability_graceful_restart test_bgp_dynamic_capability_graceful_restart (6.155 s)
✔️ bgp_dynamic_capability.test_bgp_dynamic_capability_role test_bgp_dynamic_capability_role (5.905 s)
✔️ bgp_dynamic_capability.test_bgp_dynamic_capability_software_version test_bgp_dynamic_capability_software_version (5.957 s)
✔️ bgp_ebgp_common_subnet_nexthop_unchanged.test_bgp-ebgp-common-subnet-nexthop-unchanged test_bgp_ebgp_common_subnet_nh_unchanged (8.038 s)
✔️ bgp_ebgp_requires_policy.test_bgp_ebgp_requires_policy test_ebgp_requires_policy (13.205 s)
✔️ bgp_ecmp_topo1.test_bgp_ecmp_topo1 test_bgp_convergence (34.591 s)
✔️ bgp_ecmp_topo1.test_bgp_ecmp_topo1 test_bgp_ecmp (1.845 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_modify_ecmp_max_paths[redist_static-8] (20.481 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_modify_ecmp_max_paths[redist_static-16] (1.840 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_modify_ecmp_max_paths[redist_static-32] (1.737 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_modify_ecmp_max_paths[advertise_nw-8] (1.601 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_modify_ecmp_max_paths[advertise_nw-16] (1.650 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_modify_ecmp_max_paths[advertise_nw-32] (1.655 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_ecmp_after_clear_bgp[redist_static-8] (11.054 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_ecmp_after_clear_bgp[redist_static-16] (11.077 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_ecmp_after_clear_bgp[redist_static-32] (11.122 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_ecmp_after_clear_bgp[advertise_nw-8] (13.165 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_ecmp_after_clear_bgp[advertise_nw-16] (13.198 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_ecmp_after_clear_bgp[advertise_nw-32] (11.069 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_ecmp_remove_redistribute_static (6.691 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_ecmp_shut_bgp_neighbor[redist_static] (6.375 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_ecmp_shut_bgp_neighbor[advertise_nw] (6.234 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_ecmp_remove_static_route (13.104 s)
✔️ bgp_ecmp_topo2.test_ebgp_ecmp_topo2 test_ecmp_remove_nw_advertise (10.843 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_modify_ecmp_max_paths[redist_static-8] (21.002 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_modify_ecmp_max_paths[redist_static-16] (1.659 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_modify_ecmp_max_paths[redist_static-32] (1.656 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_modify_ecmp_max_paths[advertise_nw-8] (1.566 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_modify_ecmp_max_paths[advertise_nw-16] (1.649 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_modify_ecmp_max_paths[advertise_nw-32] (1.625 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_ecmp_after_clear_bgp[redist_static-8] (8.888 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_ecmp_after_clear_bgp[redist_static-16] (8.806 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_ecmp_after_clear_bgp[redist_static-32] (10.981 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_ecmp_after_clear_bgp[advertise_nw-8] (11.210 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_ecmp_after_clear_bgp[advertise_nw-16] (10.990 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_ecmp_after_clear_bgp[advertise_nw-32] (13.082 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_ecmp_remove_redistribute_static (6.479 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_ecmp_shut_bgp_neighbor[redist_static] (4.187 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_ecmp_shut_bgp_neighbor[advertise_nw] (6.103 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_ecmp_remove_static_route (10.882 s)
✔️ bgp_ecmp_topo2.test_ibgp_ecmp_topo2 test_ecmp_remove_nw_advertise (10.723 s)
✔️ bgp_ecmp_topo3.test_ibgp_ecmp_topo3 test_ecmp_fast_convergence[redist_static] (24.741 s)