Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: A couple more bgpd crash fixes for malformed packets (backport #14716) #14735

Merged
merged 2 commits into from
Nov 6, 2023

bgpd: Ignore handling NLRIs if we received MP_UNREACH_NLRI

250844b
Select commit
Loading
Failed to load commit list.
Merged

bgpd: A couple more bgpd crash fixes for malformed packets (backport #14716) #14735

bgpd: Ignore handling NLRIs if we received MP_UNREACH_NLRI
250844b
Select commit
Loading
Failed to load commit list.
NetDEF CI Pull Requests Testing / TopoTests Ubuntu 18.04 arm8 Part 4 succeeded Nov 5, 2023 in 41m 7s

Execution finished at ci06-FRR-PULLREQ3-TOPO4U18ARM8-551 after 2426.367 seconds

Bamboo CI Link
Execution details at https://ci1.netdef.org/browse/FRR-PULLREQ3-TOPO4U18ARM8-551

Execution Summary

Failures
All tests passed

Success and Not classified
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-1 test_BGP_GR_TC_1_2_p0 (29.813 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-1 test_BGP_GR_TC_3_p0 (22.997 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-1 test_BGP_GR_TC_11_p0 (22.574 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-1 test_BGP_GR_10_p2 (23.304 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-1 test_BGP_GR_18_p1 (24.804 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-2 test_BGP_GR_26_p2 (36.560 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-2 test_BGP_GR_chaos_28_p1 (7.448 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-2 test_BGP_GR_chaos_29_p1 (19.104 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-2 test_BGP_GR_chaos_33_p1 (9.724 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-2 test_BGP_GR_chaos_34_2_p1 (19.985 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-3 test_BGP_GR_chaos_34_1_p1 (37.635 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-3 test_BGP_GR_chaos_32_p1 (16.404 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-3 test_BGP_GR_chaos_37_p1 (14.882 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-3 test_BGP_GR_chaos_30_p1 (13.908 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-3 test_BGP_GR_15_p2 (41.703 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-4 test_BGP_GR_TC_23_p1 (35.344 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-4 test_BGP_GR_20_p1 (21.766 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-4 test_BGP_GR_21_p2 (38.670 s)
✔️ bgp_gr_functionality_topo2.test_bgp_gr_functionality_topo2-4 test_BGP_GR_22_p2 (40.545 s)
✔️ bgp_gshut.test_bgp_gshut test_bgp_gshut (15.165 s)
✔️ bgp_gshut_topo1.test_ebgp_gshut_topo1 test_verify_graceful_shutdown_functionality_with_eBGP_peers_p0 (23.214 s)
✔️ bgp_gshut_topo1.test_ebgp_gshut_topo1 test_verify_restarting_zebra_bgpd_staticd_frr_with_eBGP_peers_p0 (47.680 s)
✔️ bgp_gshut_topo1.test_ibgp_gshut_topo1 test_verify_graceful_shutdown_functionality_with_iBGP_peers_p0 (22.671 s)
✔️ bgp_gshut_topo1.test_ibgp_gshut_topo1 test_verify_deleting_re_adding_route_map_with_iBGP_peers_p0 (28.580 s)
⚠️ bgp_instance_del_test.test_bgp_instance_del_test test_memory_leak(15.263 s)

/root/share/topotests/lib/ltemplate.py:197: Memory leak test/report is disabled

✔️ bgp_instance_del_test.test_bgp_instance_del_test test_memory_leak (15.263 s)
✔️ bgp_instance_del_test.test_bgp_instance_del_test test_memory_leak (15.263 s)
✔️ bgp_instance_del_test.test_bgp_instance_del_test test_check_linux_vrf (1.253 s)
✔️ bgp_instance_del_test.test_bgp_instance_del_test test_adjacencies (13.184 s)
✔️ bgp_instance_del_test.test_bgp_instance_del_test test_check_routes (7.542 s)
✔️ bgp_instance_del_test.test_bgp_instance_del_test test_check_linux_mpls (0.322 s)
✔️ bgp_instance_del_test.test_bgp_instance_del_test test_del_bgp_instances (5.922 s)
✔️ bgp_ipv4_class_e_peer.test_bgp_ipv4_class_e_peer test_bgp_ipv4_class_e_peer (6.688 s)
✔️ bgp_ipv4_over_ipv6.test_rfc5549_ebgp_ibgp_nbr test_ibgp_to_ibgp_p1 (21.572 s)
✔️ bgp_ipv4_over_ipv6.test_rfc5549_ebgp_ibgp_nbr test_ext_nh_cap_red_static_network_ibgp_peer_p1 (8.279 s)
✔️ bgp_ipv4_over_ipv6.test_rfc5549_ebgp_ibgp_nbr test_bgp_peer_group_p1 (12.551 s)
✔️ bgp_ipv4_over_ipv6.test_rfc5549_ebgp_nbr test_ext_nh_cap_red_static_network_ebgp_peer_tc8_p0 (19.894 s)
✔️ bgp_ipv4_over_ipv6.test_rfc5549_ebgp_nbr test_ext_nh_cap_remove_red_static_network_ebgp_peer_tc10_p1 (11.330 s)
✔️ bgp_ipv4_over_ipv6.test_rfc5549_ebgp_unnumbered_nbr test_unnumbered_loopback_ebgp_nbr_p0 (36.176 s)
✔️ bgp_ipv4_over_ipv6.test_rfc5549_ebgp_unnumbered_nbr test_restart_frr_p2 (20.684 s)
✔️ bgp_ipv4_over_ipv6.test_rfc5549_ebgp_unnumbered_nbr test_configure_gua_on_unnumbered_intf (7.613 s)
✔️ bgp_ipv4_over_ipv6.test_rfc5549_ibgp_nbr test_ext_nh_cap_red_static_network_ibgp_peer_p1 (17.834 s)
✔️ bgp_ipv4_over_ipv6.test_rfc5549_ibgp_nbr test_ext_nh_cap_admin_dist_tag_ibgp_peer_p1 (3.920 s)
✔️ bgp_ipv4_over_ipv6.test_rfc5549_ibgp_nbr test_ibgp_loopback_nbr_p1 (17.324 s)
✔️ bgp_ipv4_over_ipv6.test_rfc5549_ibgp_unnumbered_nbr test_ext_nh_cap_red_static_network_ebgp_peer_unnumbered_nbr_p1 (16.776 s)
✔️ bgp_ipv6_ll_peering.test_bgp_ipv6_ll_peering test_bgp_ipv6_link_local_peering (7.188 s)
✔️ bgp_ipv6_rtadv.test_bgp_ipv6_rtadv test_protocols_convergence (6.137 s)
⚠️ bgp_ipv6_rtadv.test_bgp_ipv6_rtadv test_memory_leak(1.955 s)

/root/share/topotests/bgp_ipv6_rtadv/test_bgp_ipv6_rtadv.py:128: Memory leak test/report is disabled

✔️ bgp_ipv6_rtadv.test_bgp_ipv6_rtadv test_memory_leak (1.955 s)
✔️ bgp_ipv6_rtadv.test_bgp_ipv6_rtadv test_memory_leak (1.955 s)
⚠️ bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct test_memory_leak(12.835 s)

/root/share/topotests/lib/ltemplate.py:197: Memory leak test/report is disabled

✔️ bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct test_memory_leak (12.835 s)
✔️ bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct test_memory_leak (12.835 s)
✔️ bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct test_adjacencies (15.329 s)
✔️ bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct test_add_routes (2.086 s)
✔️ bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct test_check_routes (0.689 s)
✔️ bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct test_cleanup_all (6.627 s)
⚠️ bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf test_memory_leak(14.833 s)

/root/share/topotests/lib/ltemplate.py:197: Memory leak test/report is disabled

✔️ bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf test_memory_leak (14.833 s)
✔️ bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf test_memory_leak (14.833 s)
✔️ bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf test_check_linux_vrf (0.327 s)
✔️ bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf test_adjacencies (14.196 s)
✔️ bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf test_notification_check (0.490 s)
✔️ bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf test_check_routes (6.974 s)
✔️ bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf test_check_linux_mpls (0.214 s)
✔️ bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf test_check_scale_up (26.362 s)
✔️ bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf test_check_scale_down (39.923 s)
✔️ bgp_labeled_unicast_addpath.test_bgp_labeled_unicast_addpath test_bgp_addpath_labeled_unicast (19.516 s)
✔️ bgp_labeled_unicast_default_originate.test_bgp_labeled_unicast_default_originate test_bgp_labeled_unicast_default_originate (9.404 s)
✔️ bgp_large_comm_list_match.test_bgp_large_comm_list_match test_bgp_large_comm_list_match (8.573 s)
✔️ bgp_large_comm_list_match.test_bgp_large_comm_list_match test_bgp_large_comm_list_match_any (3.620 s)
✔️ bgp_large_community.test_bgp_large_community_topo_1 test_large_community_set (11.684 s)
✔️ bgp_large_community.test_bgp_large_community_topo_1 test_large_community_advertise (1.117 s)
✔️ bgp_large_community.test_bgp_large_community_topo_1 test_large_community_transitive (3.098 s)
✔️ bgp_large_community.test_bgp_large_community_topo_1 test_large_community_override (3.233 s)
✔️ bgp_large_community.test_bgp_large_community_topo_1 test_large_community_additive (1.239 s)
✔️ bgp_large_community.test_bgp_large_community_topo_1 test_large_community_match_as_path (7.894 s)
✔️ bgp_large_community.test_bgp_large_community_topo_1 test_large_community_match_all (1.454 s)
✔️ bgp_large_community.test_bgp_large_community_topo_1 test_large_community_aggregate_network (10.101 s)
✔️ bgp_large_community.test_bgp_large_community_topo_1 test_large_community_boundary_values (0.555 s)
✔️ bgp_large_community.test_bgp_large_community_topo_1 test_large_community_invalid_chars (0.370 s)
✔️ bgp_large_community.test_bgp_large_community_topo_1 test_large_community_after_clear_bgp (12.297 s)
✔️ bgp_large_community.test_bgp_large_community_topo_2 test_create_bgp_standard_large_community_list (14.788 s)
✔️ bgp_large_community.test_bgp_large_community_topo_2 test_create_bgp_expanded_large_community_list (0.914 s)
✔️ bgp_large_community.test_bgp_large_community_topo_2 test_modify_large_community_lists_referenced_by_rmap (3.195 s)
✔️ bgp_large_community.test_bgp_large_community_topo_2 test_large_community_lists_with_rmap_apply_and_remove (9.550 s)
✔️ bgp_large_community.test_bgp_large_community_topo_2 test_duplicate_large_community_list_attributes_not_transitive (3.143 s)
✔️ bgp_large_community.test_bgp_large_community_topo_2 test_large_community_lists_with_rmap_set_none (1.087 s)
✔️ bgp_large_community.test_bgp_large_community_topo_2 test_lcomm_lists_with_redistribute_static_connected_rmap (7.692 s)
✔️ bgp_large_community.test_bgp_large_community_topo_2 test_large_community_lists_with_rmap_set_delete (3.349 s)
✔️ bgp_large_community.test_bgp_large_community_topo_2 test_large_community_lists_with_no_send_community (5.434 s)
✔️ bgp_large_community.test_bgp_large_community_topo_2 test_create_large_community_lists_with_no_attribute_values (0.898 s)
✔️ bgp_large_community.test_bgp_large_community_topo_2 test_large_community_lists_with_rmap_match_exact (1.310 s)
✔️ bgp_large_community.test_bgp_large_community_topo_2 test_large_community_lists_with_rmap_match_all (1.294 s)
✔️ bgp_large_community.test_bgp_large_community_topo_2 test_large_community_lists_with_rmap_match_any (1.296 s)
✔️ bgp_large_community.test_bgp_large_community_topo_2 test_large_community_lists_with_rmap_match_regex (18.365 s)
✔️ bgp_link_bw_ip.test_bgp_linkbw_ip test_bgp_linkbw_adv (17.992 s)
✔️ bgp_link_bw_ip.test_bgp_linkbw_ip test_bgp_cumul_linkbw (1.351 s)
✔️ bgp_link_bw_ip.test_bgp_linkbw_ip test_weighted_ecmp (2.039 s)
✔️ bgp_link_bw_ip.test_bgp_linkbw_ip test_weighted_ecmp_link_flap (2.044 s)
✔️ bgp_link_bw_ip.test_bgp_linkbw_ip test_weighted_ecmp_second_anycast_ip (1.314 s)
✔️ bgp_link_bw_ip.test_bgp_linkbw_ip test_paths_with_and_without_linkbw (1.416 s)
✔️ bgp_link_bw_ip.test_bgp_linkbw_ip test_linkbw_handling_options (10.149 s)
✔️ bgp_listen_on_multiple_addresses.test_bgp_listen_on_multiple_addresses test_peering (8.644 s)
✔️ bgp_listen_on_multiple_addresses.test_bgp_listen_on_multiple_addresses test_listening_address (2.535 s)
✔️ bgp_llgr.test_bgp_llgr test_bgp_llgr (15.289 s)
✔️ bgp_local_as.test_bgp_local_as test_bgp_local_as_same_remote_as (6.057 s)
✔️ bgp_local_as.test_bgp_local_as test_bgp_peer_group_local_as_same_remote_as (3.093 s)
✔️ bgp_local_as_dotplus_private_remove.test_bgp_local_as_dotplus_private_remove test_bgp_remove_private_as (10.749 s)
✔️ bgp_local_as_private_remove.test_bgp_local_as_private_remove test_bgp_remove_private_as (10.906 s)
✔️ bgp_local_asn.test_bgp_local_asn_agg test_verify_bgp_local_as_agg_in_EBGP_p0 (36.716 s)
✔️ bgp_local_asn.test_bgp_local_asn_ecmp test_verify_bgp_local_as_in_ecmp_EBGP_p0 (52.567 s)
✔️ bgp_local_asn.test_bgp_local_asn_topo1 test_verify_bgp_local_as_in_EBGP_p0 (35.841 s)
✔️ bgp_local_asn.test_bgp_local_asn_topo1 test_verify_bgp_local_as_in_EBGP_4B_AS_mid_2B_AS_p0 (26.368 s)
✔️ bgp_local_asn.test_bgp_local_asn_topo1 test_verify_bgp_local_as_GR_EBGP_p0 (62.161 s)
✔️ bgp_local_asn.test_bgp_local_asn_topo1 test_verify_bgp_local_as_in_EBGP_aspath_p0 (28.855 s)
✔️ bgp_local_asn.test_bgp_local_asn_topo1 test_verify_bgp_local_as_in_iBGP_p0 (41.060 s)
✔️ bgp_local_asn.test_bgp_local_asn_topo1 test_verify_bgp_local_as_allow_as_in_iBGP_p0 (37.219 s)
✔️ bgp_local_asn.test_bgp_local_asn_topo1 test_verify_bgp_local_as_in_EBGP_port_reset_p0 (29.129 s)
✔️ bgp_local_asn.test_bgp_local_asn_topo1 test_verify_bgp_local_as_in_EBGP_negative2_p0 (26.930 s)
✔️ bgp_local_asn.test_bgp_local_asn_topo1 test_verify_bgp_local_as_in_EBGP_negative3_p0 (9.035 s)
✔️ bgp_local_asn.test_bgp_local_asn_topo1 test_verify_bgp_local_as_in_EBGP_restart_daemons_p0 (39.647 s)
✔️ bgp_local_asn.test_bgp_local_asn_topo2 test_verify_bgp_local_as_in_4_Byte_AS_EBGP_p0 (35.919 s)
✔️ bgp_local_asn.test_bgp_local_asn_topo2 test_verify_bgp_local_as_in_old_AS2_new_AS4_EBGP_p0 (28.974 s)
✔️ bgp_local_asn.test_bgp_local_asn_vrf_topo1 test_verify_local_asn_ipv4_import_from_default_to_non_default_VRF_p0 (47.954 s)
✔️ bgp_local_asn.test_bgp_local_asn_vrf_topo1 test_verify_local_asn_ipv4_import_from_non_default_to_default_VRF_p0 (42.997 s)
✔️ bgp_local_asn.test_bgp_local_asn_vrf_topo2 test_verify_local_asn_ipv4_import_from_non_default_to_non_default_VRF_p0 (57.817 s)
✔️ bgp_local_asn_dot.test_bgp_local_asn_dot_agg test_verify_bgp_local_as_agg_in_EBGP_p0 (36.721 s)
✔️ bgp_local_asn_dot.test_bgp_local_asn_dot_ecmp test_verify_bgp_local_as_in_ecmp_EBGP_p0 (50.621 s)
✔️ bgp_local_asn_dot.test_bgp_local_asn_dot_topo1 test_verify_bgp_local_as_in_EBGP_p0 (35.519 s)
✔️ bgp_local_asn_dot.test_bgp_local_asn_dot_topo1 test_verify_bgp_local_as_in_EBGP_4B_AS_mid_4B_AS_p0 (26.381 s)
✔️ bgp_local_asn_dot.test_bgp_local_asn_dot_topo1 test_verify_bgp_local_as_GR_EBGP_p0 (62.007 s)
✔️ bgp_local_asn_dot.test_bgp_local_asn_dot_topo1 test_verify_bgp_local_as_in_EBGP_aspath_p0 (26.551 s)
✔️ bgp_local_asn_dot.test_bgp_local_asn_dot_topo1 test_verify_bgp_local_as_in_iBGP_p0 (40.795 s)
✔️ bgp_local_asn_dot.test_bgp_local_asn_dot_topo1 test_verify_bgp_local_as_allow_as_in_iBGP_p0 (37.152 s)
✔️ bgp_local_asn_dot.test_bgp_local_asn_dot_topo1 test_verify_bgp_local_as_in_EBGP_port_reset_p0 (29.161 s)
✔️ bgp_local_asn_dot.test_bgp_local_asn_dot_topo1 test_verify_bgp_local_as_in_EBGP_negative2_p0 (26.839 s)
✔️ bgp_local_asn_dot.test_bgp_local_asn_dot_topo1 test_verify_bgp_local_as_in_EBGP_negative3_p0 (9.020 s)
✔️ bgp_local_asn_dot.test_bgp_local_asn_dot_topo1 test_verify_bgp_local_as_in_EBGP_restart_daemons_p0 (57.401 s)
✔️ bgp_lu_explicitnull.test_bgp_lu_explicitnull test_converge_bgplu (7.262 s)
✔️ bgp_lu_explicitnull.test_bgp_lu_explicitnull test_traffic_connectivity (0.129 s)
⚠️ bgp_lu_explicitnull.test_bgp_lu_explicitnull test_memory_leak(2.233 s)

/root/share/topotests/bgp_lu_explicitnull/test_bgp_lu_explicitnull.py:189: Memory leak test/report is disabled

✔️ bgp_lu_explicitnull.test_bgp_lu_explicitnull test_memory_leak (2.233 s)
✔️ bgp_lu_explicitnull.test_bgp_lu_explicitnull test_memory_leak (2.233 s)
✔️ bgp_lu_topo1.test_bgp_lu test_converge_bgplu (7.234 s)
✔️ bgp_lu_topo1.test_bgp_lu test_clear_bgplu (7.137 s)
⚠️ bgp_lu_topo1.test_bgp_lu test_memory_leak(2.842 s)

/root/share/topotests/bgp_lu_topo1/test_bgp_lu.py:161: Memory leak test/report is disabled

✔️ bgp_lu_topo1.test_bgp_lu test_memory_leak (2.842 s)
✔️ bgp_lu_topo1.test_bgp_lu test_memory_leak (2.842 s)
✔️ bgp_lu_topo2.test_bgp_lu2 test_converge_bgplu (11.077 s)
✔️ bgp_lu_topo2.test_bgp_lu2 test_ping (9.456 s)
⚠️ bgp_lu_topo2.test_bgp_lu2 test_memory_leak(24.197 s)

/root/share/topotests/bgp_lu_topo2/test_bgp_lu2.py:201: Memory leak test/report is disabled

✔️ bgp_lu_topo2.test_bgp_lu2 test_memory_leak (24.197 s)
✔️ bgp_lu_topo2.test_bgp_lu2 test_memory_leak (24.197 s)