Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: A couple more bgpd crash fixes for malformed packets (backport #14716) #14735

Merged
merged 2 commits into from
Nov 6, 2023

bgpd: Ignore handling NLRIs if we received MP_UNREACH_NLRI

250844b
Select commit
Loading
Failed to load commit list.
Merged

bgpd: A couple more bgpd crash fixes for malformed packets (backport #14716) #14735

bgpd: Ignore handling NLRIs if we received MP_UNREACH_NLRI
250844b
Select commit
Loading
Failed to load commit list.
NetDEF CI Pull Requests Testing / TopoTests Ubuntu 18.04 amd64 Part 0 succeeded Nov 5, 2023 in 20m 53s

Execution finished at mininet404 after 1190.041 seconds

Bamboo CI Link
Execution details at https://ci1.netdef.org/browse/FRR-PULLREQ3-TOPOU1804-551

Execution Summary

Failures
All tests passed

Success and Not classified
⚠️ **** grpc_basic.test_basic_grpc(0.000 s)

('/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TOPOU1804/topotests/grpc_basic/test_basic_grpc.py', 46, 'Skipped: skipping; cannot create or import gRPC proto modules')

✔️ babel_topo1.test_babel_topo1 test_converge_protocols (17.150 s)
✔️ babel_topo1.test_babel_topo1 test_zebra_ipv4_routingTable (0.480 s)
⚠️ babel_topo1.test_babel_topo1 test_shutdown_check_stderr(1.505 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TOPOU1804/topotests/babel_topo1/test_babel_topo1.py:145: Skipping test for Stderr output and memory leaks

✔️ babel_topo1.test_babel_topo1 test_shutdown_check_stderr (1.505 s)
✔️ babel_topo1.test_babel_topo1 test_shutdown_check_stderr (1.505 s)
✔️ bgp_color_extcommunities.test_bgp_color_extcommunities test_bgp_color_extended_communities (9.555 s)
✔️ bgp_extcomm_list_delete.test_bgp_extcomm-list_delete test_bgp_convergence (9.898 s)
✔️ bgp_extcomm_list_delete.test_bgp_extcomm-list_delete test_rt_extcomm_list_delete (5.516 s)
✔️ bgp_extcomm_list_delete.test_bgp_extcomm-list_delete test_soo_extcomm_list_delete (5.433 s)
✔️ bgp_extcomm_list_delete.test_bgp_extcomm-list_delete test_nt_extcomm_list_delete (6.324 s)
✔️ bgp_extended_optional_parameters_length.test_bgp_extended_optional_parameters_length test_bgp_extended_optional_parameters_length (7.016 s)
✔️ bgp_gr_functionality_topo3.test_bgp_gr_functionality_topo3 test_bgp_gr_stale_routes (162.913 s)
✔️ bgp_gr_notification.test_bgp_gr_notification test_bgp_hold_timer_expired_gr (8.386 s)
✔️ bgp_gr_notification.test_bgp_gr_notification test_bgp_administrative_reset_gr (2.847 s)
✔️ bgp_gr_restart_retain_routes.test_bgp_gr_restart_retain_routes test_bgp_gr_restart_retain_routes (6.559 s)
✔️ bgp_node_target_extcommunities.test_bgp_node_target_extcommunities test_bgp_node_target_extended_communities (13.080 s)
✔️ bgp_orf.test_bgp_orf test_bgp_orf (8.083 s)
✔️ bgp_rmap_extcommunity_none.test_bgp_rmap_extcommunity_none test_bgp_extcommunity_none (10.849 s)
✔️ bgp_roles_capability.test_bgp_roles_capability test_correct_pair (12.183 s)
✔️ bgp_roles_capability.test_bgp_roles_capability test_role_pair_mismatch (0.520 s)
✔️ bgp_roles_capability.test_bgp_roles_capability test_single_role_advertising (0.611 s)
✔️ bgp_roles_capability.test_bgp_roles_capability test_single_role_receiving (0.641 s)
✔️ bgp_roles_capability.test_bgp_roles_capability test_role_strict_mode (0.565 s)
✔️ bgp_roles_capability.test_bgp_roles_capability test_correct_pair_peer_group (2.988 s)
✔️ bgp_roles_filtering.test_bgp_roles_filtering test_r10_routes (22.569 s)
✔️ bgp_roles_filtering.test_bgp_roles_filtering test_r1_routes (0.790 s)
✔️ bgp_roles_filtering.test_bgp_roles_filtering test_r6_routes (0.725 s)
✔️ bgp_roles_filtering.test_bgp_roles_filtering test_r4_routes (4.233 s)
✔️ bgp_route_map_delay_timer.test_bgp_route_map_delay_timer test_bgp_route_map_delay_timer (45.851 s)
✔️ bgp_route_map_match_ipv6_nexthop.test_bgp_route_map_match_ipv6_nexthop test_bgp_route_map_match_ipv6_next_hop_access_list (10.426 s)
✔️ bgp_route_map_match_source_protocol.test_bgp_route_map_match_source_protocol test_bgp_route_map_match_source_protocol (11.604 s)
✔️ bgp_route_map_on_match_next.test_bgp_route_map_on_match_next test_bgp_route_map_on_match_next (16.163 s)
✔️ bgp_route_map_vpn_import.test_bgp_route_map_vpn_import test_bgp_route_map_vpn_import (9.485 s)
✔️ bgp_route_origin_parser.test_bgp_route_origin_parser test_bgp_route_origin_parser (2.971 s)
✔️ bgp_route_server_client.test_bgp_route_server_client test_bgp_route_server_client (10.388 s)
✔️ bgp_tcp_mss.test_bgp_tcp_mss test_bgp_tcp_mss (6.988 s)
✔️ bgp_tcp_mss.test_bgp_vrf_tcp_mss test_bgp_vrf_tcp_mss (51.708 s)
✔️ bgp_tcp_mss_passive.test_bgp_tcp_mss_passive test_bgp_tcp_mss_passive (7.305 s)
✔️ config_timing.test_config_timing test_static_timing (300.836 s)
✔️ cspf_topo1.test_cspf_topo1 test_step1 (38.678 s)
✔️ cspf_topo1.test_cspf_topo1 test_step2 (0.655 s)
✔️ cspf_topo1.test_cspf_topo1 test_step3 (0.821 s)
✔️ cspf_topo1.test_cspf_topo1 test_step4 (1.037 s)
⚠️ cspf_topo1.test_cspf_topo1 test_memory_leak(2.556 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TOPOU1804/topotests/cspf_topo1/test_cspf_topo1.py:297: Memory leak test/report is disabled

✔️ cspf_topo1.test_cspf_topo1 test_memory_leak (2.556 s)
✔️ cspf_topo1.test_cspf_topo1 test_memory_leak (2.556 s)
✔️ mgmt_config.test_config test_staticd_startup (2.733 s)
✔️ mgmt_config.test_config test_mgmtd_one_exit_file (5.169 s)
✔️ mgmt_config.test_config test_mgmtd_one_exit_redir (5.345 s)
✔️ mgmt_config.test_config test_mgmtd_early_exit_file (9.978 s)
✔️ mgmt_config.test_config test_mgmtd_early_exit_redir (9.981 s)
✔️ mgmt_config.test_config test_mgmtd_early_end_file (0.688 s)
✔️ mgmt_config.test_config test_mgmtd_early_end_redir (9.796 s)
✔️ mgmt_config.test_config test_zebra_one_exit_file (0.438 s)
✔️ mgmt_config.test_config test_zebra_one_exit_redir (0.396 s)
✔️ mgmt_config.test_config test_zebra_early_exit_file (0.458 s)
✔️ mgmt_config.test_config test_zebra_early_exit_redir (0.422 s)
✔️ mgmt_config.test_config test_zebra_early_end_file (0.473 s)
✔️ mgmt_config.test_config test_zebra_early_end_redir (0.760 s)
✔️ mgmt_config.test_regression test_regression_issue_13920 (2.840 s)
✔️ mgmt_startup.test_bigconf test_staticd_latestart (16.214 s)
✔️ mgmt_startup.test_cfgfile_var test_staticd_routes_present (9.362 s)
✔️ mgmt_startup.test_late_bigconf test_staticd_latestart (15.474 s)
✔️ mgmt_startup.test_late_uniconf test_staticd_late_start (3.194 s)
✔️ mgmt_startup.test_latestart test_staticd_late_start (3.182 s)
✔️ mgmt_tests.test_yang_mgmt test_mgmt_commit_check (7.801 s)
✔️ mgmt_tests.test_yang_mgmt test_mgmt_commit_apply (1.261 s)
✔️ mgmt_tests.test_yang_mgmt test_mgmt_commit_abort (1.179 s)
✔️ mgmt_tests.test_yang_mgmt test_mgmt_delete_config (1.333 s)
✔️ mgmt_tests.test_yang_mgmt test_mgmt_chaos_stop_start_frr (7.397 s)
✔️ mgmt_tests.test_yang_mgmt test_mgmt_chaos_kill_daemon (3.036 s)
✔️ msdp_mesh_topo1.test_msdp_mesh_topo1 test_wait_ospf_convergence (29.870 s)
✔️ msdp_mesh_topo1.test_msdp_mesh_topo1 test_wait_msdp_convergence (2.885 s)
✔️ msdp_mesh_topo1.test_msdp_mesh_topo1 test_msdp_sa_configuration (0.446 s)
⚠️ msdp_mesh_topo1.test_msdp_mesh_topo1 test_memory_leak(1.620 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TOPOU1804/topotests/msdp_mesh_topo1/test_msdp_mesh_topo1.py:223: Memory leak test/report is disabled

✔️ msdp_mesh_topo1.test_msdp_mesh_topo1 test_memory_leak (1.620 s)
✔️ msdp_mesh_topo1.test_msdp_mesh_topo1 test_memory_leak (1.620 s)
✔️ msdp_topo1.test_msdp_topo1 test_bgp_convergence (11.772 s)
✔️ msdp_topo1.test_msdp_topo1 test_mroute_install (59.045 s)
✔️ msdp_topo1.test_msdp_topo1 test_msdp (0.880 s)
⚠️ msdp_topo1.test_msdp_topo1 test_memory_leak(2.119 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TOPOU1804/topotests/msdp_topo1/test_msdp_topo1.py:435: Memory leak test/report is disabled

✔️ msdp_topo1.test_msdp_topo1 test_memory_leak (2.119 s)
✔️ msdp_topo1.test_msdp_topo1 test_memory_leak (2.119 s)
✔️ multicast_mld_join_topo1.test_multicast_mld_local_join test_mld_local_joins_p0 (28.961 s)
✔️ multicast_mld_join_topo1.test_multicast_mld_local_join test_mroute_with_mld_local_joins_p0 (8.715 s)
✔️ multicast_mld_join_topo1.test_multicast_mld_local_join test_remove_add_mld_local_joins_p1 (20.462 s)
✔️ multicast_mld_join_topo1.test_multicast_mld_local_join test_remove_add_mld_config_with_local_joins_p1 (17.161 s)
✔️ nhrp_topo.test_nhrp_topo test_protocols_convergence (16.991 s)
✔️ nhrp_topo.test_nhrp_topo test_nhrp_connection (0.325 s)
✔️ nhrp_topo.test_nhrp_topo test_route_install (0.441 s)
⚠️ nhrp_topo.test_nhrp_topo test_memory_leak(1.260 s)

/root/bamboo-agent-home/xml-data/build-dir/FRR-PULLREQ3-TOPOU1804/topotests/nhrp_topo/test_nhrp_topo.py:246: Memory leak test/report is disabled

✔️ nhrp_topo.test_nhrp_topo test_memory_leak (1.260 s)
✔️ nhrp_topo.test_nhrp_topo test_memory_leak (1.260 s)
✔️ srv6_locator.test_srv6_locator test_srv6 (4.163 s)
✔️ srv6_locator_custom_bits_length.test_srv6_locator test_srv6 (4.360 s)
✔️ srv6_locator_usid.test_srv6_locator_usid test_srv6_usid_locator_configuration (2.585 s)
✔️ srv6_locator_usid.test_srv6_locator_usid test_srv6_usid_locator_get_chunk (0.298 s)
✔️ srv6_locator_usid.test_srv6_locator_usid test_srv6_usid_locator_release_chunk (0.304 s)
✔️ srv6_locator_usid.test_srv6_locator_usid test_srv6_usid_locator_create_locator (0.407 s)
✔️ srv6_locator_usid.test_srv6_locator_usid test_srv6_usid_locator_set_behavior_usid (0.410 s)
✔️ srv6_locator_usid.test_srv6_locator_usid test_srv6_usid_locator_unset_behavior_usid (0.297 s)
✔️ srv6_locator_usid.test_srv6_locator_usid test_srv6_usid_locator_delete (0.270 s)
✔️ srv6_locator_usid.test_srv6_locator_usid test_srv6_usid_locator_delete_all (0.575 s)
✔️ srv6_static_route.test_srv6_route test_srv6_static_route (2.851 s)
✔️ tc_basic.test_tc_basic test_tc_basic (9.562 s)