Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: Remove prefixReceivedCount from JSON #6143

Merged
merged 2 commits into from
Apr 5, 2020
Merged

bgpd: Remove prefixReceivedCount from JSON #6143

merged 2 commits into from
Apr 5, 2020

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Apr 3, 2020

This is already covered by pfxRcd. Removed due to consistency
between CLI and JSON.

@polychaeta polychaeta added bgp tests Topotests, make check, etc labels Apr 3, 2020
@LabN-CI
Copy link
Collaborator

LabN-CI commented Apr 3, 2020 •
edited
Loading

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/6143 b42c48c
Date 04/03/2020
Start 07:05:43
Finish 07:31:30
Run-Time 25:47
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-04-03-07:05:43.txt
Log autoscript-2020-04-03-07:06:40.log.bz2
Memory 480 491 418

For details, please contact louberger

@donaldsharp
Copy link
Member

I hate to ask this but can we order the two commits backwards?

@ton31337
Copy link
Member Author

ton31337 commented Apr 3, 2020

You mean at first tests and then code?

@donaldsharp
Copy link
Member

yes... else if someone was trying to bisect a problem in one of those tests...

@ton31337
Copy link
Member Author

ton31337 commented Apr 3, 2020

sure

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Apr 3, 2020 •
edited
Loading

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11598/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11598/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200403-01-gb42c48c0f-0 (missing) -> 7.4-dev-20200403-01-gb42c48c0f-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200403-01-gb42c48c0f-0 (missing) -> 7.4-dev-20200403-01-gb42c48c0f-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200403-01-gb42c48c0f-0 (missing) -> 7.4-dev-20200403-01-gb42c48c0f-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200403-01-gb42c48c0f-0 (missing) -> 7.4-dev-20200403-01-gb42c48c0f-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200403-01-gb42c48c0f-0 (missing) -> 7.4-dev-20200403-01-gb42c48c0f-0~deb10u1

@ton31337
tests: Replace prefixReceivedCount to pfxRcd in JSONs
18a7d0e 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
@ton31337
bgpd: Remove prefixReceivedCount from JSON
6f5dc2e 
This is already covered by pfxRcd. Removed due to consistency
between CLI and JSON.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
@ton31337
Copy link
Member Author

ton31337 commented Apr 3, 2020

done

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11606/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11606/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200403-01-g6f5dc2e50-0 (missing) -> 7.4-dev-20200403-01-g6f5dc2e50-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200403-01-g6f5dc2e50-0 (missing) -> 7.4-dev-20200403-01-g6f5dc2e50-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200403-01-g6f5dc2e50-0 (missing) -> 7.4-dev-20200403-01-g6f5dc2e50-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200403-01-g6f5dc2e50-0 (missing) -> 7.4-dev-20200403-01-g6f5dc2e50-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200403-01-g6f5dc2e50-0 (missing) -> 7.4-dev-20200403-01-g6f5dc2e50-0~deb10u1

@LabN-CI
Copy link
Collaborator

LabN-CI commented Apr 3, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/6143 6f5dc2e
Date 04/03/2020
Start 10:36:32
Finish 11:02:30
Run-Time 25:58
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-04-03-10:36:32.txt
Log autoscript-2020-04-03-10:37:26.log.bz2
Memory 460 473 418

For details, please contact louberger

@srimohans srimohans merged commit 2ebae25 into FRRouting:master Apr 5, 2020
@ton31337 ton31337 deleted the fix/remove_prefixReceivedCount branch April 5, 2020 19:04
@kakkotetsu kakkotetsu mentioned this pull request Sep 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srimohans srimohans srimohans approved these changes

Assignees
No one assigned
Labels
bgp tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ton31337 @LabN-CI @donaldsharp @NetDEF-CI @srimohans @polychaeta