This repository has been archived by the owner on Feb 7, 2018. It is now read-only.
Remove built-in operation types #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For now this pullrequest is pending the release of 0.2.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark and I have this idea that it might be better to auto-generate classes for
Command,QueryandInteractorthat live in the application instead of the framework. These generated classes would then simplyinclude Pavlov::Operationand set up whatever rules they want based on that (e.g. Interactors are not authorized by default).The generated classes are already in the
new-api-proposal, so this branch merely has to remove the built-ins, and change the integration tests so that they require the generator templates (so that we don't need to duplicate them into the specs).Like I add in the CHANGELOG, I think all you should have to do is gsub
\n\s+include Pavlov::for<. The generated classes have Resque compatibility commented out by default (it's provided as an example, but not everyone uses Resque so it's no longer enabled by default), so you'll have uncomment a bunch of lines there too.Ofcourse, if someone thinks this is a bad idea feel free to speak up.