Hkatz/namespace and summary niceties #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…airwindsOps#103)" This reverts commit e55026d.
Revamp e2e Tests (FairwindsOps#118)
Merge Master
The VPAUpdateMode field will allow us to use Goldilocks to create VPAs that operate outside of "off" mode.
This commit adds a parameter to createVPA that allows the user to specify the update mode for the VPA. The mechanism for specifying this is the label goldilocks.fairwinds.com/vpaUpdateMode.
Kubernetes labels are based on DNS names, which are case insensitive. However, the current label used to specify the update mode of created VPAs, vpaUpdateMode, is case sensitive. This has caused a bug that results in all VPAs being created in "Off" mode. This commit fixes that bug by using a case-insensitive label to specify the vpa-update-mode.
Hkatz/add vpa update mode
Merge masters
Also: - Update reconciler to use VPA and Deployment objects directly (instead of names) - Update reconciler logging - Update/Add vpa tests
Also: - Update vpa tests - Fix vpa-opt-out logic
Co-Authored-By: Andrew Suderman <andrew@sudermanjr.com>
Co-Authored-By: Andrew Suderman <andrew@sudermanjr.com>
Co-authored-by: Harrison Katz <hkatz@squarespace.com>
Merge master from upstream
Hkatz/dashboard and summary overhaul
…d _significantly_
Co-authored-by: Andrew Suderman <andrew@sudermanjr.com>
…i-call Hkatz/batch summary deployments api call
Hkatz/batch summary deployments api call (FairwindsOps#194)
hjkatz
commented
Aug 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 52.07% 51.65% -0.43%
==========================================
Files 8 8
Lines 601 606 +5
==========================================
Hits 313 313
- Misses 257 261 +4
- Partials 31 32 +1
Continue to review full report at Codecov.
|
sudermanjr
approved these changes
Aug 13, 2020
lucasreed
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-creating PR#195
Why?
These are some minor improvements to the overall usage of the new namespace list, dashboard, and summary that I decided to include in a separate PR than the originally very large one.
What?
<enter>and such)