Hkatz/vpa updates more tests and pointers #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…airwindsOps#103)" This reverts commit e55026d.
Revamp e2e Tests (FairwindsOps#118)
Merge Master
The VPAUpdateMode field will allow us to use Goldilocks to create VPAs that operate outside of "off" mode.
This commit adds a parameter to createVPA that allows the user to specify the update mode for the VPA. The mechanism for specifying this is the label goldilocks.fairwinds.com/vpaUpdateMode.
Kubernetes labels are based on DNS names, which are case insensitive. However, the current label used to specify the update mode of created VPAs, vpaUpdateMode, is case sensitive. This has caused a bug that results in all VPAs being created in "Off" mode. This commit fixes that bug by using a case-insensitive label to specify the vpa-update-mode.
Hkatz/add vpa update mode
Merge masters
Also: - Update reconciler to use VPA and Deployment objects directly (instead of names) - Update reconciler logging - Update/Add vpa tests
Also: - Update vpa tests - Fix vpa-opt-out logic
Co-Authored-By: Andrew Suderman <andrew@sudermanjr.com>
Co-Authored-By: Andrew Suderman <andrew@sudermanjr.com>
Merge master from upstream
Hkatz/dashboard and summary overhaul
…d _significantly_
Co-authored-by: Andrew Suderman <andrew@sudermanjr.com>
…i-call Hkatz/batch summary deployments api call
Hkatz/batch summary deployments api call (FairwindsOps#194)
Hkatz/namespace and summary niceties
Update master from upstream
…update VPAs during reconciliation
|
Not sure how there are conflicts... everything is updated on my end. I'm going to fiddle with git and try to figure out what's going on and may close/reopen this PR. |
Update client go and vpa (FairwindsOps#203)
…ore-tests-and-pointers
Ok I figured out that I was missing the v1beta2 -> v1 changes so I've merged those. |
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
==========================================
+ Coverage 51.57% 52.86% +1.29%
==========================================
Files 8 8
Lines 605 611 +6
==========================================
+ Hits 312 323 +11
+ Misses 261 258 -3
+ Partials 32 30 -2
Continue to review full report at Codecov.
|
sudermanjr
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Here's the last PR from the set of changes Squarespace has made in their local fork. This last set of changes aims to improve the simplicity of the create/update/delete process for VPAs, Deployments, and Namespaces by using the real objects instead of string names throughout the reconciliation process. This comes with the added advantage of being able to test/mock these individual calls and methods.
What?
getVPAObject()to return an in-time state representation of the VPA and then use that for create/update/delete as needed