[pull] main from chromium:main #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
https://pdfium.googlesource.com/pdfium.git/+log/9cb315df6674..5e0f14ee7cb3 2021-11-30 thestig@chromium.org Add an allowed_hosts entry in DEPS. 2021-11-30 thestig@chromium.org Reformat some DEPS entries. 2021-11-30 thestig@chromium.org Fetch third_party/skia directly from canonical Skia git repo. 2021-11-30 dhoss@chromium.org Elevate v8::Isolate::GetCurrent() PRESUBMIT warning to error 2021-11-30 awscreen@chromium.org Roll tools/clang/ 203feb789..401e727f2 (48 commits) 2021-11-30 awscreen@chromium.org Roll buildtools/ a9bc3e283..075dd7e22 (6 commits) 2021-11-30 awscreen@chromium.org Roll buildtools/third_party/libc++abi/trunk/ 9eb024522..665b74f7d (27 commits) 2021-11-30 awscreen@chromium.org Roll third_party/zlib/ bffc82b23..2231b7c84 (4 commits) 2021-11-30 awscreen@chromium.org Roll buildtools/third_party/libunwind/trunk/ 557b51a0c..c936d73ff (18 commits) 2021-11-30 awscreen@chromium.org Roll third_party/nasm/ 335fe83e1..9215e8e1d (1 commit) 2021-11-30 awscreen@chromium.org Roll base/trace_event/common/ 68d816952..7f36dbc19 (1 commit) 2021-11-30 awscreen@chromium.org Roll third_party/freetype/src/ 946df2216..3b45f564e (74 commits) 2021-11-30 awscreen@chromium.org Roll third_party/googletest/src/ 075810f7a..e2f397893 (28 commits) 2021-11-30 awscreen@chromium.org Roll tools/memory/ 4dc64cab4..bfbdc93fb (2 commits) 2021-11-30 awscreen@chromium.org Roll v8/ cfdefde63..b2d7879f8 (681 commits) 2021-11-30 awscreen@chromium.org Update gn_version to b79031308cc878488202beb99883ec1f2efd9a6d. 2021-11-30 awscreen@chromium.org Roll third_party/libjpeg_turbo/ 49836d72b..02959c3ee (1 commit) 2021-11-30 awscreen@chromium.org Roll third_party/icu/ eedbaf76e..bf66d373a (3 commits) 2021-11-30 tsepez@chromium.org Remove needless null checks in CPDF_Array/Dict range-based loops. 2021-11-30 tsepez@chromium.org Fix size_t vs. int mismatch in CPWL_EditImpl::DoInsertText(). 2021-11-30 awscreen@chromium.org Roll third_party/depot_tools/ 7cdf1424b..0b037419f (139 commits; 61 trivial rolls) 2021-11-30 tsepez@chromium.org Avoid null checks immediately following CPDF_Array bounds checks. 2021-11-29 tsepez@chromium.org Introduce CPDF_Array::Find(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in PDFium: https://bugs.chromium.org/p/pdfium/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1275239 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I732074be106d0c9ebb4c09ca20100ad783f01074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309954 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#946850}
This option is not supported now. Bug: 1271841 Change-Id: I3fd5c7b7dcc49badb4ca57f95d3310ef8ae18f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309979 Commit-Queue: Junji Watanabe <jwata@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/main@{#946851}
Bug: 738465 Change-Id: Idb74df0871f7038ed7f153d22eec29860b5175a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299711 Reviewed-by: Justin Novosad <junov@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#946852}
All combinations of these options should in fact work. Bug: N/A Change-Id: I506857504a4d7f71c62f07aa75a910c86f66c87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309237 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/main@{#946853}
…g-box| We should refer to ObjectBoundingBox() instead of OffsetInContainerFragment() and Size(). Bug: 1274192 Change-Id: Ie563c740ac32f258c7097568367b0dcc3864a60c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306741 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#946854}
This CL moves the 7th batch of files for
{ => ash}/components/arc/mojom:mojom
This CL moves a few more mojom files from the top of the dependency
tree.
https://graphviz.corp.google.com/png?graph_id=64927213e30088a9c248b15d84c5aefc
This is part of the LaCrOs directory migration
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE
Bug: b:129295708
Bug: 1164001
Test: CI
Change-Id: I27358b2bd4bfaa5b485d05bb6b352433bd7d694d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309158
Commit-Queue: Yao Li <yaohuali@google.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Owners-Override: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/main@{#946855}
See issue 1274431 for background. C++17 makes class-level static constexpr variables implicitly inline, but for the _KEY_DECL pattern the address of these variables matters. Yet it's different in different shared libraries. To fix, make them const. Should fix CloseListenerHostBrowserTest.SignalCloseWatcher* in component builds. (https://chromium-review.googlesource.com/c/chromium/src/+/3307487 was another similar change, as was https://chromium-review.googlesource.com/c/chromium/src/+/3309238) Bug: 752720,1274431 Change-Id: I60bcf2b899295dd2a3a727d6dacbc56d358a98b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308560 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Owners-Override: Darren Shen <shend@google.com> Cr-Commit-Position: refs/heads/main@{#946856}
This reverts commit 02b49cd. Reason for revert: Findit (https://goo.gl/kROfz5) identified this CL at revision 02b49cd as the culprit for failures in the continuous build including: Sample Failed Build: https://ci.chromium.org/b/8829082478045135105 Sample Failed Step: compile If it is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?status=Available&comment=Datastore+key+for+the+culprit+entity%3A+chromium.googlesource.com%2Fchromium%2Fsrc%2Frefs%2Fheads%2Fmain%2F02b49cd3b2f51bdbc264553419a2590e4a6b91ef&labels=Test-Findit-Wrong&components=Tools%3ETest%3EFindIt&summary=Wrongly+blame+02b49cd3b2f51bdbc264553419a2590e4a6b91ef Original change's description: > Build with C++17 on iOS > > This is to find unknown things that break with -std=c++17. > > Do NOT use C++17 features anywhere yet. We'll likely have to revert > this again in a bit. > > With this, C++17 is enabled everywhere except in CFI builds. > > To make crashpad build, define > _LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS in the one file that > uses the now-removed std::unexpected_handler. > > Bug: 752720,1274565 > Change-Id: I5ea9853bb82c04795fd03283bc96317cfb31573e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307901 > Auto-Submit: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/main@{#946842} Change-Id: I181a510960483899e0d3bdfab098b3fa0c0fb1d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 752720,1274565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309892 Reviewed-by: Darren Shen <shend@chromium.org> Owners-Override: Darren Shen <shend@google.com> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/main@{#946857}
* This is an automated release commit. * Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: I5e9149e5d09352a6d27860e2b23c91d7181bed50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307325 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#946858}
These checks are redundant since AddEvent() checks it internally. Bug: N/A Change-Id: I3c55bad5e5a486cde5ee04a4982c641011722b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308349 Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#946859}
…check error" This reverts commit 4f6e94d. Reason for revert: Caused performance issue 1271918. Bug: 1271918 Original change's description: > Do not display grammar error if there it overlaps with spell check error > > Bug: 1249351 > Change-Id: I8022f095e0d4e3dcc446205269faf87d0a8e8793 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3159841 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Commit-Queue: Jing Wang <jiwan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#923692} Bug: 1249351 Change-Id: Ib348bcd087b39d933d4b00eb123cbc7ae8bb3507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309944 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/main@{#946860}
This basically reverts the change in element.h in crrev.com/946284 which increased build cost. Change-Id: I95c78655418c840f5339da3b0c6f5cce875f0988 Bug: 1275202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306785 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#946861}
With Python-Markdown upgraded to 3.3.4, update the usage and migrate to Python3. Python3.6+ is supported, and Python2 is no longer supported. BUG=chromium:1224332 TEST=python3 md_browser.py -d /mnt/host/source/docs/ Change-Id: I61c762e9d7b46b63e8a050fda6858f5032be76b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3301132 Commit-Queue: Yu-Ping Wu <yupingso@chromium.org> Auto-Submit: Yu-Ping Wu <yupingso@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/main@{#946862}
This became unused once FilesNG became the default. Test: Visually checked the breadcrumbs on linux-chromeos Bug: 1102263 Change-Id: I563e74c54f5909fc487bd9027953c51677c72d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306768 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Ben Reich <benreich@chromium.org> Reviewed-by: Ben Reich <benreich@chromium.org> Cr-Commit-Position: refs/heads/main@{#946863}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I63ac2b9d7bee82f95959b2923148dca18cee80c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310002 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#946864}
This CL updates the AppServiceProxyBase::LaunchAppWithParams method to have the launch prevention dialog, metrics recording, and post launch tasks as other Launch interfaces. BUG=1244506 Change-Id: Ic04e8e3183cf6ab2bd9b1189ea4e8e5321d33cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308477 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#946865}
Following glazunov@'s idea [1], this add NO_STACK_PROTECTOR to raw_ptr methods. It is necessary to convert ContentMainRunnerImpl::delegate_ to raw_ptr. See the linked bug for more details. The same method with CheckedPtrNoOpImpl Performance Change doc [2] didn't find anything strange with this change at lease in chrome/ and content/. [1] https://crbug.com/1274129#c5 [2] https://docs.google.com/document/d/1f5Xv-zVHN1JUotjePvZ5jN6and8RxqHnXDu0esZr3rk/edit?usp=sharing Bug: 1274129 Change-Id: Ia3d0ab484be4c08b67377368d81df7da0e98773c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3305993 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Reviewed-by: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#946866}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/abf0e77a657c..f50ffd420f04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shend@google.com Change-Id: Ia1d4d27e687c1a8cd1e19d860827549471eeea92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308428 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#946867}
Roll Chrome Win64 PGO profile from chrome-win64-main-1638316670-290f167afd9cd714a76b7ec3831879aaa7ade2fa.profdata to chrome-win64-main-1638327546-046e3fb9f0967fb4748d31298790a3fab8008487.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifcc38d3c4a5511067694d2e01e5a2757f4067a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310137 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#946868}
scoped_feature_list_ needs to be initialized before tasks on other threads access the feature list, and destroyed after task_environment_ is torn down. Change-Id: I06adb04c691051898fbb35d62f200e4a54d437be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308540 Reviewed-by: Angela Yoeurng <yoangela@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/main@{#946869}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f1bbca195f7a..f5e64e21f499 2021-12-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If83c18e6a21c0c5d17acf32853d90ffb89fd5a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309724 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#946870}
Bug: b/208332468 Test: manual test Change-Id: I9f33b5a2e0e28349e1a573027ab7a9a01b1beac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3305008 Reviewed-by: Daniel Nishi <dhnishi@chromium.org> Commit-Queue: Guanru Lee <guanrulee@chromium.org> Cr-Commit-Position: refs/heads/main@{#946871}
Roll Chrome Win32 PGO profile from chrome-win32-main-1638295043-755fb6865447a4c8bb4df3f472397a4ac307f3f5.profdata to chrome-win32-main-1638327546-e2b0f33c650f9bc46745bfa55cacc5795f470a2e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic7a0bcc67b38ae3742eb0e391351ffc031882e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309723 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#946872}
After CL:3295870 pak_util defaults to also decompress compressed resources. Since we don't need to decompress those for cca deploy, and decompressing those need the brotli binary, add '--raw' to avoid the decompressing. Bug: b:208523302 Test: manually try `cca deploy` Change-Id: I997f6f5b11f8d8ca0ca137973c0644646c684b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307867 Reviewed-by: Wei Lee <wtlee@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#946873}
cr-button should use aria-pressed attribute instead of aria-selected. BUG=none TEST=on tablet mode device with chromevox enabled, open wallpaper SWA and select from "my images". CVox should read pressed state of crop option buttons. Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I21bb9923baafcdcf41c61276e9c98c5c3bbf23dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306685 Reviewed-by: Yue Li <updowndota@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/main@{#946874}
Incorporate usage of StartPrinting() from within the Print Backend service utility for Windows, macOS, Linux, and ChromeOS. Testing coverage currently covers only Windows, macOS, and Linux. Adjust PrintUpdateSettings() to cache the print target type from the job settings. This is needed by the later call to StartPrinting(), since the deferred actions of PrintingContext::UpdatePrinterSettings() are not done in the service until StartPrinting() time. Include registration with the PrintBackendServiceManager so that the Print Backend process does not get terminated if there is a short amount of idleness between printing operations for this job. Only include unregister logic for failure case, since the printing success case logic comes later in https://crrev.com/c/3199044. Add ability for TestPrintingContext to respond with access-denied error for NewDocument() to enable testing of StartPrinting() fallback retry logic. Bug: 809738 Change-Id: I3713e59de44dba3f45eeb0921bd7adbb6eab2514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180059 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#946875}
https://chromium.googlesource.com/vulkan-deps.git/+log/b83177223d96..09e892902929 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/febbeb4f83..0e1396862c * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/20b02de995..993b82fe63 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/8ac4d2846e..36cc581621 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8aabd3871b..c6bafff88f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com,kainino@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng Bug: None Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com,kainino@google.com Change-Id: I8e70881460e5116b945f070d56e213ba43f9ba8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309602 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#946876}
If user navigates to a ListBox with linear navigation (Search + L/R),
navigation does not get into the ListBox options.
options if user has navigated to the ListBox using the same
approach.
Bug: 1228491
Ax-Relnotes: Next/Previous Object commands will not iterate ListBox
Change-Id: I2a19794bf6d70bb9d8ae6a5efe1b7b466e9ff353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3288989
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/main@{#946877}
Change the tolerance in IsRenderable from absolute value to relative to tolerate more for big values. Bug: 1264505 Change-Id: I96e5d788cdc22cff794e8f7cfbbc066621143c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308232 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/main@{#946878}
Now that we created a separate AppServiceProxy for Lacros, we should rename the AppServiceProxyChromeOs to AppServiceProxyAsh as it only work for ash. BUG=1225827 Change-Id: Ib3eee11062038242b4a6582233d1c86e5b752700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306763 Reviewed-by: Nancy Wang <nancylingwang@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/main@{#946879}
Spec (Figma access required): http://shortn/_wmaaacmj6T Screenshots: - http://screen/3VU5gEY6cBACa59 (Updating) - http://screen/469g489zP5AucLN (Update completed) Bug: 1252981 Change-Id: If72398bad095879f17f5f30e51de94ecbf0fd23b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3293524 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/main@{#947077}
Roll Chrome Win32 PGO profile from chrome-win32-main-1638359845-4b9287218bf677c438fb4f590c01932f19f4742c.profdata to chrome-win32-main-1638370723-e0c73e87080a6ac5bf65eb692830edd320203e34.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I78e6dfb65a248e84c5946d86eaf403d2ee504283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310713 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947078}
Bug: 1254834 Change-Id: Iec066cbd4348c96730e4971be658f1958cc51742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307696 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/main@{#947079}
https://docs.google.com/document/d/1CwYuMXnVQsRsghwVzEkWj9GZzfERputSLQaKx5xLhjQ This CL was uploaded by git cl split. R=jonmann@chromium.org Bug: 1187033 Change-Id: I6ccee18345fa60469e66ea4bb49434b41ca05aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297854 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#947080}
This CL attempts to deflake test by making sure re-encryption happens before opening the tab. Below is the sample scenario that could cause flakiness before: 1. First client enables encryption. It does trigger re-encyption on both clients once passphrase is entered on the second. 2. First client opens the tab and triggers sessions commit, FakeServer accepts this commit. 3. Second client isn't yet aware of the changes and attempts to re-encrypt the data corresponding to sessions from the first client (there are some sessions even before the tab is explicitly opened). 4. Fake server doesn't have conflict resolution logic and accepts commit from the second client. 5. Second client never see sessions update with opened tab and test fails. The flakiness was reproduced locally and it wasn't possible to reproduce it with the same setup after the fix. Bug: 1273908 Change-Id: I53ce13c84dd1a4677bc665dc717ada6a7eecd7c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310863 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/main@{#947081}
This CL does the following things: (1) Remove `AppListModel::DeleteAllItems()` since it is never used (2) Add an extra parameter to `DeleteItem` to indicate whether the parent folder of the deleted item can be cleaned. Replace `AppListModel::DeleteUninstalledItem()` with `DeleteItem(id, /*can_ clean_folder=*/true)` This CL should not bring any noticeable differences. Bug: none Change-Id: I9811f25d28767bfa2593d53cb7c4f2f29e5c910b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297114 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/main@{#947082}
https://skia.googlesource.com/skia.git/+log/1c4f5183f103..aef2b63743e2 2021-12-01 kjlubick@google.com [canvaskit] Use closure in release Bazel builds 2021-12-01 herb@google.com fix device bounds for clipping test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: Ib9f28f01c73790c4ccfc474c0f32383f01913304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310715 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947083}
FileUtilTest.ReadFileToStringWithUnknownFileSize opens /dev/zero and reads from it. This new ScopedDevZero class allows us to move away from relying on /dev/zero being provided by the runtime. The attempt to make IPCSendFdsTest.DescriptorTest use ScopedDevZero doesn't quite work, so it is disabled for now. Bug: 1256502,1272424 Change-Id: Ib8cf077d40deb0063a21fe05c43ed6c7372ee198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256795 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Fabrice de Gans <fdegans@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/main@{#947084}
Change-Id: I01b9cd6b4c36147072fba902572e4a236106fb49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310959 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#947085}
Also ensure that routes which are conditionally added are always added for tests which require them. Bug: 1258590 Change-Id: Ic7ac4757ec193f82c6b88fe26f3403f18d0dbe4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3291732 Auto-Submit: Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/main@{#947086}
This deprecated API and associate code are only used as Chromecast. Mark it as Chromecast-only to reduce build cost on other platforms, and to make it harder to add new callers. Bug: 977637 Change-Id: I15260e371938e62fddc598c96d847ee37630e95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309879 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/main@{#947087}
https://docs.google.com/document/d/1CwYuMXnVQsRsghwVzEkWj9GZzfERputSLQaKx5xLhjQ This CL was uploaded by git cl split. R=michaelpg@chromium.org Bug: 1187033 Change-Id: I1a6897e977248f9c7301936ebdcc40908a80e035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298113 Auto-Submit: Carlos Caballero Grolimund <carlscab@google.com> Commit-Queue: Dan S <danan@chromium.org> Reviewed-by: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/main@{#947088}
Force installed extensions from non-CWS store requires device in managed
status. Moving the logic from PolicyHandler to PolicyLoader so that it
can have consistency behavior with other sensitive policies filter
like Mac support.
The blocked extensions will have "[BLOCKED]" so that they can be removed
by schema validation later. And the policy will get an error message to
indicate the reason of blocking.
Other changes:
* Improves the ExtensionInstallForcelist policy:
1) The filtering is now in place to reduce the # of copy operation.
2) Fix an issue when the list contains both invalid entry and entry
without update url, the entry without url will also be removed.
3) Append same error message as ExtensionSettings policy.
4) The EnterpriseCheck.InvalidPolicies only counts once for multiple
invalid entries in two extension policies.
* Add unit tests for the sensitive policies filtering.
Change-Id: I92a32f7d889897efd367d4f5ecff1f2512580be5
Bug: 1272848
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3303268
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#947089}
https://android.googlesource.com/platform/external/perfetto.git/+log/b3264966e5b0..9296f1edfee5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie2cc22b5beeba491383e882c909220a3989f9c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309473 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947090}
This CL adds an icon to paired devices list item to indicate that a Bluetooth device is currently being managed by enterprise policy. Screenshot: https://screenshot.googleplex.com/B5mc8WXLoeoKti9.png Bug: 1010321 Change-Id: Ib618a1ef3f839a66c836be61657f3eb937b22bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308390 Reviewed-by: Gordon Seto <gordonseto@google.com> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/main@{#947091}
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1979aadbf44f..6badd12fdf7c 2021-12-01 shaochuan@chromium.org cros_mark_android_as_stable: add tests for main 2021-12-01 shaochuan@chromium.org cros_mark_android_as_stable: output paths relative to overlay 2021-12-01 msalomao@google.com cros-disk: remove disk from mkfs's supplementary groups 2021-12-01 chrome-bot@chromium.org Automated Commit: Updated config generated by config-updater builder. 2021-12-01 jojwang@google.com chromite changes for remoteexec builder support. 2021-12-01 denik@google.com toolchain_util: Fix profile path 2021-11-30 mikenichols@chromium.org repo_sync_manifest: Remove BuildRootGitCleanup call 2021-11-30 sloanjohnson@google.com Reland "cros_run_unit_tests: Add --host option to run tests on host" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Iead08c212cec266aa1db32af950778cff47b4be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310708 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947092}
…e GN arg is set Bug: 1273029 Change-Id: Ide4ce89e23d07a41a4bdb2b19ef0e4ad7bd5e27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310487 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Owners-Override: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#947093}
…dropped The DroppedFrameAfterScrollStart metric reporting is moved to check if the frame is dropped and fpc is received before reporting the metric similar to other metrics collected in dropped_frame_counter. Bug: chromium:1275569 Change-Id: Ib16c2eff586d13dd956c5fcb44956dd6440053d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306793 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/main@{#947094}
No behavior is changed, please see the linked bug for context. Bug: 1270524 Change-Id: I3bf4b7036764439c8b62c9000b75546fd35f67b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3289410 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#947095}
Bug: 1274957 Change-Id: Ia0ca318104039cceac65bf869f1dc8e72ce710ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307490 Commit-Queue: Haiyang Pan <hypan@google.com> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/main@{#947096}
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/c531d83e7869..6dd2ea962ece 2021-12-01 rharrison@google.com Implement `floor` tests (#843) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I25741fa9fefa15581b4258fc0968fdd3ef92a79f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310998 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947097}
https://android.googlesource.com/platform/external/perfetto.git/+log/70f73380a554..9296f1edfee5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If29b6fadd676606697a54d53ab584ccf4f6f7ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309474 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947098}
https://dawn.googlesource.com/dawn.git/+log/2294cf44802b..e7efad03259a 2021-12-01 bajones@chromium.org Copy from a zeroed-out buffer to clear in D3D12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I4aa9aee3ce6d44af808805ce138858b3238823c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3311000 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947099}
pull bot
pushed a commit
that referenced
this pull request
Jan 14, 2022
This reverts commit 6ff1599. Reason for revert: Seems to have caused browser_test failures on linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/19698 rowserTestBase received signal: Segmentation fault. Backtrace: #0 0x563ae696f899 base::debug::CollectStackTrace() #1 0x563ae68d6683 base::debug::StackTrace::StackTrace() #2 0x563ae6ff8293 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f9ac9026040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x563ae7720266 PrefChangeRegistrar::RemoveAll() #5 0x563ae7720222 PrefChangeRegistrar::~PrefChangeRegistrar() #6 0x563ae2f37095 std::__1::unique_ptr<>::reset() #7 0x563ae3696a1b policy::ActiveDirectoryMigrationManager::~ActiveDirectoryMigrationManager() #8 0x563ae3696a38 policy::ActiveDirectoryMigrationManager::~ActiveDirectoryMigrationManager() #9 0x563ae369a699 policy::BrowserPolicyConnectorAsh::~BrowserPolicyConnectorAsh() #10 0x563ae369a6fe policy::BrowserPolicyConnectorAsh::~BrowserPolicyConnectorAsh() #11 0x563ae6a0edbd BrowserProcessImpl::~BrowserProcessImpl() #12 0x563ae6a0edea BrowserProcessImpl::~BrowserProcessImpl() #13 0x563ae6a668e9 browser_shutdown::ShutdownPostThreadsStop() #14 0x563ae6a0e226 ChromeBrowserMainParts::PostDestroyThreads() #15 0x563ae349ef9b ash::ChromeBrowserMainPartsAsh::PostDestroyThreads() #16 0x563ae495d2d9 content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #17 0x563ae495e53c content::BrowserMainRunnerImpl::Shutdown() #18 0x563ae495a9ce content::BrowserMain() #19 0x563ae555e819 content::RunBrowserProcessMain() #20 0x563ae555f8e0 content::ContentMainRunnerImpl::RunBrowser() #21 0x563ae555f431 content::ContentMainRunnerImpl::Run() #22 0x563ae555d209 content::RunContentProcess() #23 0x563ae555d861 content::ContentMain() #24 0x563ae6ff6f2b content::BrowserTestBase::SetUp() #25 0x563ae68bf947 InProcessBrowserTest::SetUp() #26 0x563ae3b0fbed testing::Test::Run() #27 0x563ae3b10520 testing::TestInfo::Run() #28 0x563ae3b10ce1 testing::TestSuite::Run() #29 0x563ae3b1a61a testing::internal::UnitTestImpl::RunAllTests() #30 0x563ae3b1a219 testing::UnitTest::Run() #31 0x563ae69d5af8 base::TestSuite::Run() #32 0x563ae688bfa1 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #33 0x563ae70407b7 content::LaunchTests() #34 0x563ae688e77a LaunchChromeTests() #35 0x563ae688bf23 main #36 0x7f9ac9008bf7 __libc_start_main #37 0x563ae134462a _start Original change's description: > Remote powerwash on Chromad via policy > > Implement remote powerwash on Chromad, using the recently added > ChromadToCloudMigrationEnabled policy. The powerwash will be used to > start the migration of AD managed devices into cloud management. Besides > having the new policy enabled, the device needs to be on the login > screen and the enrollment ID must have already been uploaded to > DMServer. > > Bug: 1209246 > Change-Id: I6a67b8a8a43c28bc5f03f27e96d0415f69b6bc83 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3141873 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Roman Sorokin <rsorokin@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Felipe Andrade <fsandrade@chromium.org> > Cr-Commit-Position: refs/heads/main@{#959123} Bug: 1209246 Change-Id: If067abcf2a9289ebacaeb240b1f67749c305509c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3389555 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#959243}
pull bot
pushed a commit
that referenced
this pull request
Aug 31, 2022
This reverts commit 395b2b1. Reason for revert: the following test cases fail - MediaFoundationRendererIntegrationTest.BasicPlayback - MediaFoundationRendererIntegrationTest.BasicPlayback_MediaSource on Windows 10/Asan with the failure log: [ RUN ] MediaFoundationRendererIntegrationTest.BasicPlayback ================================================================= ==644==ERROR: AddressSanitizer: access-violation on unknown address 0x000000000008 (pc 0x7ff6889a1e92 bp 0x00c26c4fe5f0 sp 0x00c26c4fe560 T0) ==644==The signal is caused by a READ memory access. ==644==Hint: address points to the zero page. ==644==*** WARNING: Failed to initialize DbgHelp! *** ==644==*** Most likely this means that the app is already *** ==644==*** using DbgHelp, possibly with incompatible flags. *** ==644==*** Due to technical reasons, symbolization might crash *** ==644==*** or produce wrong results. *** #0 0x7ff6889a1e91 in base::RepeatingCallback<void (const base::UnguessableToken &, const gfx::Size &, base::TimeDelta)>::Run C:\b\s\w\ir\cache\builder\src\base\callback.h:263 #1 0x7ff6889a1e91 in media::MediaFoundationRenderer::RequestNextFrame(void) C:\b\s\w\ir\cache\builder\src\media\renderers\win\media_foundation_renderer.cc:1022:23 #2 0x7ff68899bed8 in media::MediaFoundationRenderer::OnPlaying(void) C:\b\s\w\ir\cache\builder\src\media\renderers\win\media_foundation_renderer.cc:838:3 #3 0x7ff68a04bb3a in base::OnceCallback<void ()>::Run C:\b\s\w\ir\cache\builder\src\base\callback.h:145 #4 0x7ff68a04bb3a in base::TaskAnnotator::RunTaskImpl(struct base::PendingTask &) C:\b\s\w\ir\cache\builder\src\base\task\common\task_annotator.cc:133:32 #5 0x7ff68ac91059 in base::TaskAnnotator::RunTask C:\b\s\w\ir\cache\builder\src\base\task\common\task_annotator.h:72 #6 0x7ff68ac91059 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(class base::LazyNow *) C:\b\s\w\ir\cache\builder\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:422:21 #7 0x7ff68ac90046 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork(void) C:\b\s\w\ir\cache\builder\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:292:41 #8 0x7ff68acc53da in base::MessagePumpDefault::Run(class base::MessagePump::Delegate *) C:\b\s\w\ir\cache\builder\src\base\message_loop\message_pump_default.cc:39:55 #9 0x7ff68ac9316b in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, class base::TimeDelta) C:\b\s\w\ir\cache\builder\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:575:12 #10 0x7ff68960a00c in base::RunLoop::Run(class base::Location const &) C:\b\s\w\ir\cache\builder\src\base\run_loop.cc:141:14 #11 0x7ff68942c9a7 in media::PipelineIntegrationTestBase::RunUntilQuitOrError(class base::RunLoop *) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:697:13 #12 0x7ff689424636 in media::PipelineIntegrationTestBase::RunUntilQuitOrEndedOrError(class base::RunLoop *) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:709:3 #13 0x7ff689424449 in media::PipelineIntegrationTestBase::WaitUntilEndedOrError(void) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:226:5 #14 0x7ff689423ac4 in media::PipelineIntegrationTestBase::WaitUntilOnEnded(void) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:217:27 #15 0x7ff686ce4597 in media::MediaFoundationRendererIntegrationTest_BasicPlayback_Test::TestBody(void) C:\b\s\w\ir\cache\builder\src\media\renderers\win\media_foundation_renderer_integration_test.cc:92:3 #16 0x7ff6870b0c77 in testing::Test::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2670:5 #17 0x7ff6870b2c3b in testing::TestInfo::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2849:11 #18 0x7ff6870b498e in testing::TestSuite::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:3008:30 #19 0x7ff6870d772f in testing::internal::UnitTestImpl::RunAllTests(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:5866:44 #20 0x7ff6870d6bd5 in testing::UnitTest::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:5440:10 #21 0x7ff6896d7a69 in RUN_ALL_TESTS C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\include\gtest\gtest.h:2284 #22 0x7ff6896d7a69 in base::TestSuite::Run(void) C:\b\s\w\ir\cache\builder\src\base\test\test_suite.cc:463:16 #23 0x7ff6896dc4ed in base::OnceCallback<int ()>::Run C:\b\s\w\ir\cache\builder\src\base\callback.h:145 #24 0x7ff6896dc4ed in base::`anonymous namespace'::LaunchUnitTestsInternal C:\b\s\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:181:38 #25 0x7ff6896dc0ba in base::LaunchUnitTests(int, char **, class base::OnceCallback<(void)>, unsigned __int64) C:\b\s\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:272:10 #26 0x7ff686dcc7f9 in main C:\b\s\w\ir\cache\builder\src\media\test\run_all_unittests.cc:52:10 #27 0x7ff68c67712b in invoke_main d:\a01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:78 #28 0x7ff68c67712b in __scrt_common_main_seh d:\a01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 #29 0x7fff384a2773 (C:\Windows\System32\KERNEL32.DLL+0x180012773) #30 0x7fff386e0d50 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: access-violation C:\b\s\w\ir\cache\builder\src\base\callback.h:263 in base::RepeatingCallback<void (const base::UnguessableToken &, const gfx::Size &, base::TimeDelta)>::Run ==644==ABORTING Original change's description: > [MediaFoundation] Request next frame during onPlaying event > > OS: Win10, Win11 > > During OnPlaying event, a frame request should be called to get > the first frame to output at the earliest possible time. This > is the earliest time when a frame is available. Current > implementation waits for render to be called, while > StartPlayingFrom's call for RequestNextFrameBetweenTimestamps > may not output a result if the media engine is not yet ready > to output a frame. > > Bug: 1355520 > Change-Id: Ice60ac41ca4b8cae9b0687626e93017d0a4406f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852409 > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Commit-Queue: Daoyuan Li <daoyuanli@microsoft.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1041097} Bug: 1355520 Change-Id: Ic483e314ce14e3f187691df772515eacea387cb1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3863075 Commit-Queue: Asami Doi <asamidoi@chromium.org> Owners-Override: Asami Doi <asamidoi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1041256}
pull bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
Differently than all other browsers tested (including Firefox/Linux, Chrome/X11, Web, etc), Chromium/Wayland is triggering key auto-repeat logic for modifier keys, eg alt, shift and control. Despite the mismatch in behavior with other major browsers, Lacros (which is based on Ozone/Wayland) is also having problems with left-over auto-repeat logic being ran, after the user performed a no-op alt-tab'ing. Basically, when an alt-tab starts on Ash, off of Lacros: 1/ ozone/wayland can trigger the auto-repeat logic for ALT key; 2/ if the alt-tab is no-op, the lacros can be left-over with the ALT key auto-repeat logic ON. This state breaks any subsequent tab-dragging operation with the following pseude-stack: #1 base::debug::StackTrace::StackTrace() #2 TabStrip::TabDragContextImpl::DestroyDragController() #3 TabDragController::EndDrag() (...) #25 ui::PlatformEventSource::DispatchEvent() #26 ui::WaylandEventSource::OnKeyboardKeyEvent() #27 ui::WaylandKeyboard::DispatchKey() #28 ui::WaylandKeyboard::DispatchKey() #29 ui::EventAutoRepeatHandler::OnRepeatCommit() #30 _ZNO4base12OnceCallbackIFvvEE3RunEv #31 ui::WaylandKeyboard::SyncCallback() At least, two fixes need to be taken here: 1/ not trigger the auto-repeat key logic for modifiers (or somehow reset it); 2/ send a synthetic ALT key released event, when the App Switcher gets started in Ash, off of Lacros. This CL does /1/ above. BUG=1367014 R=nickdiego@igalia.com Change-Id: I7b69c873aef70cacbead10a35d9801fb263774a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4098284 Reviewed-by: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/main@{#1083211}
pull bot
pushed a commit
that referenced
this pull request
Feb 25, 2023
…ew." This reverts commit 508aa18. Reason for revert: Causes IbanBubbleViewFullFormBrowserTest.Local_ClickingHideOrShowIbanValueManageView failurees. from https://ci.chromium.org/ui/p/chromium/builders/ci/linux-ubsan-vptr/21221/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2Fchrome%2Ftest%3Ainteractive_ui_tests%2FIbanBubbleViewFullFormBrowserTest.Local_ClickingHideOrShowIbanValueManageView+VHash%3Ad2ca29b55d68a4ff: ../../chrome/browser/ui/views/autofill/payments/iban_bubble_view_uitest.cc:282:12: runtime error: downcast of address 0x0798015a1b00 which does not point to an object of type 'SaveIbanBubbleView' 0x0798015a1b00: note: object is of type 'autofill::ManageSavedIbanBubbleView' 29 00 00 00 38 f3 68 e6 e4 55 00 00 78 f3 68 e6 e4 55 00 00 c0 ce 6c 01 98 07 00 00 80 18 0b 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'autofill::ManageSavedIbanBubbleView' #0 0x55e4d02f0701 in autofill::IbanBubbleViewFullFormBrowserTest::GetSaveIbanBubbleView() chrome/browser/ui/views/autofill/payments/iban_bubble_view_uitest.cc:282:12 #1 0x55e4d02fb74f in autofill::IbanBubbleViewFullFormBrowserTest::ClickOnDialogView(views::View*) chrome/browser/ui/views/autofill/payments/iban_bubble_view_uitest.cc:345:5 #2 0x55e4d02f6e6e in autofill::IbanBubbleViewFullFormBrowserTest_Local_ClickingHideOrShowIbanValueManageView_Test::RunTestOnMainThread() chrome/browser/ui/views/autofill/payments/iban_bubble_view_uitest.cc:623:3 #3 0x55e4d99bf48e in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:895:7 #4 0x55e4d4a7be0d in Run base/functional/callback.h:152:12 #5 0x55e4d4a7be0d in content::BrowserMainLoop::InterceptMainMessageLoopRun() content/browser/browser_main_loop.cc:1038:36 #6 0x55e4d4a7bf1e in content::BrowserMainLoop::RunMainMessageLoop() content/browser/browser_main_loop.cc:1050:7 #7 0x55e4d4a811f9 in content::BrowserMainRunnerImpl::Run() content/browser/browser_main_runner_impl.cc:158:15 #8 0x55e4d4a75a6d in content::BrowserMain(content::MainFunctionParams) content/browser/browser_main.cc:32:28 #9 0x55e4d6fe2fbe in content::RunBrowserProcessMain(content::MainFunctionParams, content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:716:10 #10 0x55e4d6fe5438 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams, bool) content/app/content_main_runner_impl.cc:1276:10 #11 0x55e4d6fe4f4d in content::ContentMainRunnerImpl::Run() content/app/content_main_runner_impl.cc:1130:12 #12 0x55e4d6fe02ab in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) content/app/content_main.cc:324:36 #13 0x55e4d6fe0935 in content::ContentMain(content::ContentMainParams) content/app/content_main.cc:341:10 #14 0x55e4d99be269 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:575:3 #15 0x55e4d7cec8e0 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:484:20 #16 0x55e4d0875e53 in SyncTest::SetUp() chrome/browser/sync/test/integration/sync_test.cc:300:24 #17 0x55e4d0e00c17 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2665:3 #18 0x55e4d0e0265e in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2849:11 #19 0x55e4d0e042fb in testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:3008:30 #20 0x55e4d0e1a210 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5866:44 #21 0x55e4d0e18dc8 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:5440:10 #22 0x55e4daaaa4a0 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2284:73 #23 0x55e4daaaa4a0 in base::TestSuite::Run() base/test/test_suite.cc:454:16 #24 0x55e4d7cb6b48 in ChromeTestSuiteRunner::RunTestSuiteInternal(ChromeTestSuite*) chrome/test/base/chrome_test_launcher.cc:95:22 #25 0x55e4d03f6416 in InteractiveUITestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/interactive_ui_tests_main.cc:134:12 #26 0x55e4d99fb844 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:415:31 #27 0x55e4d7cb722e in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:318:10 #28 0x55e4d03f63a1 in main chrome/test/base/interactive_ui_tests_main.cc:176:10 #29 0x7fbe2824bc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86) (BuildId: f7307432a8b162377e77a182b6cc2e53d771ec4b) #30 0x55e4cff4a029 in _start (/b/s/w/ir/out/Release/interactive_ui_tests+0xc8b2029) (BuildId: b65d070fe6c272ab) also: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20CFI/24652/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2Fchrome%2Ftest%3Ainteractive_ui_tests%2FIbanBubbleViewFullFormBrowserTest.Local_ClickingHideOrShowIbanValueManageView+VHash%3A18b587341aed5390 Original change's description: > [IBAN local save] Add eye icon to manage saved IBAN bubble view. > > This CL introduce Eye Icon to manage saved IBAN bubble view, which can > reveal full IBAN value or show masked IBAN on clicking. > > Screenshot: > https://screenshot.googleplex.com/3rtMkB6f6UhSL47 > > Mock: > https://screenshot.googleplex.com/FkAmHC4aPtzt44d > > Bug: 1349109 > Change-Id: I51afa60384ff1065785e8351f355eaa66c76fdd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4237378 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Qihui Zhao <qihuizhao@google.com> > Reviewed-by: Vinny Persky <vinnypersky@google.com> > Cr-Commit-Position: refs/heads/main@{#1109451} Bug: 1349109 Change-Id: I473c317aaf5d70e538e6ced970ecc4294491d069 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4291366 Commit-Queue: Brian Begnoche <bcb@chromium.org> Owners-Override: Brian Begnoche <bcb@chromium.org> Auto-Submit: Brian Begnoche <bcb@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1109581}
pull bot
pushed a commit
that referenced
this pull request
May 21, 2024
Attempting to initialize the GPU triggers MSan failures in GL with eager
checks enabled in MSan:
Uninitialized bytes in strlen at offset 0 inside [0x70200013dec0, 30)
==589==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x7fffeeba96de in glLabelObjectEXT (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x4f6de)
#1 0x7fffeeba9b10 in glLabelObjectEXT (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x4fb10)
#2 0x7fffeeb879a3 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x2d9a3)
#3 0x7fffeeb894c0 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x2f4c0)
#4 0x7fffeeb8e400 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x34400)
#5 0x7fffeeb8f384 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x35384)
#6 0x7fffeeb8bd9a (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x31d9a)
#7 0x7fffecceb484 in queryExtensionsString third_party/angle/src/libANGLE/renderer/gl/glx/FunctionsGLX.cpp:354:12
#8 0x7fffecceb484 in rx::FunctionsGLX::initialize(_XDisplay*, int, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>*) third_party/angle/src/libANGLE/renderer/gl/glx/FunctionsGLX.cpp:223:30
#9 0x7fffeccdada2 in rx::DisplayGLX::initialize(egl::Display*) third_party/angle/src/libANGLE/renderer/gl/glx/DisplayGLX.cpp:114:15
#10 0x7fffec70f649 in egl::Display::initialize() third_party/angle/src/libANGLE/Display.cpp:1082:36
#11 0x7fffec0bed17 in egl::Initialize(egl::Thread*, egl::Display*, int*, int*) third_party/angle/src/libGLESv2/egl_stubs.cpp:514:5
#12 0x7fffec0c6319 in EGL_Initialize third_party/angle/src/libGLESv2/entry_points_egl_autogen.cpp:571:27
#13 0x7fffefc4000d in eglInitialize third_party/angle/src/libEGL/libEGL_autogen.cpp:177:12
#14 0x5555868ec92a in gl::GLDisplayEGL::InitializeDisplay(bool, std::__Cr::vector<gl::DisplayType, std::__Cr::allocator<gl::DisplayType>>, gl::EGLDisplayPlatform, gl::GLDisplayEGL*) ui/gl/gl_display.cc:769:10
#15 0x5555868eb310 in gl::GLDisplayEGL::Initialize(bool, std::__Cr::vector<gl::DisplayType, std::__Cr::allocator<gl::DisplayType>>, gl::EGLDisplayPlatform) ui/gl/gl_display.cc:660:8
#16 0x55556c6f1957 in ui::GLOzoneEGL::InitializeGLOneOffPlatform(bool, std::__Cr::vector<gl::DisplayType, std::__Cr::allocator<gl::DisplayType>>, gl::GpuPreference) ui/ozone/common/gl_ozone_egl.cc:25:17
#17 0x55558b1a8999 in gl::init::InitializeGLOneOffPlatform(gl::GpuPreference) ui/gl/init/gl_initializer_ozone.cc:27:26
#18 0x55558b1a6978 in gl::init::InitializeGLOneOffPlatformImplementation(bool, bool, bool, gl::GpuPreference) ui/gl/init/gl_factory.cc:211:24
#19 0x55558b1a6208 in gl::init::(anonymous namespace)::InitializeGLOneOffPlatformHelper(bool, gl::GpuPreference) ui/gl/init/gl_factory.cc:135:10
#20 0x55558b1a662d in gl::init::InitializeGLNoExtensionsOneOff(bool, gl::GpuPreference) ui/gl/init/gl_factory.cc:166:10
#21 0x55558b227379 in gpu::GpuInit::InitializeAndStartSandbox(base::CommandLine*, gpu::GpuPreferences const&) gpu/ipc/service/gpu_init.cc:495:18
#22 0x55559ab41ce4 in content::GpuMain(content::MainFunctionParams) content/gpu/gpu_main.cc:358:39
#23 0x55557b5888da in content::RunZygote(content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:685:14
#24 0x55557b58abad in content::RunOtherNamedProcessTypeMain(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, content::MainFunctionParams, content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:789:12
#25 0x55557b58e4fe in content::ContentMainRunnerImpl::Run() content/app/content_main_runner_impl.cc:1156:10
#26 0x55557b585aaf in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) content/app/content_main.cc:332:36
#27 0x55557b58644a in content::ContentMain(content::ContentMainParams) content/app/content_main.cc:345:10
#28 0x555580df9c37 in content::LaunchTestsInternal(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:385:12
#29 0x555580dfab58 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:504:10
#30 0x555582b8afec in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:392:10
#31 0x55557d422a0e in main chrome/test/base/browser_tests_main.cc:60:10
#32 0x7ffff48456c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
#33 0x7ffff4845784 in __libc_start_main csu/../csu/libc-start.c:360:3
#34 0x55555e647029 in _start (/usr/local/google/home/dcheng/src/chrome/src/out/msan/browser_tests+0x90f3029) (BuildId: 6cbc295b16ac1107)
Uninitialized value was created by a heap allocation
#0 0x55555e675a22 in malloc /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cpp:1021:3
#1 0x7ffff489b087 in __vasprintf_internal libio/vasprintf.c:116:16
#2 0x4ae8d349882b18ff (<unknown module>)
Bug: 40240570
Change-Id: If59faa297e214b7219ebb4c5c9572b44a33ee070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548826
Reviewed-by: Elad Alon <eladalon@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1303583}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )