[pull] master from chromium:master #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Splits the test manifest generated by the //fuchsia/cipd:tests target into 3 different tests manifests: 1. A cast_runner manifest for the cast_runner_integration_tests. 2. A web_engine manifest for the web_* tests. 3. A common_tests manifest for everything else. Cq-Include-Trybots: luci.chromium.try:fuchsia-official Change-Id: I6fa427074e65533a851ac3950577772e97d71f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192169 Commit-Queue: Anirudh Mathukumilli <rudymathu@google.com> Reviewed-by: David Dorwin <ddorwin@chromium.org> Reviewed-by: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/main@{#926468}
Bug: none Change-Id: Ib7a037412d6e3deaacad39f6caa722dd4c1f8d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3188913 Auto-Submit: Behdadb <behdadb@chromium.org> Commit-Queue: Behdadb <behdadb@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/main@{#926469}
This CL adds the PrefsTabHelper to the WebContents instance which is used to propagate user prefs to the renderer process. These prefs define things such as active/inactive selection colors specifically used by WebContentses in chrome. Bug: 1243167 Change-Id: I293080809d86e9bbac2b7410900f015b413e6ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194783 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/main@{#926470}
Version Changes: eigen3: 1415817d8daa7fa72ec9b26a6b9d166a1d54626a to 7792b1e909a98703181aecb8810b4b654004c25d tflite: 31960ee82bce0fe1934b9265b8496c58fcd4559a to a1c67c43ea73a314debec81ed230feba2b830fd4 Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-compile-rel Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Cq-Include-Trybots: luci.chromium.try:android_arm64_dbg_recipe Cq-Include-Trybots: luci.chromium.try:android_compile_x64_dbg Cq-Include-Trybots: luci.chromium.try:android-pie-arm64-dbg Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng Change-Id: Ia8caaecd0fbeb5ea6095aa9f2b25acae37884142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194431 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/main@{#926471}
Bug: 1197335 Change-Id: I8fb639e80c31e99623f7aca97107db9b2eba80e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3189633 Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/main@{#926472}
The refill threshold must be <= the start threshold. Bug: internal b/200826398 Change-Id: I5a221c588cdd54fd0ba7227ddac413fd672fe0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195076 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Auto-Submit: Kenneth MacKay <kmackay@chromium.org> Reviewed-by: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/main@{#926473}
- Support dark/light mode for phantom window and update its UI to follow the new spec (Issue 1252205). - Observe theme changes in split view drag indicator label to refresh its color when switching D/L mode (Issue 1252914). Bug: 1252205, 1252914 Test: Manual Change-Id: I6867d6de8e38dfdf6ddbef7da8a4b334e0209701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183261 Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Reviewed-by: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/main@{#926474}
1. Special handling for VideoFrames in base_rendering_context_2d.cc It allows to avoid double scaling when frame has display size and resized by drawImage() 2. Caching canvas resource provider between frame render calls. 3. Accurate handling of color spaces in VideoImageGenerator. Bug: 1244034 Change-Id: I61f547d90cec0dfdccb609fd52ed8ad3d8f648f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3099249 Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/main@{#926475}
Bug: 1197335 Change-Id: I114ba550fa1d9207948c6752986a42eb3488f01d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3189084 Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/main@{#926476}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9ebd05a0..5066a7dd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3293fb72b791aac49fd477a29feda2188ddf0962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194653 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#926477}
This CL enables the core feature flag for segmentation platform by default. Bug: None Change-Id: I35482c7cdbbb5cdd8ab95b0dc16b09a24f58493d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193513 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/main@{#926478}
Before this CL, the UI displayed the avatar and email of the "default" account - the first one added at the OS level. In reality it should show the "primary" account - the one used by the send-tab-to-self feature. Bug: 1250255, 1246488 Change-Id: Ib22e0325b162022f65a1b431b0cc44c51cee0fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194273 Reviewed-by: Jérôme <jlebel@chromium.org> Reviewed-by: Kyle Milka <kmilka@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/main@{#926479}
This removes the feature kEvictRootSurfaceWhenHidden, and instead uses a feature param for kApplyNativeOcclusionToCompositor. Three variants are supported (as before, but now controlled via params): 1. Apply to compositor only. When the HWND is occluded the compositor is hidden. 2. Apply and evict. Same as 1, but in addition evicts the root surface when hidden. This immediately frees up more gpu resources. 3. Don't apply, but evict when hidden. BUG=1248235 TEST=none Change-Id: If312ffec3e9fb4078026a651fa24dc2eecc21cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194788 Reviewed-by: David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#926480}
This requires a new string. Fixed: 1252129 Change-Id: I9809401d2cbf5b10e44c87eaab7a8c8f536dc1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3190929 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/main@{#926481}
Allow downloading the workstation image from Fuchsia GCS bucket. Add support for starting up Fuchsia emulators with the workstation image. Bug: 1254074 Change-Id: I6eed72ad5e52836acd85cb8ad3f032f040f11a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192230 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/main@{#926482}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I3c293be361b4317b70303414de2bec173a031a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194674 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#926483}
https://chromium.googlesource.com/catapult.git/+log/70e04d1248f2..bb0ee9fd3d16 2021-09-29 wenbinzhang@google.com [Dashboard] Print the invalid value for debugging If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1254023 Tbr: nuskos@google.com Change-Id: I55178688eefe9284a1ee7647088f55e066897713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194931 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#926484}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ec28edef7933..ec36691f17a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tguilbert@google.com,tmartino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1253586 Tbr: tguilbert@google.com,tmartino@google.com Change-Id: I594ceb04d5cfb4689d4276d12945e4159672a571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194932 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#926485}
When kEnforceFeaturePermissions is enabled, feature permissions are granted with restrictions. By default, only certain permissions are granted to certain origins. Apps must explicitly list additional permissions and origins if needed. Merge-With: eureka-internal/656953 Bug:b/191718807 Test: see eureka-internal/656953 Change-Id: I009e75a9d60228b964f84bca709d8e7bbf046e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3169413 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Reviewed-by: Sean Topping <seantopping@chromium.org> Reviewed-by: Sergey Volk <servolk@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/main@{#926486}
This CL adds a new PRESUBMIT check for accessibility unit tests on Android. The accessibility unit test suite includes tests that check events generated by the accessibility code, and these automated scripts run on every platform. The Android version of these have been moved to the Java-side code to test a larger part of the code-base. Because of this we need to separately keep the Android files in-sync with the rest of the platforms. This presubmit check looks for newly added tests and gives a warning to developers to include the test on Android as well. AX-Relnotes: N/A Bug: N/A Change-Id: Ibb37b106a82a66079b9f6aeb55cffdb6b0b2e721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182810 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/main@{#926487}
This CL is a refactor. This CL continues to decouple the logic for 1-time migrations of pinned shelf items and generation of the list of pinned items for the shelf. This decoupling simplifies the existing logic. This CL removes several redundant conditionals. This CL adds tests. This CL adds the concept of "consistency migrations". Although migrations should theoretically only be performed once, it's possible that sync data can be cleared by the user, or otherwise end up in an inconsistent state. In these situations, it's important that ChromeShelfPrefs have a way to recover back to a consistent state. To avoid performing the calculations on every call of GetPinnedAppsFromSync(), which is the previous behavior, the class listens for both sync model changes and profile changes. Bug: 1250480 Change-Id: I2c7ffbf87a69ef61cdea1f1255e1e0448f4fdc09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192216 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#926488}
Adding ClientSideDetectionDocumentScanning field trial details to start experiment on Beta. This feature will enable the scanning of Office documents (e.g., pptx, docx, etc.) to detect the presence of macros. Bug: 1188201 Change-Id: Iecda9928bdf2c24ef46f67ac585585ab7b967b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182720 Commit-Queue: Olabode O. Anise II <anise@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/main@{#926489}
Bug: 1252899 Change-Id: I8da04e1c054a3e0503409d1d437ef304a84665b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182729 Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: sebsg <sebsg@chromium.org> Commit-Queue: Cheick Cisse <cheickcisse@google.com> Cr-Commit-Position: refs/heads/main@{#926490}
Previously downloads are silently blocked if they are blocked before the download starts (i.e. OnDownloadTargetDetermined). This is because the target file path is not populated, so the download UI is skipped in DownloadUIController[1]. The user is given no feedback that the download has failed. In this CL, show the UI with an empty file path when the download is blocked by local policies. Screenshot: http://screen/5KACBqWue3cfSot See go/download-restrictions-bugs. [1] http://shortn/_DvveaLLBGl Bug: 1239293 Change-Id: I9fdf1822adbd91cb0dab60f4ce3516cc3e904117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3189039 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/main@{#926491}
This CL introduces AssertNonSpeculativeFrame in an attempt to catch occurring-in-the-wild scenarios that end up unexpectedly and undesirably using speculative frames (triggering script execution and subresource loads in such frames). Bug: 1247598 Change-Id: I9ea4efe05f6166c1ca4dd495f6a64c344bec981f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3163445 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#926492}
This CL removes some local variables that are no longer relevant in the current implementation of FrameSequenceTracker::ReportFramePresented(). Change-Id: I406d2c8fe48c3ee0705444041bce4d0a68aea9ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194711 Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/main@{#926493}
PasswordStoreInterface is an interface that should be used by other classes instead of interacting directly with PasswordStore. Bug: 1218413 Change-Id: If8114d8cd360714f0648477a44904ee173d64df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194134 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Dana Fried <dfried@chromium.org> Auto-Submit: Maria Kazinova <kazinova@google.com> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/main@{#926494}
Disabling ARC is often associated removing ARC data (but not always). Previously, the code to disable ARC and remove ARC data is confusing to read. It first reads a boolean enable_requested to decide whether to remove ARC data after disabling. RequestDisableWithArcDataRemoval() allows to request the two things together (disable ARC and remove ARC data). If ARC is already disabled, then no-op (ARC data is not removed). The code is easier to read this way. Logic is not changed assuming there's no multi-threaded access to the class. BUG=b/196225929 TEST=CI; ARC enable/disable works fine on DUT Change-Id: Ieb28bba4db16fbeaa27bedce9455ea7a9a9bc4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3188851 Auto-Submit: Yao Li <yaohuali@google.com> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yao Li <yaohuali@google.com> Cr-Commit-Position: refs/heads/main@{#926495}
This allows us to easily convert the PipelineStatus returns & cbs to a specialized TypedStatus<PipelineStatus> value so that we can achieve our original goal of pushing this thru the media stack to recover more detailed failure state information, without having to continue to maintain and extend the already gigantic single error state enum. as per docs.google.com/document/d/12_mSpXFpJpo6jdD3a0XiH2HdaYoGaoWQLzyHUDhr8JM R=liberato,xhwang Change-Id: Icb6001925cf2b06cfe3aefd16f5fc3bdb817e616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3132055 Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/main@{#926496}
This is to fix an autoroller which needs a newer version of guava. Change-Id: Ibae00b842d77e28b1af88fc03782774f33a04ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3191330 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#926497}
These bots are building //ios/chrome, so they need to be on the same version of Xcode as the main Chromium iOS bots in order to meet our minimum Xcode requirements. Bug: webrtc:13221 Change-Id: I7d850d65794d758a4acc925c575164f84c2f740e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193175 Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/main@{#926710}
Previously stderr was linked to stdout by manipulating file descriptors in the sign_chrome.py driver script. However in Python 3, this no longer works, so have subcommands capture stderr by default. Since some subcommands log to stdout and others to stderr, both should be captured by default. Bug: 1241293 Change-Id: Id81a143aaafe524cdd86eef1ec61d3db1e9811f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192656 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/main@{#926711}
…its) https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/62d7d0c928c9..3e0b7c656db4 $ git log 62d7d0c92..3e0b7c656 --date=short --no-merges --format='%ad %ae %s' 2021-09-23 tuexen Cleanup stream scheduler, no functional change 2021-09-21 tuexen Simpify stream scheduling function usage. 2021-09-21 tuexen Add SCTP_TCB_SEND_OCK_ASSERT 2021-09-21 tuexen Simplify locking. 2021-09-20 tuexen Get the outstream while holding the stcb send lock 2021-09-19 tuexen fix FCFS stream scheduler Created with: roll-dep src/third_party/usrsctp/usrsctplib Bug: None Change-Id: Ic5bd3a31638dc8ab33b134a3b62fa59d3fa235c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193438 Reviewed-by: Florent Castelli <orphis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/main@{#926712}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5f098c6b..1c942231 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I29e022a27f8ed5f1558cfbb6c2a1148e23af58d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3196032 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#926713}
This needs further client and server implementation to pass. Bug: 1201569 Change-Id: I7122ff2df29c9971535b1c3339734f19aaaa5fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192738 Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/main@{#926714}
This needs further client and server implementation to pass. Bug: 1201569 Change-Id: Ibd45c710309c6551c1ff793b9b85a09890752ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193241 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Cr-Commit-Position: refs/heads/main@{#926715}
Adds a new (disabled by default) tracing category that, when enabled, will dump the whole Android view hierarchy to the trace once a second. These events will help us correlate high CPU usage issues with views that cause them. Bug: b/195305613 Change-Id: I3c3a7d5866b0aac6825ed853a0be4f69965fffbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168340 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/main@{#926716}
To make the UI more consistent and reinforce which protocol handler is the default this cl makes it so the set to default button goes from hidden to disabled on the default handler. Bug: 1240691 Change-Id: Ie986c8d6ca0ceb974cbe980ce2437de006abd4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168262 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/main@{#926717}
pull bot
pushed a commit
that referenced
this pull request
Oct 16, 2021
This reverts commit 842626c. Reason for revert: [sheriff] suspected to cause multiple failures in SafetyTipPageInfoBubbleViewBrowserTests on linux-ubsan-vptr: https://ci.chromium.org/p/chromium/builders/ci/linux-ubsan-vptr/6970 Sample failure: [ RUN ] All/SafetyTipPageInfoBubbleViewBrowserTest.BubbleWaitsForVisible/1 [...] ../../chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23: runtime error: downcast of address 0x180601885e00 which does not point to an object of type 'PageInfoBubbleView' 0x180601885e00: note: object is of type 'PageInfoNewBubbleView' 00 00 00 00 18 70 11 10 50 56 00 00 80 68 50 01 06 18 00 00 b8 00 00 00 30 00 00 00 00 00 00 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'PageInfoNewBubbleView' #0 0x564ffa77d440 in SafetyTipPageInfoBubbleViewBrowserTest::CheckPageInfoShowsSafetyTipInfo(Browser*, security_state::SafetyTipStatus, GURL const&) chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23 #1 0x564ffa788397 in SafetyTipPageInfoBubbleViewBrowserTest_BubbleWaitsForVisible_Test::RunTestOnMainThread() chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:837:3 #2 0x565002ae1026 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:868:7 #3 0x565001aae15a in Run base/callback.h:142:12 #4 0x565001aae15a in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1745:38 #5 0x565001aaba50 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1083:18 #6 0x564ffd8e2f00 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:957:28 #7 0x564ffe307f82 in Run base/callback.h:142:12 #8 0x564ffe307f82 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:41:29 #9 0x564ffd8e2368 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:865:25 #10 0x564ffd8e889c in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner_impl.cc:131:15 #11 0x564ffd8dec1e in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:45:32 #12 0x564fff2a06e8 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:641:10 #13 0x564fff2a2e90 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) content/app/content_main_runner_impl.cc:1137:10 #14 0x564fff2a1f18 in content::ContentMainRunnerImpl::Run(bool) content_main_runner_impl.cc #15 0x564fff29dde0 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) content_main.cc #16 0x564fff29e7dd in content::ContentMain(content::ContentMainParams const&) content_main.cc #17 0x565002adfcff in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:712:3 #18 0x5650018271c4 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:401:20 #19 0x564ffa79d759 in SafetyTipPageInfoBubbleViewBrowserTest::SetUp() chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:306:27 #20 0x564ffb8f8c7d in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2701:3 #21 0x564ffb8fa600 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2885:11 #22 0x564ffb8fc1bb in testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:3044:30 #23 0x564ffb9115ca in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5903:44 #24 0x564ffb90fd8c in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:5470:10 #25 0x565001a12e28 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46 #26 0x565001a12e28 in base::TestSuite::Run() base/test/test_suite.cc:445:16 #27 0x5650017d0bac in ChromeTestSuiteRunner::RunTestSuiteInternal(ChromeTestSuite*) chrome/test/base/chrome_test_launcher.cc:88:22 #28 0x5650017d0c1b in ChromeTestSuiteRunner::RunTestSuite(int, char**) chrome_test_launcher.cc #29 0x565002b8529b in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:409:31 #30 0x5650017d11b1 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:284:10 #31 0x5650017c9dcc in main chrome/test/base/browser_tests_main.cc:61:10 #32 0x7fc242b01bf6 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6) #33 0x564ff76da7e9 in _start (/b/s/w/ir/out/Release/browser_tests+0xe8af7e9) SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23 in Original change's description: > Enable PageInfoV2Desktop by default > > Enable flag and remove testing config. > > Bug: 1188101 > Change-Id: Ifd839436f3d4c0127d15b449bbca84855ccd858f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217207 > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> > Cr-Commit-Position: refs/heads/main@{#931972} Bug: 1188101 Change-Id: Ic51b9fdc730b7046e24b4d394248218b86eef09d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226638 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Owners-Override: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#932067}
pull bot
pushed a commit
that referenced
this pull request
Nov 8, 2021
This CL changes the aura::WindowObserver hook used in
exo::ExtendedDragSource:
Previously, ExtendedDragSource::OnWindowVisibilityChanging() was
used to call ash::ToplevelWindowEventHandler::AttemptToStartDrag(),
and kick off the drag 'n drop.
Problem is that for the scenario of TabletMode ON and WebUITabStrip
OFF, using OnWindowVisibilityChanging() hook is too early.
Reason:
In today's ToT, when a window detaches, during a tab drag 'n drop,
the following check takes place and fails, causing the whole
operation to abort (see lines 309-310 below):
295 std::unique_ptr<WindowResizer> CreateWindowResizerForTabletMode(
296 aura::Window* window, ...) {
(...)
306 WindowState* window_state = WindowState::Get(window);
307 // Only maximized/fullscreen/snapped window can be dragged from
308 // the top of the screen.
309 if (!window_state->IsMaximized() && !window_state->IsFullscreen()
310 && !window_state->IsSnapped()) {
311 return nullptr;
This happens because the |window_state| in case is only set to
MAXIMIZED from a code that uses OnWindowVisibilityChanged() hook:
(...)
#12 0x7fe849164dda TabletModeWindowManager::OnWindowVisibilityChanged()
(...)
#15 0x7fe8520d2be3 aura::Window::NotifyWindowVisibilityChanged()
#16 0x7fe8520cdf2c aura::Window::SetVisibleInternal()
#17 0x7fe8520cdc54 aura::Window::Show()
#18 0x7fe84cfcf013 views::NativeWidgetAura::Show()
#19 0x7fe84cf89398 views::Widget::Show()
#20 0x561eee1cb154 exo::ShellSurfaceBase::CommitWidget()
#21 0x561eee1cacf6 exo::ShellSurfaceBase::OnSurfaceCommit()
Hence, using OnDraggedWindowVisibilityChanging() in
exo::ExtendedDragSource class is too early.
This CL changes the hook used to OnWindowVisibilityChanged(),
and also sets the following aura::Window properties, used by the
drag 'n drop logic: ash::kTabDraggingSourceWindowKey and
ash::kIsDraggingTabsKey.
With this change, the functionality starts to take shape, and it is
possible to drag the window around. Snapping and merge-back are still
not fully functional (see follow up CLs).
R=oshima@chromium.org
BUG=1252941
Change-Id: I8600652a974210e3081e97d6d65639582ad222ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254858
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/main@{#939226}
pull bot
pushed a commit
that referenced
this pull request
Jan 4, 2022
It turns out that exo::ExtendedDragSource class can benefit from overriding both OnWindowVisibilityChanging() and OnWindowVisibilityChanged() hooks. In [1], the use of OnWindowVisibilityChanging() hook was changed by OnWindowVisibilityChanged(), since according to the existing Ash's drag'n drop logic, by the time ash::ToplevelWindowEventHandler::AttemptToStartDrag() is called the window state should be up to date, something that occurs in ash::TabletModeWindowManager::OnWindowVisibilityChanged(). However, it turns how that Lacros needs to set ash::kIsDraggingTabsKey property as soon as possible, so that undesirable window resizes don't take place during the drag'n drop beginning - causing the window to flicker. This CL reintroduces OnWindowVisibilityChanging() hook, and moves some of the logic in OnWindowVisibilityChanged() into it, In practice, it avoids Lacros from flicking when starting a drag'n drop (see stack trace below) [1] https://crrev.com/c/3254858 #9 0x7f8f4dda154a ash::TabletModeWindowState::UpdateBounds() <-- calls aura::Window::SetBounds() #10 0x7f8f4dda0e0e ash::TabletModeWindowState::UpdateWindow() #11 0x7f8f4dda16ef ash::TabletModeWindowState::AttachState() #12 0x7f8f4ddcd304 ash::WindowState::SetStateObject() #13 0x7f8f4dda03b1 ash::TabletModeWindowState::TabletModeWindowState() #14 0x7f8f4dd98830 ash::TabletModeWindowManager::TrackWindow() #15 0x7f8f4dd995a7 ash::TabletModeWindowManager::OnWindowVisibilityChanged() #16 0x7f8f4ff664fc aura::Window::NotifyWindowVisibilityChangedAtReceiver() #17 0x7f8f4ff661c6 aura::Window::NotifyWindowVisibilityChangedDown() #18 0x7f8f4ff652d7 aura::Window::NotifyWindowVisibilityChanged() #19 0x7f8f4ff6002a aura::Window::SetVisibleInternal() #20 0x7f8f4ff5fcaa aura::Window::Show() #21 0x7f8f4f371b3b views::NativeWidgetAura::Show() #22 0x7f8f4f3260b8 views::Widget::Show() #23 0x55d01acb6fd6 exo::ShellSurfaceBase::CommitWidget() #24 0x55d01acb6b78 exo::ShellSurfaceBase::OnSurfaceCommit() #25 0x55d01ac7d90d exo::Surface::Commit() (..) BUG=1252941 R=oshima@chromium.org Change-Id: Ib6ba73d3bb2a90a3ac180c974f292bec39c1b3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3365554 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/main@{#955327}
pull bot
pushed a commit
that referenced
this pull request
Jan 14, 2022
This reverts commit 6ff1599. Reason for revert: Seems to have caused browser_test failures on linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/19698 rowserTestBase received signal: Segmentation fault. Backtrace: #0 0x563ae696f899 base::debug::CollectStackTrace() #1 0x563ae68d6683 base::debug::StackTrace::StackTrace() #2 0x563ae6ff8293 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f9ac9026040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x563ae7720266 PrefChangeRegistrar::RemoveAll() #5 0x563ae7720222 PrefChangeRegistrar::~PrefChangeRegistrar() #6 0x563ae2f37095 std::__1::unique_ptr<>::reset() #7 0x563ae3696a1b policy::ActiveDirectoryMigrationManager::~ActiveDirectoryMigrationManager() #8 0x563ae3696a38 policy::ActiveDirectoryMigrationManager::~ActiveDirectoryMigrationManager() #9 0x563ae369a699 policy::BrowserPolicyConnectorAsh::~BrowserPolicyConnectorAsh() #10 0x563ae369a6fe policy::BrowserPolicyConnectorAsh::~BrowserPolicyConnectorAsh() #11 0x563ae6a0edbd BrowserProcessImpl::~BrowserProcessImpl() #12 0x563ae6a0edea BrowserProcessImpl::~BrowserProcessImpl() #13 0x563ae6a668e9 browser_shutdown::ShutdownPostThreadsStop() #14 0x563ae6a0e226 ChromeBrowserMainParts::PostDestroyThreads() #15 0x563ae349ef9b ash::ChromeBrowserMainPartsAsh::PostDestroyThreads() #16 0x563ae495d2d9 content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #17 0x563ae495e53c content::BrowserMainRunnerImpl::Shutdown() #18 0x563ae495a9ce content::BrowserMain() #19 0x563ae555e819 content::RunBrowserProcessMain() #20 0x563ae555f8e0 content::ContentMainRunnerImpl::RunBrowser() #21 0x563ae555f431 content::ContentMainRunnerImpl::Run() #22 0x563ae555d209 content::RunContentProcess() #23 0x563ae555d861 content::ContentMain() #24 0x563ae6ff6f2b content::BrowserTestBase::SetUp() #25 0x563ae68bf947 InProcessBrowserTest::SetUp() #26 0x563ae3b0fbed testing::Test::Run() #27 0x563ae3b10520 testing::TestInfo::Run() #28 0x563ae3b10ce1 testing::TestSuite::Run() #29 0x563ae3b1a61a testing::internal::UnitTestImpl::RunAllTests() #30 0x563ae3b1a219 testing::UnitTest::Run() #31 0x563ae69d5af8 base::TestSuite::Run() #32 0x563ae688bfa1 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #33 0x563ae70407b7 content::LaunchTests() #34 0x563ae688e77a LaunchChromeTests() #35 0x563ae688bf23 main #36 0x7f9ac9008bf7 __libc_start_main #37 0x563ae134462a _start Original change's description: > Remote powerwash on Chromad via policy > > Implement remote powerwash on Chromad, using the recently added > ChromadToCloudMigrationEnabled policy. The powerwash will be used to > start the migration of AD managed devices into cloud management. Besides > having the new policy enabled, the device needs to be on the login > screen and the enrollment ID must have already been uploaded to > DMServer. > > Bug: 1209246 > Change-Id: I6a67b8a8a43c28bc5f03f27e96d0415f69b6bc83 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3141873 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Roman Sorokin <rsorokin@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Felipe Andrade <fsandrade@chromium.org> > Cr-Commit-Position: refs/heads/main@{#959123} Bug: 1209246 Change-Id: If067abcf2a9289ebacaeb240b1f67749c305509c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3389555 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#959243}
pull bot
pushed a commit
that referenced
this pull request
Jan 19, 2022
This reverts commit 65b9357. Reason for revert: Made linux-chromeos-rel very unhappy First failure: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-rel/54339/overview Example stack trace: BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x5602878b1df9 base::debug::CollectStackTrace() #1 0x560287814a63 base::debug::StackTrace::StackTrace() #2 0x560287f236f9 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f5dca479040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x56028382eb06 std::__1::__tree<>::__erase_unique<>() #5 0x5602849cda7e crosapi::BrowserManager::StopKeepAlive() #6 0x5602877e163f std::__1::unique_ptr<>::reset() #7 0x5602877e0fa2 crosapi::test::AshBrowserTestStarter::~AshBrowserTestStarter() #8 0x5602877ff1b3 std::__1::unique_ptr<>::reset() #9 0x560287f22469 content::BrowserTestBase::SetUp() #10 0x5602877fd219 InProcessBrowserTest::SetUp() #11 0x560284bb448d testing::Test::Run() #12 0x560284bb4e28 testing::TestInfo::Run() #13 0x560284bb55e3 testing::TestSuite::Run() #14 0x560284bbecd5 testing::internal::UnitTestImpl::RunAllTests() #15 0x560284bbe8e7 testing::UnitTest::Run() #16 0x560287919f5a base::TestSuite::Run() #17 0x5602877c996f BrowserTestSuiteRunnerChromeOS::RunTestSuite() #18 0x560287f6ba53 content::LaunchTests() #19 0x5602877cc08e LaunchChromeTests() #20 0x5602877c98f1 main #21 0x7f5dca45bbf7 __libc_start_main #22 0x56028236e7ea _start Original change's description: > Make Lacros lifetime closer to real use. > > We started to enable Lacros's KeepAlive for AppService. > Following that, now AshBrowserTestStarter uses it to make it > closer to the real use cases. > > To avoid name conflict, put AshBrowserTestStarter to crosapi::test > namespace. > > BUG=1277898 > TEST=Ran browser_tests. > > Change-Id: I007e2cf5dc75cf581b3fdca595c18b2a9fbc8c5c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3386527 > Reviewed-by: Sven Zheng <svenzheng@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Cr-Commit-Position: refs/heads/main@{#960880} Bug: 1277898 Change-Id: I5d1b9053bb82d0a5593f8ffaf5a70ff66cd72618 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3401559 Auto-Submit: Leonard Grey <lgrey@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/main@{#960983}
pull bot
pushed a commit
that referenced
this pull request
Mar 12, 2022
During the tab attaching process, XDGSurfaceWrapperImpl::Configure() can be called and result in a WaylandToplevelWindow::Hide() calls, which actually deletes itself (see pseudo stacktrace below). > #2 0x7f369324c07e ui::WaylandToplevelWindow::Hide() > #3 0x7f36936bfbfa views::DesktopWindowTreeHostPlatform::HideImpl() > #4 0x7f3694691720 aura::WindowTreeHost::Hide() > #5 0x7f36936be274 views::DesktopWindowTreeHostPlatform::Close() > #6 0x7f3693690bcf views::Widget::CloseWithReason() > #7 0x55ab161b4382 Browser::TabStripEmpty() > #8 0x55ab1620e6d0 TabStripModel::SendDetachWebContentsNotifications() > (...) > #21 0x7f369324ef38 ui::WaylandWindow::SetBounds() > #22 0x7f369325141c ui::WaylandWindow::ApplyPendingBounds() > #23 0x7f369324bd47 ui::WaylandToplevelWindow::ApplyPendingBounds() > #24 0x7f3693250f20 ui::WaylandWindow::ProcessPendingBoundsDip() > #25 0x7f369324c932 ui::WaylandToplevelWindow::HandleSurfaceConfigure() > #26 0x7f369325c263 ui::XDGSurfaceWrapperImpl::OnConfigure() > #27 0x7f369325c110 ui::XDGSurfaceWrapperImpl::Configure() > #28 0x7f36932739c5 ffi_call_unix64 To protect against such scenarios, which can hard crash both Lacros and Ash, this CL guards XDGSurfaceWrapperImpl with the WeakPtrFactory pattern, particularly within the context of XDGSurfaceWrapperImpl::OnConfigure(). BUG=1303425 R=nickdiego@igalia.com Change-Id: Ic84b3d5cf2ac11b30a82090f49c99a991e4dd243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3519638 Reviewed-by: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/main@{#980254}
pull bot
pushed a commit
that referenced
this pull request
May 30, 2022
This makes kBackForwardCacheMediaSessionPlaybackStateChange=true in the code. This has been rolling out in stable and all indicators are good (see links in #20 and #21 on the bug). Fixed: 1243599 Change-Id: Ia989f1a1c97a11843cb6037181e3ec4eba1e9fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3661865 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1008747}
pull bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
ash::Shell::Get() will CHECK-fail if Shell has been deleted. Use ash::Shell::HasInstance() instead. This avoids the following shutdown CHECK failure: 2022-07-13T17:10:21.129726Z FATAL chrome[174352:174352]: [shell.cc(292)] Check failed: instance_. #0 0x7f22df90bd12 base::debug::CollectStackTrace() #1 0x7f22df800ac3 base::debug::StackTrace::StackTrace() #2 0x7f22df81f1dd logging::LogMessage::~LogMessage() #3 0x7f22df81fc1e logging::LogMessage::~LogMessage() #4 0x7f22d9d5e3e7 ash::Shell::Get() #5 0x563bad18bf43 KeyboardBacklightColorMetricsProvider::ProvideCurrentSessionData() #6 0x563badc31d04 metrics::DelegatingProvider::ProvideCurrentSessionData() #7 0x563badc3762d metrics::MetricsLog::RecordCurrentSessionData() #8 0x563badc3a156 metrics::MetricsService::CloseCurrentLog() #9 0x563badc38e3b metrics::MetricsService::DisableRecording() #10 0x563bad72cf35 ChromeBrowserMainParts::PostMainMessageLoopRun() #11 0x563bacd9e251 ash::ChromeBrowserMainPartsAsh::PostMainMessageLoopRun() #12 0x7f22d8267f7f content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #13 0x7f22d826998c content::BrowserMainRunnerImpl::Shutdown() #14 0x7f22d826563d content::BrowserMain() #15 0x7f22d8b656d6 content::RunBrowserProcessMain() #16 0x7f22d8b66a7e content::ContentMainRunnerImpl::RunBrowser() #17 0x7f22d8b66601 content::ContentMainRunnerImpl::Run() #18 0x7f22d8b645f8 content::RunContentProcess() #19 0x7f22d8b646b9 content::ContentMain() #20 0x563babe99ca0 ChromeMain #21 0x7f22cbf9f7fd __libc_start_main #22 0x563babe99ada _start Bug: none Change-Id: If65c0f90a37c09c405340d675a15e2c9ca9685b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3759374 Commit-Queue: Jason Thai <jasontt@chromium.org> Reviewed-by: Jason Thai <jasontt@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#1023829}
pull bot
pushed a commit
that referenced
this pull request
Aug 6, 2022
This reverts commit 0ae1202. Reason for revert: causes consistent failures on MSAN bots example links: (two different bots) https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/29604/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/34158/overview All the failures I checked involve use-of-uninitialized-value example failure: HeadlessScriptControllerImplTest.StartFailsIfNoScriptsAvailable https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/29604/overview [ RUN ] HeadlessScriptControllerImplTest.StartFailsIfNoScriptsAvailable GMOCK WARNING: Uninteresting mock function call - returning default value. Function call: RegisterSyntheticFieldTrial({ 'A' (65, 0x41), 'u' (117, 0x75), 't' (116, 0x74), 'o' (111, 0x6F), 'f' (102, 0x66), 'i' (105, 0x69), 'l' (108, 0x6C), 'l' (108, 0x6C), 'A' (65, 0x41), 's' (115, 0x73), 's' (115, 0x73), 'i' (105, 0x69), 's' (115, 0x73), 't' (116, 0x74), 'a' (97, 0x61), 'n' (110, 0x6E), 't' (116, 0x74), 'T' (84, 0x54), 'r' (114, 0x72), 'i' (105, 0x69), 'g' (103, 0x67), 'g' (103, 0x67), 'e' (101, 0x65), 'r' (114, 0x72), 'e' (101, 0x65), 'd' (100, 0x64) }, { 'E' (69, 0x45), 'n' (110, 0x6E), 'a' (97, 0x61), 'b' (98, 0x62), 'l' (108, 0x6C), 'e' (101, 0x65), 'd' (100, 0x64) }) Returns: false NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/master/docs/gmock_cook_book.md#knowing-when-to-expect for details. ==20593==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5573fb8250a1 in autofill_assistant::StartupUtil::ChooseStartupModeForIntent(autofill_assistant::TriggerContext const&, autofill_assistant::StartupUtil::Options const&) const ./../../components/autofill_assistant/browser/startup_util.cc:32:7 #1 0x5573fb809994 in autofill_assistant::Starter::Start(std::Cr::unique_ptr<autofill_assistant::TriggerContext, std::Cr::default_delete<autofill_assistant::TriggerContext>>) ./../../components/autofill_assistant/browser/starter.cc:491:44 #2 0x5573fb759f6b in autofill_assistant::HeadlessScriptControllerImpl::StartScript(base::flat_map<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::less<void>, std::Cr::vector<std::Cr::pair<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>>, std::Cr::allocator<std::Cr::pair<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>>>>> const&, base::OnceCallback<void (autofill_assistant::HeadlessScriptController::ScriptResult)>, bool, base::OnceCallback<void ()>, std::Cr::unique_ptr<autofill_assistant::Service, std::Cr::default_delete<autofill_assistant::Service>>, std::Cr::unique_ptr<autofill_assistant::WebController, std::Cr::default_delete<autofill_assistant::WebController>>) ./../../components/autofill_assistant/browser/headless/headless_script_controller_impl.cc:72:13 #3 0x5573d0c23167 in autofill_assistant::HeadlessScriptControllerImplTest::Start(base::flat_map<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::less<void>, std::Cr::vector<std::Cr::pair<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>>, std::Cr::allocator<std::Cr::pair<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>>>>> const&, bool) ./../../components/autofill_assistant/browser/headless/headless_script_controller_impl_unittest.cc:146:34 #4 0x5573d0c23aba in autofill_assistant::HeadlessScriptControllerImplTest_StartFailsIfNoScriptsAvailable_Test::TestBody() ./../../components/autofill_assistant/browser/headless/headless_script_controller_impl_unittest.cc:221:3 #5 0x5573d52eff32 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #6 0x5573d52eff32 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2670:5 #7 0x5573d52f2946 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2849:11 #8 0x5573d52f4f30 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3008:30 #9 0x5573d5323424 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5866:44 #10 0x5573d5322223 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #11 0x5573d5322223 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5440:10 #12 0x5573e551d8ae in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2284:73 #13 0x5573e551d8ae in base::TestSuite::Run() ./../../base/test/test_suite.cc:457:16 #14 0x5573f855e403 in content::UnitTestTestSuite::Run() ./../../content/public/test/unittest_test_suite.cc:187:23 #15 0x5573e284380d in Invoke<int (content::UnitTestTestSuite::*)(), std::Cr::unique_ptr<content::UnitTestTestSuite, std::Cr::default_delete<content::UnitTestTestSuite> > > ./../../base/bind_internal.h:608:12 #16 0x5573e284380d in MakeItSo<int (content::UnitTestTestSuite::*)(), std::Cr::unique_ptr<content::UnitTestTestSuite, std::Cr::default_delete<content::UnitTestTestSuite> > > ./../../base/bind_internal.h:777:12 #17 0x5573e284380d in RunImpl<int (content::UnitTestTestSuite::*)(), std::Cr::tuple<std::Cr::unique_ptr<content::UnitTestTestSuite, std::Cr::default_delete<content::UnitTestTestSuite> > >, 0UL> ./../../base/bind_internal.h:850:12 #18 0x5573e284380d in base::internal::Invoker<base::internal::BindState<int (content::UnitTestTestSuite::*)(), std::Cr::unique_ptr<content::UnitTestTestSuite, std::Cr::default_delete<content::UnitTestTestSuite>>>, int ()>::RunOnce(base::internal::BindStateBase*) ./../../base/bind_internal.h:819:12 #19 0x5573e55292c9 in Run ./../../base/callback.h:145:12 #20 0x5573e55292c9 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:187:38 #21 0x5573e5528d68 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:278:10 #22 0x5573ceb75f47 in main ./../../components/test/run_all_unittests.cc:8:10 #23 0x7f31ca69783f in __libc_start_main ??:0:0 #24 0x5573c5ca7029 in _start ??:0:0 Uninitialized value was stored to memory at #0 0x5573fb827d81 in autofill_assistant::TriggerContext::TriggerContext(std::Cr::unique_ptr<autofill_assistant::ScriptParameters, std::Cr::default_delete<autofill_assistant::ScriptParameters>>, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>> const&, bool, bool, bool, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>> const&, bool, bool, bool) ./../../components/autofill_assistant/browser/trigger_context.cc:59:7 #1 0x5573fb759c20 in make_unique<autofill_assistant::TriggerContext, std::Cr::unique_ptr<autofill_assistant::ScriptParameters, std::Cr::default_delete<autofill_assistant::ScriptParameters> >, const char (&)[1], bool, bool, bool, const char (&)[1], bool, bool, bool> ./../../buildtools/third_party/libc++/trunk/include/__memory/unique_ptr.h:714:32 #2 0x5573fb759c20 in autofill_assistant::HeadlessScriptControllerImpl::StartScript(base::flat_map<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::less<void>, std::Cr::vector<std::Cr::pair<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>>, std::Cr::allocator<std::Cr::pair<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>>>>> const&, base::OnceCallback<void (autofill_assistant::HeadlessScriptController::ScriptResult)>, bool, base::OnceCallback<void ()>, std::Cr::unique_ptr<autofill_assistant::Service, std::Cr::default_delete<autofill_assistant::Service>>, std::Cr::unique_ptr<autofill_assistant::WebController, std::Cr::default_delete<autofill_assistant::WebController>>) ./../../components/autofill_assistant/browser/headless/headless_script_controller_impl.cc:61:26 #3 0x5573d0c23167 in autofill_assistant::HeadlessScriptControllerImplTest::Start(base::flat_map<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::less<void>, std::Cr::vector<std::Cr::pair<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>>, std::Cr::allocator<std::Cr::pair<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>>>>>> const&, bool) ./../../components/autofill_assistant/browser/headless/headless_script_controller_impl_unittest.cc:146:34 #4 0x5573d0c23aba in autofill_assistant::HeadlessScriptControllerImplTest_StartFailsIfNoScriptsAvailable_Test::TestBody() ./../../components/autofill_assistant/browser/headless/headless_script_controller_impl_unittest.cc:221:3 #5 0x5573d52eff32 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #6 0x5573d52eff32 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2670:5 #7 0x5573d52f2946 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2849:11 #8 0x5573d52f4f30 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3008:30 #9 0x5573d5323424 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5866:44 #10 0x5573d5322223 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #11 0x5573d5322223 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5440:10 #12 0x5573e551d8ae in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2284:73 #13 0x5573e551d8ae in base::TestSuite::Run() ./../../base/test/test_suite.cc:457:16 #14 0x5573f855e403 in content::UnitTestTestSuite::Run() ./../../content/public/test/unittest_test_suite.cc:187:23 #15 0x5573e284380d in Invoke<int (content::UnitTestTestSuite::*)(), std::Cr::unique_ptr<content::UnitTestTestSuite, std::Cr::default_delete<content::UnitTestTestSuite> > > ./../../base/bind_internal.h:608:12 #16 0x5573e284380d in MakeItSo<int (content::UnitTestTestSuite::*)(), std::Cr::unique_ptr<content::UnitTestTestSuite, std::Cr::default_delete<content::UnitTestTestSuite> > > ./../../base/bind_internal.h:777:12 #17 0x5573e284380d in RunImpl<int (content::UnitTestTestSuite::*)(), std::Cr::tuple<std::Cr::unique_ptr<content::UnitTestTestSuite, std::Cr::default_delete<content::UnitTestTestSuite> > >, 0UL> ./../../base/bind_internal.h:850:12 #18 0x5573e284380d in base::internal::Invoker<base::internal::BindState<int (content::UnitTestTestSuite::*)(), std::Cr::unique_ptr<content::UnitTestTestSuite, std::Cr::default_delete<content::UnitTestTestSuite>>>, int ()>::RunOnce(base::internal::BindStateBase*) ./../../base/bind_internal.h:819:12 #19 0x5573e55292c9 in Run ./../../base/callback.h:145:12 #20 0x5573e55292c9 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:187:38 #21 0x5573e5528d68 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:278:10 #22 0x5573ceb75f47 in main ./../../components/test/run_all_unittests.cc:8:10 #23 0x7f31ca69783f in __libc_start_main ??:0:0 Uninitialized value was created by a heap allocation #0 0x5573c5d23eb9 in operator new(unsigned long) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cpp:45:35 #1 0x5573d0c34199 in testing::internal::TestFactoryImpl<autofill_assistant::HeadlessScriptControllerImplTest_StartFailsIfNoScriptsAvailable_Test>::CreateTest() headless_script_controller_impl_unittest.cc:0:0 #2 0x5573d52f28d4 in HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test *> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #3 0x5573d52f28d4 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2839:22 #4 0x5573d52f4f30 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3008:30 #5 0x5573d5323424 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5866:44 #6 0x5573d5322223 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 #7 0x5573d5322223 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5440:10 #8 0x5573e551d8ae in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2284:73 #9 0x5573e551d8ae in base::TestSuite::Run() ./../../base/test/test_suite.cc:457:16 #10 0x5573f855e403 in content::UnitTestTestSuite::Run() ./../../content/public/test/unittest_test_suite.cc:187:23 #11 0x5573e284380d in Invoke<int (content::UnitTestTestSuite::*)(), std::Cr::unique_ptr<content::UnitTestTestSuite, std::Cr::default_delete<content::UnitTestTestSuite> > > ./../../base/bind_internal.h:608:12 #12 0x5573e284380d in MakeItSo<int (content::UnitTestTestSuite::*)(), std::Cr::unique_ptr<content::UnitTestTestSuite, std::Cr::default_delete<content::UnitTestTestSuite> > > ./../../base/bind_internal.h:777:12 #13 0x5573e284380d in RunImpl<int (content::UnitTestTestSuite::*)(), std::Cr::tuple<std::Cr::unique_ptr<content::UnitTestTestSuite, std::Cr::default_delete<content::UnitTestTestSuite> > >, 0UL> ./../../base/bind_internal.h:850:12 #14 0x5573e284380d in base::internal::Invoker<base::internal::BindState<int (content::UnitTestTestSuite::*)(), std::Cr::unique_ptr<content::UnitTestTestSuite, std::Cr::default_delete<content::UnitTestTestSuite>>>, int ()>::RunOnce(base::internal::BindStateBase*) ./../../base/bind_internal.h:819:12 #15 0x5573e55292c9 in Run ./../../base/callback.h:145:12 #16 0x5573e55292c9 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:187:38 #17 0x5573e5528d68 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:278:10 #18 0x5573ceb75f47 in main ./../../components/test/run_all_unittests.cc:8:10 #19 0x7f31ca69783f in __libc_start_main ??:0:0 SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/components_unittests+0x3acb00a1) (BuildId: d348568ed374c786) Exiting Original change's description: > Add tests for headless flows > > This CL refactors the headless script controller and client to allow for the necessary injections to be able to test a full headless flow. This CL also includes a couple of basic tests. More coverage will follow. > > > Bug: b/201964911 > Change-Id: I8fc67dbbd064e4b65da7e8a4dcd52c946dc3ca75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3807499 > Reviewed-by: Clemens Arbesser <arbesser@google.com> > Commit-Queue: Luca Hunkeler <hluca@google.com> > Cr-Commit-Position: refs/heads/main@{#1031959} Bug: b/201964911 Change-Id: Ia5123a7369277f1dad3f952f843f13da85fceedb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3813793 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Mark Pearson <mpearson@chromium.org> Owners-Override: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/main@{#1032115}
pull bot
pushed a commit
that referenced
this pull request
Aug 31, 2022
This reverts commit 395b2b1. Reason for revert: the following test cases fail - MediaFoundationRendererIntegrationTest.BasicPlayback - MediaFoundationRendererIntegrationTest.BasicPlayback_MediaSource on Windows 10/Asan with the failure log: [ RUN ] MediaFoundationRendererIntegrationTest.BasicPlayback ================================================================= ==644==ERROR: AddressSanitizer: access-violation on unknown address 0x000000000008 (pc 0x7ff6889a1e92 bp 0x00c26c4fe5f0 sp 0x00c26c4fe560 T0) ==644==The signal is caused by a READ memory access. ==644==Hint: address points to the zero page. ==644==*** WARNING: Failed to initialize DbgHelp! *** ==644==*** Most likely this means that the app is already *** ==644==*** using DbgHelp, possibly with incompatible flags. *** ==644==*** Due to technical reasons, symbolization might crash *** ==644==*** or produce wrong results. *** #0 0x7ff6889a1e91 in base::RepeatingCallback<void (const base::UnguessableToken &, const gfx::Size &, base::TimeDelta)>::Run C:\b\s\w\ir\cache\builder\src\base\callback.h:263 #1 0x7ff6889a1e91 in media::MediaFoundationRenderer::RequestNextFrame(void) C:\b\s\w\ir\cache\builder\src\media\renderers\win\media_foundation_renderer.cc:1022:23 #2 0x7ff68899bed8 in media::MediaFoundationRenderer::OnPlaying(void) C:\b\s\w\ir\cache\builder\src\media\renderers\win\media_foundation_renderer.cc:838:3 #3 0x7ff68a04bb3a in base::OnceCallback<void ()>::Run C:\b\s\w\ir\cache\builder\src\base\callback.h:145 #4 0x7ff68a04bb3a in base::TaskAnnotator::RunTaskImpl(struct base::PendingTask &) C:\b\s\w\ir\cache\builder\src\base\task\common\task_annotator.cc:133:32 #5 0x7ff68ac91059 in base::TaskAnnotator::RunTask C:\b\s\w\ir\cache\builder\src\base\task\common\task_annotator.h:72 #6 0x7ff68ac91059 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(class base::LazyNow *) C:\b\s\w\ir\cache\builder\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:422:21 #7 0x7ff68ac90046 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork(void) C:\b\s\w\ir\cache\builder\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:292:41 #8 0x7ff68acc53da in base::MessagePumpDefault::Run(class base::MessagePump::Delegate *) C:\b\s\w\ir\cache\builder\src\base\message_loop\message_pump_default.cc:39:55 #9 0x7ff68ac9316b in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, class base::TimeDelta) C:\b\s\w\ir\cache\builder\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:575:12 #10 0x7ff68960a00c in base::RunLoop::Run(class base::Location const &) C:\b\s\w\ir\cache\builder\src\base\run_loop.cc:141:14 #11 0x7ff68942c9a7 in media::PipelineIntegrationTestBase::RunUntilQuitOrError(class base::RunLoop *) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:697:13 #12 0x7ff689424636 in media::PipelineIntegrationTestBase::RunUntilQuitOrEndedOrError(class base::RunLoop *) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:709:3 #13 0x7ff689424449 in media::PipelineIntegrationTestBase::WaitUntilEndedOrError(void) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:226:5 #14 0x7ff689423ac4 in media::PipelineIntegrationTestBase::WaitUntilOnEnded(void) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:217:27 #15 0x7ff686ce4597 in media::MediaFoundationRendererIntegrationTest_BasicPlayback_Test::TestBody(void) C:\b\s\w\ir\cache\builder\src\media\renderers\win\media_foundation_renderer_integration_test.cc:92:3 #16 0x7ff6870b0c77 in testing::Test::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2670:5 #17 0x7ff6870b2c3b in testing::TestInfo::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2849:11 #18 0x7ff6870b498e in testing::TestSuite::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:3008:30 #19 0x7ff6870d772f in testing::internal::UnitTestImpl::RunAllTests(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:5866:44 #20 0x7ff6870d6bd5 in testing::UnitTest::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:5440:10 #21 0x7ff6896d7a69 in RUN_ALL_TESTS C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\include\gtest\gtest.h:2284 #22 0x7ff6896d7a69 in base::TestSuite::Run(void) C:\b\s\w\ir\cache\builder\src\base\test\test_suite.cc:463:16 #23 0x7ff6896dc4ed in base::OnceCallback<int ()>::Run C:\b\s\w\ir\cache\builder\src\base\callback.h:145 #24 0x7ff6896dc4ed in base::`anonymous namespace'::LaunchUnitTestsInternal C:\b\s\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:181:38 #25 0x7ff6896dc0ba in base::LaunchUnitTests(int, char **, class base::OnceCallback<(void)>, unsigned __int64) C:\b\s\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:272:10 #26 0x7ff686dcc7f9 in main C:\b\s\w\ir\cache\builder\src\media\test\run_all_unittests.cc:52:10 #27 0x7ff68c67712b in invoke_main d:\a01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:78 #28 0x7ff68c67712b in __scrt_common_main_seh d:\a01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 #29 0x7fff384a2773 (C:\Windows\System32\KERNEL32.DLL+0x180012773) #30 0x7fff386e0d50 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: access-violation C:\b\s\w\ir\cache\builder\src\base\callback.h:263 in base::RepeatingCallback<void (const base::UnguessableToken &, const gfx::Size &, base::TimeDelta)>::Run ==644==ABORTING Original change's description: > [MediaFoundation] Request next frame during onPlaying event > > OS: Win10, Win11 > > During OnPlaying event, a frame request should be called to get > the first frame to output at the earliest possible time. This > is the earliest time when a frame is available. Current > implementation waits for render to be called, while > StartPlayingFrom's call for RequestNextFrameBetweenTimestamps > may not output a result if the media engine is not yet ready > to output a frame. > > Bug: 1355520 > Change-Id: Ice60ac41ca4b8cae9b0687626e93017d0a4406f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852409 > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Commit-Queue: Daoyuan Li <daoyuanli@microsoft.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1041097} Bug: 1355520 Change-Id: Ic483e314ce14e3f187691df772515eacea387cb1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3863075 Commit-Queue: Asami Doi <asamidoi@chromium.org> Owners-Override: Asami Doi <asamidoi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1041256}
pull bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
During an ongoing tab dragging on Lacros, with both WebUITabStrip and TabletMode features ON, Lacros crashes in case the dragged `exo::ShellSurface` (ie browser window) is deleted by JavaScript. What happens is that during a tab drag 'n drop, exo::TabDragDropDelegate store an `aura::Window` instance, and operates over it throughout its life cycle. However, during the drag operation, it is possible that this `aura::Window` instance gets deleted, and the pointer becomes dangling. Here is the pseudo stacktrace of the dragged `aura::Window` instance (and its respective exo::ShellSurface) being destroyed: #4 ~Window () at ../../ui/aura/window.cc:201 #5 aura::Window::~Window() () at ../../ui/aura/window.cc:186 #6 CloseNow () at ../../ui/views/widget/widget.cc:787 #7 ~ShellSurfaceBase () at ../../components/exo/shell_surface_base.cc:347 #8 ~ShellSurface () at ../../components/exo/shell_surface.cc:140 #9 ~XdgShellSurface () at ../../components/exo/xdg_shell_surface.cc:27 #10 ~XdgShellSurface () at ../../components/exo/xdg_shell_surface.cc:27 #11 operator() () at (...) #12 reset () at (...) #13 ~unique_ptr () at (...) #14 ~WaylandXdgSurface () at ../../components/exo/wayland/xdg_shell.cc:783 #15 operator() () at (...) #16 reset () at (...) #17 ~unique_ptr () at (...) #18 DestroyUserData<exo::wayland::WaylandXdgSurface> () at ../../components/exo/wayland/server_util.h:40 #19 0x0000556095b8ae10 in destroy_resource () at ../../third_party/wayland/src/src/wayland-server.c:733 #20 0x0000556095b8acb0 in wl_resource_destroy () at ../../third_party/wayland/src/src/wayland-server.c:750 #21 0x00005560a6dc1d65 in ffi_call_unix64 () #22 0x00005560a6dc12b9 in ffi_call_int () ... and here is the stack trace of the crash, where this `aura::Window` is dereferenced: #0 is_destroying ui/aura/window.h:166:39 #1 ash::TabDragDropDelegate::~TabDragDropDelegate() ash/drag_drop/tab_drag_drop_delegate.cc:117:23 #2 ash::TabDragDropDelegate::~TabDragDropDelegate() ash/drag_drop/tab_drag_drop_delegate.cc:114:45 #3 operator() (...) #4 reset (...) #5 ash::DragDropController::Cleanup() ash/drag_drop/drag_drop_controller.cc:800:27 #6 ash::DragDropController::DoDragCancel(base::TimeDelta) ash/drag_drop/drag_drop_controller.cc:702:3 #7 exo::DragDropOperation::~DragDropOperation() components/exo/drag_drop_operation.cc:277:28 #8 exo::DragDropOperation::~DragDropOperation() components/exo/drag_drop_operation.cc:270:41 #9 exo::Surface::~Surface() components/exo/surface.cc:286:14 #10 operator() (...) #11 reset (...) #12 ~unique_ptr (...) This CL protects `exo::TabDragDropDelegate` dtor against this crash by making use of `aura::WindowObserver` logic and null-checking `TabDragDropDelegate::source_window_`. Last, this CL also extends exo::ExoTestBase class with an additional SetUp() method, that takes a TestShellDelegate as parameter. BUG=1348791 Change-Id: Ic00886fda66d4150ce07d74d6aaccf31e77bc80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4174397 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/main@{#1094249}
pull bot
pushed a commit
that referenced
this pull request
Feb 18, 2023
This reverts commit c262371. Reason for revert: The changes in this CL trigger a DCHECK when running Chrome. See below for callstack and the command I used to build Chrome. Callstack: 2023-02-17T20:24:19.978808Z FATAL chrome[1213141:1213233]: [feature_list.cc(671)] Check failed: CheckFeatureIdentity(feature). GaiaCredentialsModeOmitBug_775438_Workaround #0 0x7f7c3d2a77f2 base::debug::CollectStackTrace() #1 0x7f7c3d289e03 base::debug::StackTrace::StackTrace() #2 0x7f7c3d1654f0 logging::LogMessage::~LogMessage() #3 0x7f7c3d165fce logging::LogMessage::~LogMessage() #4 0x7f7c3d154849 base::FeatureList::GetOverrideState() #5 0x7f7c3d15337d base::FeatureList::IsEnabled() #6 0x7f7c34ed2797 google_apis::GetOmitCredentialsModeForGaiaRequests() #7 0x7f7c34ec0e69 gcm::RegistrationRequest::Start() #8 0x562a357cded1 gcm::GCMClientImpl::Register() #9 0x562a357d5f23 gcm::GCMDriverDesktop::IOWorker::Register() #10 0x7f7c3d1daf5a base::TaskAnnotator::RunTaskImpl() #11 0x7f7c3d2051f8 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #12 0x7f7c3d204633 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #13 0x7f7c3d205d15 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #14 0x7f7c3d2b34e3 base::MessagePumpEpoll::Run() #15 0x7f7c3d206232 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #16 0x7f7c3d1ab82a base::RunLoop::Run() #17 0x7f7c3d239687 base::Thread::Run() #18 0x7f7c36876359 content::BrowserProcessIOThread::IOThreadRun() #19 0x7f7c368762ec content::BrowserProcessIOThread::Run() #20 0x7f7c3d2399eb base::Thread::ThreadMain() #21 0x7f7c3d25810b base::(anonymous namespace)::ThreadFunc() #22 0x7f7c29aa7fd4 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x88fd3) #23 0x7f7c29b2866c (/usr/lib/x86_64-linux-gnu/libc.so.6+0x10966b) The specific command I used to build Chrome: ``` cd ~/chromium/src; autoninja -C \${out_dir} \ chrome && \${out_dir}/chrome \ --user-data-dir=~/.config/cros \ --use-system-clipboard \ --ash-host-window-bounds="40+40-1920x1080" \ --enable-logging=stderr \ --enable-features=ShimlessRMAFlow,OsFeedback,ShortcutCustomizationApp,ShortcutCustomization,EnableInputInDiagnosticsApp,SearchInShortcutsApp ``` Original change's description: > Use uncredentialed requests to Gaia > > Adopting kOmitBug_775438_Workaround makes the browser spec-compliant and > avoids that developers need to use workarounds such as > --ignore-urlfetcher-cert-requests in order to communicate with non-prod > server environments. > > The change is guarded with a kill switch but is otherwise enabled by > default. > > Below a summary extracted from devidben@'s nice explanation of what this > patch does (readers may find the full Gerrit comment thread > interesting): > > The concrete behavior change is around client certs. Client certs work as follows: > > 1. Either the origin server (depends on what URL you're connecting to) > or the proxy server (depends on the user's network config) can, in a TLS > connection request client certs. > > 2. If we already have a client cert decision recorded for that server, we just use it. > > 3. Otherwise, we show a prompt to the user. > > 4. If the request isn't associated with some tab, we have no place to > show the prompt and we just abort the request. (We cannot continue > without a certificate because that'll persist the "send no certificate" > decision in the net stack... this auth mechanism is somewhat unavoidably > sticky.) > > This CL will change the behavior for just origin-requested client certs (not proxy-requested) to, instead of steps (2-4), unconditionally continue the request with no client certificate. > > Change-Id: I34908fa81c1688ebaf7feb801408d9080207453c > Fixed: 1221565 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4255589 > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1106846} Change-Id: Ib67b7801b007b8bf56a3f65fb0677b94c4719ab9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4265133 Owners-Override: David Baron <dbaron@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1106998}
pull bot
pushed a commit
that referenced
this pull request
Feb 25, 2023
…ew." This reverts commit 508aa18. Reason for revert: Causes IbanBubbleViewFullFormBrowserTest.Local_ClickingHideOrShowIbanValueManageView failurees. from https://ci.chromium.org/ui/p/chromium/builders/ci/linux-ubsan-vptr/21221/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2Fchrome%2Ftest%3Ainteractive_ui_tests%2FIbanBubbleViewFullFormBrowserTest.Local_ClickingHideOrShowIbanValueManageView+VHash%3Ad2ca29b55d68a4ff: ../../chrome/browser/ui/views/autofill/payments/iban_bubble_view_uitest.cc:282:12: runtime error: downcast of address 0x0798015a1b00 which does not point to an object of type 'SaveIbanBubbleView' 0x0798015a1b00: note: object is of type 'autofill::ManageSavedIbanBubbleView' 29 00 00 00 38 f3 68 e6 e4 55 00 00 78 f3 68 e6 e4 55 00 00 c0 ce 6c 01 98 07 00 00 80 18 0b 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'autofill::ManageSavedIbanBubbleView' #0 0x55e4d02f0701 in autofill::IbanBubbleViewFullFormBrowserTest::GetSaveIbanBubbleView() chrome/browser/ui/views/autofill/payments/iban_bubble_view_uitest.cc:282:12 #1 0x55e4d02fb74f in autofill::IbanBubbleViewFullFormBrowserTest::ClickOnDialogView(views::View*) chrome/browser/ui/views/autofill/payments/iban_bubble_view_uitest.cc:345:5 #2 0x55e4d02f6e6e in autofill::IbanBubbleViewFullFormBrowserTest_Local_ClickingHideOrShowIbanValueManageView_Test::RunTestOnMainThread() chrome/browser/ui/views/autofill/payments/iban_bubble_view_uitest.cc:623:3 #3 0x55e4d99bf48e in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:895:7 #4 0x55e4d4a7be0d in Run base/functional/callback.h:152:12 #5 0x55e4d4a7be0d in content::BrowserMainLoop::InterceptMainMessageLoopRun() content/browser/browser_main_loop.cc:1038:36 #6 0x55e4d4a7bf1e in content::BrowserMainLoop::RunMainMessageLoop() content/browser/browser_main_loop.cc:1050:7 #7 0x55e4d4a811f9 in content::BrowserMainRunnerImpl::Run() content/browser/browser_main_runner_impl.cc:158:15 #8 0x55e4d4a75a6d in content::BrowserMain(content::MainFunctionParams) content/browser/browser_main.cc:32:28 #9 0x55e4d6fe2fbe in content::RunBrowserProcessMain(content::MainFunctionParams, content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:716:10 #10 0x55e4d6fe5438 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams, bool) content/app/content_main_runner_impl.cc:1276:10 #11 0x55e4d6fe4f4d in content::ContentMainRunnerImpl::Run() content/app/content_main_runner_impl.cc:1130:12 #12 0x55e4d6fe02ab in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) content/app/content_main.cc:324:36 #13 0x55e4d6fe0935 in content::ContentMain(content::ContentMainParams) content/app/content_main.cc:341:10 #14 0x55e4d99be269 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:575:3 #15 0x55e4d7cec8e0 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:484:20 #16 0x55e4d0875e53 in SyncTest::SetUp() chrome/browser/sync/test/integration/sync_test.cc:300:24 #17 0x55e4d0e00c17 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2665:3 #18 0x55e4d0e0265e in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2849:11 #19 0x55e4d0e042fb in testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:3008:30 #20 0x55e4d0e1a210 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5866:44 #21 0x55e4d0e18dc8 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:5440:10 #22 0x55e4daaaa4a0 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2284:73 #23 0x55e4daaaa4a0 in base::TestSuite::Run() base/test/test_suite.cc:454:16 #24 0x55e4d7cb6b48 in ChromeTestSuiteRunner::RunTestSuiteInternal(ChromeTestSuite*) chrome/test/base/chrome_test_launcher.cc:95:22 #25 0x55e4d03f6416 in InteractiveUITestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/interactive_ui_tests_main.cc:134:12 #26 0x55e4d99fb844 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:415:31 #27 0x55e4d7cb722e in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:318:10 #28 0x55e4d03f63a1 in main chrome/test/base/interactive_ui_tests_main.cc:176:10 #29 0x7fbe2824bc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86) (BuildId: f7307432a8b162377e77a182b6cc2e53d771ec4b) #30 0x55e4cff4a029 in _start (/b/s/w/ir/out/Release/interactive_ui_tests+0xc8b2029) (BuildId: b65d070fe6c272ab) also: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20CFI/24652/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2Fchrome%2Ftest%3Ainteractive_ui_tests%2FIbanBubbleViewFullFormBrowserTest.Local_ClickingHideOrShowIbanValueManageView+VHash%3A18b587341aed5390 Original change's description: > [IBAN local save] Add eye icon to manage saved IBAN bubble view. > > This CL introduce Eye Icon to manage saved IBAN bubble view, which can > reveal full IBAN value or show masked IBAN on clicking. > > Screenshot: > https://screenshot.googleplex.com/3rtMkB6f6UhSL47 > > Mock: > https://screenshot.googleplex.com/FkAmHC4aPtzt44d > > Bug: 1349109 > Change-Id: I51afa60384ff1065785e8351f355eaa66c76fdd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4237378 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Qihui Zhao <qihuizhao@google.com> > Reviewed-by: Vinny Persky <vinnypersky@google.com> > Cr-Commit-Position: refs/heads/main@{#1109451} Bug: 1349109 Change-Id: I473c317aaf5d70e538e6ced970ecc4294491d069 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4291366 Commit-Queue: Brian Begnoche <bcb@chromium.org> Owners-Override: Brian Begnoche <bcb@chromium.org> Auto-Submit: Brian Begnoche <bcb@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1109581}
pull bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
This reverts commit 135cdf4. Reason for revert: Reverted on suspiscion of breaking tests: https://chromium-review.googlesource.com/c/chromium/src/+/4404274 error AssistantManagerServiceImplTest.ShouldNotCrashRunningAfterStopped history | source | ID: ninja://chromeos:chromeos_unittests/AssistantManagerServiceImplTest.ShouldNotCrashRunningAfterStopped | builder Linux Chromium OS ASan LSan Tests (1) test_suite chromeos_unittests os Ubuntu-18.04 expand_more 30s run #1 unexpectedly failed in task: 616d82542ed81511 expand_more Failure Reason (similar failures): expect_utils.h(49): Failed RunLoop::Run() timed out. Timeout set at TaskEnvironment@base/test/task_environment.cc:415. {"active_queues":[{"any_thread_.immediate_incoming_queuecapacity":14,"any_thread_.immediate_incoming_queuesize":0,"delay_to_next_task_ms":0.591,"delayed_incoming_queue":[{"delayed_run_time":2274764.284,"delayed_run_time_milliseconds_from_now":0.723,"is_cancelled":false,"is_high_res":false,"nestable":true,"posted_from":"CheckResult@chromeos/ash/components/assistant/test_support/expect_utils.h:30","sequence_num":5858}],"delayed_incoming_queue_size":1,"delayed_work_queue":[],"delayed_work_queue_capacity":4,"delayed_work_queue_size":0,"enabled":true,"immediate_incoming_queue":[],"immediate_work_queue":[],"immediate_work_queue_capacity":14,"immediate_work_queue_size":0,"name":"TASK_ENVIRONMENT_DEFAULT_TQ","priority":0,"task_queue_id":"0x616000007880"}],"non_waking_wake_up_queue":{"name":"NonWakingWakeUpQueue","registered_delay_count":0},"queues_to_delete":[],"queues_to_gracefully_shutdown":[],"... expand_more Summary: [ RUN ] AssistantManagerServiceImplTest.ShouldNotCrashRunningAfterStopped chromeos/ash/components/assistant/test_support/expect_utils.h:49: Failure Failed RunLoop::Run() timed out. Timeout set at TaskEnvironment@base/test/task_environment.cc:415. {"active_queues":[{"any_thread_.immediate_incoming_queuecapacity":14,"any_thread_.immediate_incoming_queuesize":0,"delay_to_next_task_ms":0.591,"delayed_incoming_queue":[{"delayed_run_time":2274764.284,"delayed_run_time_milliseconds_from_now":0.723,"is_cancelled":false,"is_high_res":false,"nestable":true,"posted_from":"CheckResult@chromeos/ash/components/assistant/test_support/expect_utils.h:30","sequence_num":5858}],"delayed_incoming_queue_size":1,"delayed_work_queue":[],"delayed_work_queue_capacity":4,"delayed_work_queue_size":0,"enabled":true,"immediate_incoming_queue":[],"immediate_work_queue":[],"immediate_work_queue_capacity":14,"immediate_work_queue_size":0,"name":"TASK_ENVIRONMENT_DEFAULT_TQ","priority":0,"task_queue_id":"0x616000007880"}],"non_waking_wake_up_queue":{"name":"NonWakingWakeUpQueue","registered_delay_count":0},"queues_to_delete":[],"queues_to_gracefully_shutdown":[],"selector":{"immediate_starvation_count":0},"time_domain":{},"wake_up_queue":{"name":"DefaultWakeUpQueue","next_delay_ms":0.723,"registered_delay_count":1}} Stack trace: #0 0x558c875ee996 in operator() ./../../base/test/scoped_run_loop_timeout.cc:54:11 #1 0x558c875ee996 in Invoke<const (lambda at ../../base/test/scoped_run_loop_timeout.cc:51:9) &, const base::Location &, const base::RepeatingCallback<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char> > ()> &, const base::Location &> ./../../base/functional/bind_internal.h:621:12 #2 0x558c875ee996 in MakeItSo<const (lambda at ../../base/test/scoped_run_loop_timeout.cc:51:9) &, const std::Cr::tuple<base::Location, base::RepeatingCallback<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char> > ()> > &, const base::Location &> ./../../base/functional/bind_internal.h:925:12 #3 0x558c875ee996 in RunImpl<const (lambda at ../../base/test/scoped_run_loop_timeout.cc:51:9) &, const std::Cr::tuple<base::Location, base::RepeatingCallback<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char> > ()> > &, 0UL, 1UL> ./../../base/functional/bind_internal.h:1025:12 #4 0x558c875ee996 in base::internal::Invoker<base::internal::BindState<base::test::ScopedRunLoopTimeout::ScopedRunLoopTimeout(base::Location const&, base::TimeDelta, base::RepeatingCallback<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>> ()>)::$_0, base::Location, base::RepeatingCallback<std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>> ()>>, void (base::Location const&)>::Run(base::internal::BindStateBase*, base::Location const&) ./../../base/functional/bind_internal.h:989:12 #5 0x558c872b3da0 in Run ./../../base/functional/callback.h:152:12 #6 0x558c872b3da0 in base::(anonymous namespace)::OnRunLoopTimeout(base::RunLoop*, base::Location const&, base::OnceCallback<void (base::Location const&)>) ./../../base/run_loop.cc:41:25 #7 0x558c872b8fbd in Invoke<void (*)(base::RunLoop *, const base::Location &, base::OnceCallback<void (const base::Location &)>), base::RunLoop *, base::Location, base::RepeatingCallback<void (const base::Location &)> > ./../../base/functional/bind_internal.h:636:12 #8 0x558c872b8fbd in MakeItSo<void (*)(base::RunLoop *, const base::Location &, base::OnceCallback<void (const base::Location &)>), std::Cr::tuple<base::internal::UnretainedWrapper<base::RunLoop, base::unretained_traits::MayNotDangle, (base::RawPtrTraits)0>, base::Location, base::RepeatingCallback<void (const base::Location &)> > > ./../../base/functional/bind_internal.h:925:12 #9 0x558c872b8fbd in RunImpl<void (*)(base::RunLoop *, const base::Location &, base::OnceCallback<void (const base::Location &)>), std::Cr::tuple<base::internal::UnretainedWrapper<base::RunLoop, base::unretained_traits::MayNotDangle, (base::RawPtrTraits)0>, base::Location, base::RepeatingCallback<void (const base::Location &)> >, 0UL, 1UL, 2UL> ./../../base/functional/bind_internal.h:1025:12 #10 0x558c872b8fbd in base::internal::Invoker<base::internal::BindState<void (*)(base::RunLoop*, base::Location const&, base::OnceCallback<void (base::Location const&)>), base::internal::UnretainedWrapper<base::RunLoop, base::unretained_traits::MayNotDangle, (base::RawPtrTraits)0>, base::Location, base::RepeatingCallback<void (base::Location const&)>>, void ()>::RunOnce(base::internal::BindStateBase*) ./../../base/functional/bind_internal.h:976:12 #11 0x558c75bd34b0 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:152:12 #12 0x558c87326547 in Run ./../../base/functional/callback.h:152:12 #13 0x558c87326547 in base::TaskAnnotator::RunTaskImpl(base::PendingTask&) ./../../base/task/common/task_annotator.cc:178:34 #14 0x558c873b4fd9 in RunTask<(lambda at ../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:488:11)> ./../../base/task/common/task_annotator.h:89:5 #15 0x558c873b4fd9 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:486:23 #16 0x558c873b2f33 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:351:41 #17 0x558c873b6df5 in non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:0:0 #18 0x558c87223124 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_default.cc:40:55 #19 0x558c873b7e7b in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:651:12 #20 0x558c872b2938 in base::RunLoop::Run(base::Location const&) ./../../base/run_loop.cc:134:14 #21 0x558c8615e752 in void ash::assistant::test::ExpectResult<ash::assistant::AssistantManagerService::State>(ash::assistant::AssistantManagerService::State, base::RepeatingCallback<ash::assistant::AssistantManagerService::State ()>, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>> const&) ./../../chromeos/ash/components/assistant/test_support/expect_utils.h:49:3 #22 0x558c8614cebe in ash::assistant::(anonymous namespace)::AssistantManagerServiceImplTest::WaitForState(ash::assistant::AssistantManagerService::State) ./../../chromeos/ash/services/assistant/assistant_manager_service_impl_unittest.cc:233:5 #23 0x558c8615d3b9 in ash::assistant::AssistantManagerServiceImplTest_ShouldNotCrashRunningAfterStopped_Test::TestBody() ./../../chromeos/ash/services/assistant/assistant_manager_service_impl_unittest.cc:771:3 ../../chromeos/ash/components/assistant/test_support/expect_utils.h:49: Failure Expected: run_loop.Run() doesn't generate new fatal failures in the current thread. Actual: it does. AssistantManagerStateImpl: Failed waiting for expected result. Expected "3" Got "0" Stack trace: #0 0x558c8615eb1f in void ash::assistant::test::ExpectResult<ash::assistant::AssistantManagerService::State>(ash::assistant::AssistantManagerService::State, base::RepeatingCallback<ash::assistant::AssistantManagerService::State ()>, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char>> const&) ./../../chromeos/ash/components/assistant/test_support/expect_utils.h:49:3 #1 0x558c8614cebe in ash::assistant::(anonymous namespace)::AssistantManagerServiceImplTest::WaitForState(ash::assistant::AssistantManagerService::State) ./../../chromeos/ash/services/assistant/assistant_manager_service_impl_unittest.cc:233:5 #2 0x558c8615d3b9 in ash::assistant::AssistantManagerServiceImplTest_ShouldNotCrashRunningAfterStopped_Test::TestBody() ./../../chromeos/ash/services/assistant/assistant_manager_service_impl_unittest.cc:771:3 [ FAILED ] AssistantManagerServiceImplTest.ShouldNotCrashRunningAfterStopped (30026 ms) Original change's description: > assistant: Prevent timing issue in media_host > > In some situations, the libassistant_media_controller_ inside > media_host_ could be nullptr. In these cases, we need to avoid to call > methods on the nullptr. > > Bug: b:277107422 > Test: added new unittest > Change-Id: If13bd4c887f4641f0cfb8380f3fe604fe288b145 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4404274 > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1126976} Bug: b:277107422 Change-Id: I63c5d52d25c7522e263ba8765da6e0028a4616cf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4405589 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Peter Williamson <petewil@chromium.org> Auto-Submit: Peter Williamson <petewil@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/main@{#1127244}
pull bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
This reverts commit 3438f2a. Reason for revert: Suspect causing blink_wpt_tests and blink_web_tests failure on Linux Tests (dbg)(1) bot. Failed tests: blink_wpt_tests failed because of: external/wpt/css/css-contain/content-visibility/detach-locked-slot-children-crash.html external/wpt/css/css-contain/content-visibility/element-reassigned-to-skipped-slot.html external/wpt/css/css-contain/content-visibility/element-reassigned-to-slot-in-skipped-subtree.html external/wpt/html/semantics/forms/the-input-element/focus-dynamic-type-change-on-blur.html ...7 more failure(s) (11 total)... blink_web_tests failed because of: accessibility/details-summary-crash.html fast/events/drag-on-removed-slider-does-not-crash.html fast/forms/range/range-type-change-onchange-2.html html/details_summary/details-add-summary.html ...5 more failure(s) (9 total)... First build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/114032/overview Sample log: --- STDERR: #6 0x7fc01bd0361d logging::CheckError::~CheckError() STDERR: #7 0x7fbffd21d08a blink::FlatTreeTraversal::AssertPrecondition() STDERR: #8 0x7fbffd21cfd5 blink::FlatTreeTraversal::Parent() STDERR: #9 0x7fbffd3c2a45 blink::FlatTreeTraversal::AncestorsOf() STDERR: #10 0x7fbffd3d410e blink::(anonymous namespace)::NearestLockedExclusiveAncestor() STDERR: #11 0x7fbffd3d3d17 blink::DisplayLockUtilities::IsInUnlockedOrActivatableSubtree() STDERR: #12 0x7fbfedfabc4b blink::DisplayLockUtilities::ShouldIgnoreNodeDueToDisplayLock() STDERR: #13 0x7fbfedf8b61c blink::AXObject::ToString() STDERR: #14 0x7fbfedf8eccc blink::AXObject::Detach() STDERR: #15 0x7fbfedf512df blink::AXNodeObject::Detach() STDERR: #16 0x7fbfedf2d6a5 blink::AXLayoutObject::Detach() STDERR: #17 0x7fbfedfce51a blink::AXObjectCacheImpl::Remove() STDERR: #18 0x7fbfedfcd998 blink::AXObjectCacheImpl::Remove() STDERR: #19 0x7fbfedfcdd74 blink::AXObjectCacheImpl::Remove() STDERR: #20 0x7fbfedfce992 blink::AXObjectCacheImpl::Remove() STDERR: #21 0x7fbffe6d16be blink::LayoutObject::WillBeDestroyed() --- Original change's description: > [A11y] Reland targeted cached property invalidation > > Relands the following CLS: > * Enhance performance by targeting value updates to specific nodes, commit 704633e. > * Don't queue anything for irrelevant attribute changes, commit 2c66a62. > * Add comment explaining call to UpdateStyleAndLayoutTreeForNode(), commit 73b9eed. > * Ensure cached values not invalidated during the computation of them, commit 4d167a6. > * Run a test with --force-renderer-accessibility that used to fail, commit cab7ecd. > * Simplify code to update cached focusable state, commit 79cb184. > * Simplify code that invalidates cached values on an AXObject, commit 6df79a5. > > Fixed: 1446864, 1446550, 1434555, 1362758 > Change-Id: I16855bdcb746cb41387b69e1e97ab72ffc47e342 > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4545510 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Jacques Newman <janewman@microsoft.com> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1157878} Change-Id: Iefe59fe1933747346eda8827fd683f310d6cddb3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615927 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Owners-Override: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takashi Sakamoto <tasak@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1157993}
pull bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
…ation
At least on Linux X11, views::test::TestDesktopScreenOzone::Create() may
try to retrieve a localized string for "Built-in display" after [1].
But screen creation happens early for interactive UI tests since [2], at
least before ChromeFeatureListCreator::ConvertFlagsToSwitches() which
assumes ui::ResourceBundle is not initialized. This is causing the crash
below for all interactive UI tests on Linux X11, which this CL fixes by
temporarily initializing ui::ResourceBundle during screen creation.
See crbug.com/1457129 for details.
[24841:24841:FATAL:resource_bundle.cc(357)] Check failed: g_shared_instance_ != nullptr.
#0 0x5585747ceee2 base::debug::CollectStackTrace()
#1 0x5585747b6213 base::debug::StackTrace::StackTrace()
#2 0x5585746ab79d logging::LogMessage::~LogMessage()
#3 0x5585746ac2ee logging::LogMessage::~LogMessage()
#4 0x558574692437 logging::CheckError::~CheckError()
#5 0x558574bd6075 ui::ResourceBundle::GetSharedInstance()
#6 0x558574bc0a18 l10n_util::GetStringUTF8()
#7 0x5585758fddc1 ui::BuildDisplaysFromXRandRInfo()
#8 0x5585758fb539 ui::XDisplayManager::FetchDisplayList()
#9 0x5585758fb449 ui::XDisplayManager::Init()
#10 0x55856dd0e34c ui::X11ScreenOzone::Init()
#11 0x55856d09ed3d views::test::TestDesktopScreenOzone::Create()
#12 0x558572c7ec70 InProcessBrowserTest::SetScreenInstance()
#13 0x558572c7e44f InProcessBrowserTest::SetUp()
#14 0x55856d24c5f2 testing::Test::Run()
#15 0x55856d24d865 testing::TestInfo::Run()
#16 0x55856d24e337 testing::TestSuite::Run()
#17 0x55856d25cf07 testing::internal::UnitTestImpl::RunAllTests()
#18 0x55856d25c9ff testing::UnitTest::Run()
#19 0x5585746730ec base::TestSuite::Run()
#20 0x558572c5eddb ChromeTestSuiteRunner::RunTestSuiteInternal()
#21 0x55856cc79be4 InteractiveUITestSuiteRunner::RunTestSuite()
#22 0x558572c5f069 ChromeTestLauncherDelegate::RunTestSuite()
#23 0x558573d7b9ab content::LaunchTestsInternal()
#24 0x558572c5f325 LaunchChromeTests()
Bug: 1457129
[1] crrev.com/1010705
[2] crrev.com/1011300
Change-Id: I173b41d4369fa26332a37b0f89e14669b6b227a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4632804
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1191366}
pull bot
pushed a commit
that referenced
this pull request
Sep 2, 2023
…reen creation" This reverts commit 5931e82. Reason for revert: Suspect causing multiple test failed on Linux Tests (dbg)(1) first failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/115562/overview Original change's description: > interactive_ui_tests: use temporary ui::ResourceBundle for screen creation > > At least on Linux X11, views::test::TestDesktopScreenOzone::Create() may > try to retrieve a localized string for "Built-in display" after [1]. > But screen creation happens early for interactive UI tests since [2], at > least before ChromeFeatureListCreator::ConvertFlagsToSwitches() which > assumes ui::ResourceBundle is not initialized. This is causing the crash > below for all interactive UI tests on Linux X11, which this CL fixes by > temporarily initializing ui::ResourceBundle during screen creation. > See crbug.com/1457129 for details. > > [24841:24841:FATAL:resource_bundle.cc(357)] Check failed: g_shared_instance_ != nullptr. > #0 0x5585747ceee2 base::debug::CollectStackTrace() > #1 0x5585747b6213 base::debug::StackTrace::StackTrace() > #2 0x5585746ab79d logging::LogMessage::~LogMessage() > #3 0x5585746ac2ee logging::LogMessage::~LogMessage() > #4 0x558574692437 logging::CheckError::~CheckError() > #5 0x558574bd6075 ui::ResourceBundle::GetSharedInstance() > #6 0x558574bc0a18 l10n_util::GetStringUTF8() > #7 0x5585758fddc1 ui::BuildDisplaysFromXRandRInfo() > #8 0x5585758fb539 ui::XDisplayManager::FetchDisplayList() > #9 0x5585758fb449 ui::XDisplayManager::Init() > #10 0x55856dd0e34c ui::X11ScreenOzone::Init() > #11 0x55856d09ed3d views::test::TestDesktopScreenOzone::Create() > #12 0x558572c7ec70 InProcessBrowserTest::SetScreenInstance() > #13 0x558572c7e44f InProcessBrowserTest::SetUp() > #14 0x55856d24c5f2 testing::Test::Run() > #15 0x55856d24d865 testing::TestInfo::Run() > #16 0x55856d24e337 testing::TestSuite::Run() > #17 0x55856d25cf07 testing::internal::UnitTestImpl::RunAllTests() > #18 0x55856d25c9ff testing::UnitTest::Run() > #19 0x5585746730ec base::TestSuite::Run() > #20 0x558572c5eddb ChromeTestSuiteRunner::RunTestSuiteInternal() > #21 0x55856cc79be4 InteractiveUITestSuiteRunner::RunTestSuite() > #22 0x558572c5f069 ChromeTestLauncherDelegate::RunTestSuite() > #23 0x558573d7b9ab content::LaunchTestsInternal() > #24 0x558572c5f325 LaunchChromeTests() > > Bug: 1457129 > > [1] crrev.com/1010705 > [2] crrev.com/1011300 > > Change-Id: I173b41d4369fa26332a37b0f89e14669b6b227a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4632804 > Commit-Queue: Frédéric Wang <fwang@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1191366} Bug: 1457129, 1478318 Change-Id: Ib5adf3d8d8fb0b80789b6351f90cade2d6a6b682 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4833241 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Peter Williamson <petewil@chromium.org> Owners-Override: Owen Min <zmin@chromium.org> Auto-Submit: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1191537}
pull bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
When the kAppServiceStorage flag is enabled, AppService blocks the app publishers creating until it's ready, after reading from the AppStorage file. This affects some tests, e.g. DeviceAPIServiceRegularUserTest.*, because no data path for the profile: Received signal 11 SEGV_MAPERR 000000000017 ... #9 0x7fb1f37f6ec7 base::FilePath::Append() #10 0x7fb20a6396ec ash::BrowserContextHelper::GetBrowserContextPathByUserIdHash() #11 0x55d607da3a0c ash::ProfileHelperImpl::GetUserByProfile() #12 0x55d607da32f7 ash::ProfileHelper::IsPrimaryProfile() #13 0x55d616260503 NearbySharingServiceFactory::IsNearbyShareSupportedForBrowserContext() #14 0x55d6156cd0fc NotificationDisplayServiceImpl::NotificationDisplayServiceImpl() #15 0x55d6156ccc49 std::__Cr::make_unique<>() ... BrowserContextKeyedServiceFactory::GetServiceForBrowserContext() #20 0x55d6156ccab2 NotificationDisplayServiceFactory::GetForProfile() #21 0x55d605d350be apps::ExtensionAppsChromeOs::Initialize() #22 0x55d605d8041b apps::PublisherHost::Initialize() #23 0x55d605d8026c apps::PublisherHost::PublisherHost() Actually TestingProfile can create FakeChromeUserManager[1]. So we can get FakeChromeUserManager directly. Remove `scoped_user_manager_`, as that has been moved to TestProfile. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5076443/20/chrome/test/base/testing_profile.cc BUG=1385932, b:307623506 Change-Id: Ib26c7fc9fcfa950e01246df6e13a8f3ee449b22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5134109 Reviewed-by: Ben Franz <bfranz@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1239047}
pull bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
When the kAppServiceStorage flag is enabled, AppService blocks the app publishers creating until it's ready, after reading from the AppStorage file. This affects some tests, e.g. NetworkConfigurationUpdaterAshTest.*. Those tests crash because no data path for the profile: Received signal 11 SEGV_MAPERR 000000000017 ... #9 0x7fb71a1fe827 base::FilePath::Append() #10 0x7fb72e112a6c ash::BrowserContextHelper::GetBrowserContextPathByUserIdHash() #11 0x556a750dbf21 ash::ProfileHelperImpl::GetUserByProfile() #12 0x556a750db807 ash::ProfileHelper::IsPrimaryProfile() #13 0x556a834e83a3 NearbySharingServiceFactory::IsNearbyShareSupportedForBrowserContext() #14 0x556a8295719c NotificationDisplayServiceImpl::NotificationDisplayServiceImpl() #15 0x556a82956ce9 std::__Cr::make_unique<>() ... #19 0x7fb6fcef560c BrowserContextKeyedServiceFactory::GetServiceForBrowserContext() #20 0x556a82956b52 NotificationDisplayServiceFactory::GetForProfile() #21 0x556a7305f5be apps::ExtensionAppsChromeOs::Initialize() #22 0x556a730aa83b apps::PublisherHost::Initialize() #23 0x556a730aa68c apps::PublisherHost::PublisherHost() The reason should because of FakeUserManager. Actually the fake user manager is created in TestingProfile, so we don't need to build a new one, and we can get the user manager directly with: user_manager::UserManager::Get() Modify the test setup process to get the user manager directly, and remove `user_manager_` in the test code, as that has been moved to TestProfile. BUG=1385932, b:307623506 Change-Id: I5873858d5e18ca6196bc5b83ed38d87e1f18ae14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5188272 Reviewed-by: Anqing Zhao <anqing@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1248444}
pull bot
pushed a commit
that referenced
this pull request
May 21, 2024
Attempting to initialize the GPU triggers MSan failures in GL with eager
checks enabled in MSan:
Uninitialized bytes in strlen at offset 0 inside [0x70200013dec0, 30)
==589==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x7fffeeba96de in glLabelObjectEXT (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x4f6de)
#1 0x7fffeeba9b10 in glLabelObjectEXT (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x4fb10)
#2 0x7fffeeb879a3 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x2d9a3)
#3 0x7fffeeb894c0 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x2f4c0)
#4 0x7fffeeb8e400 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x34400)
#5 0x7fffeeb8f384 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x35384)
#6 0x7fffeeb8bd9a (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x31d9a)
#7 0x7fffecceb484 in queryExtensionsString third_party/angle/src/libANGLE/renderer/gl/glx/FunctionsGLX.cpp:354:12
#8 0x7fffecceb484 in rx::FunctionsGLX::initialize(_XDisplay*, int, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>*) third_party/angle/src/libANGLE/renderer/gl/glx/FunctionsGLX.cpp:223:30
#9 0x7fffeccdada2 in rx::DisplayGLX::initialize(egl::Display*) third_party/angle/src/libANGLE/renderer/gl/glx/DisplayGLX.cpp:114:15
#10 0x7fffec70f649 in egl::Display::initialize() third_party/angle/src/libANGLE/Display.cpp:1082:36
#11 0x7fffec0bed17 in egl::Initialize(egl::Thread*, egl::Display*, int*, int*) third_party/angle/src/libGLESv2/egl_stubs.cpp:514:5
#12 0x7fffec0c6319 in EGL_Initialize third_party/angle/src/libGLESv2/entry_points_egl_autogen.cpp:571:27
#13 0x7fffefc4000d in eglInitialize third_party/angle/src/libEGL/libEGL_autogen.cpp:177:12
#14 0x5555868ec92a in gl::GLDisplayEGL::InitializeDisplay(bool, std::__Cr::vector<gl::DisplayType, std::__Cr::allocator<gl::DisplayType>>, gl::EGLDisplayPlatform, gl::GLDisplayEGL*) ui/gl/gl_display.cc:769:10
#15 0x5555868eb310 in gl::GLDisplayEGL::Initialize(bool, std::__Cr::vector<gl::DisplayType, std::__Cr::allocator<gl::DisplayType>>, gl::EGLDisplayPlatform) ui/gl/gl_display.cc:660:8
#16 0x55556c6f1957 in ui::GLOzoneEGL::InitializeGLOneOffPlatform(bool, std::__Cr::vector<gl::DisplayType, std::__Cr::allocator<gl::DisplayType>>, gl::GpuPreference) ui/ozone/common/gl_ozone_egl.cc:25:17
#17 0x55558b1a8999 in gl::init::InitializeGLOneOffPlatform(gl::GpuPreference) ui/gl/init/gl_initializer_ozone.cc:27:26
#18 0x55558b1a6978 in gl::init::InitializeGLOneOffPlatformImplementation(bool, bool, bool, gl::GpuPreference) ui/gl/init/gl_factory.cc:211:24
#19 0x55558b1a6208 in gl::init::(anonymous namespace)::InitializeGLOneOffPlatformHelper(bool, gl::GpuPreference) ui/gl/init/gl_factory.cc:135:10
#20 0x55558b1a662d in gl::init::InitializeGLNoExtensionsOneOff(bool, gl::GpuPreference) ui/gl/init/gl_factory.cc:166:10
#21 0x55558b227379 in gpu::GpuInit::InitializeAndStartSandbox(base::CommandLine*, gpu::GpuPreferences const&) gpu/ipc/service/gpu_init.cc:495:18
#22 0x55559ab41ce4 in content::GpuMain(content::MainFunctionParams) content/gpu/gpu_main.cc:358:39
#23 0x55557b5888da in content::RunZygote(content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:685:14
#24 0x55557b58abad in content::RunOtherNamedProcessTypeMain(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, content::MainFunctionParams, content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:789:12
#25 0x55557b58e4fe in content::ContentMainRunnerImpl::Run() content/app/content_main_runner_impl.cc:1156:10
#26 0x55557b585aaf in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) content/app/content_main.cc:332:36
#27 0x55557b58644a in content::ContentMain(content::ContentMainParams) content/app/content_main.cc:345:10
#28 0x555580df9c37 in content::LaunchTestsInternal(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:385:12
#29 0x555580dfab58 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:504:10
#30 0x555582b8afec in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:392:10
#31 0x55557d422a0e in main chrome/test/base/browser_tests_main.cc:60:10
#32 0x7ffff48456c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
#33 0x7ffff4845784 in __libc_start_main csu/../csu/libc-start.c:360:3
#34 0x55555e647029 in _start (/usr/local/google/home/dcheng/src/chrome/src/out/msan/browser_tests+0x90f3029) (BuildId: 6cbc295b16ac1107)
Uninitialized value was created by a heap allocation
#0 0x55555e675a22 in malloc /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cpp:1021:3
#1 0x7ffff489b087 in __vasprintf_internal libio/vasprintf.c:116:16
#2 0x4ae8d349882b18ff (<unknown module>)
Bug: 40240570
Change-Id: If59faa297e214b7219ebb4c5c9572b44a33ee070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548826
Reviewed-by: Elad Alon <eladalon@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1303583}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )