[pull] main from chromium:main #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
https://chromium.googlesource.com/catapult.git/+log/738798dc163a..7ae3bc476654 2021-11-22 sebmarchand@google.com [pgo] Make the Android PGO build dump the profiles at shutdown If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1242138 Tbr: skyostil@google.com Change-Id: Ib326743adee64cf7848d9695270d880c1eb57f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296810 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944374}
Contrary to our initial plan, chrome://about will be split between Ash and Lacros. This CL adds the about page to the list of handled URLs and modifies it to show the user typable URLs (so os://<host> instead of chrome://<host>). With the upcoming refactor this change should become much simpler as the list of supported URLs will be generated automatically instead of getting created by hand. Then further filtering should become unnecessary. BUG=1271720 Change-Id: I652d131918bf4cf66b4da6f05fb7993ac5dcff75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297118 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Stefan Kuhne <skuhne@chromium.org> Auto-Submit: Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/main@{#944375}
To prevent unnecessary ancestor style invalidation triggered by irrelevant mutations, this CL added a filtering condition by collecting values from ':has()' argument selector. These are the values to be collected by each type of selector. - Class selectors : class name - Id selectors : id value - Attribute selectors : attribute name - Type selectors : tag name The collected values are stored in a HashSet by type. When there is a mutation on an element marked as AncestorsAffectedByHas, StyleEngine will match the mutation with the HashSet to determine whether the mutation is related to the ':has()' state change or not. The StyleEngine will invalidate the ancestors affected by ':has()' only if the mutation matches any of the value in the HashSet. Bug: 669058 Change-Id: If85b048c12da5d071afe51b2512217f34756a5a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295212 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Byungwoo Lee <blee@igalia.com> Cr-Commit-Position: refs/heads/main@{#944376}
* This is an automated release commit. * Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: I8080daa3a65996f5b0a55e74026b5574705d8970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295907 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944377}
when the tab group save flag is enabled. If our bookmark node is a permanent one (other, overflow/hidden, mobile), we continue to use the current implementation which opens a context menu on left click. Otherwise, all other bookmark nodes will be updated with the tab groups save functionality (opening all tabs on click in a new tab group). It should be noted that in an attached crash report for this bug, https://listnr.corp.google.com/product/208/report/89091548209, there is mention of crashing when clicking a non permanent node. This has been addressed in the following change https://chromium-review.googlesource.com/c/chromium/src/+/3282779. Bug: 1271684 Change-Id: I3c1588462efd46ae36e9c823f9be59e88ef0eced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297132 Reviewed-by: Dana Fried <dfried@chromium.org> Commit-Queue: Darryl James <dljames@chromium.org> Cr-Commit-Position: refs/heads/main@{#944378}
These methods are generally a bit more awkward to use than the helpers exposed by GURL::Replacement itself. Hide them to encourage callers to use the easier-to-use versions instead. Bug: 1271865 Change-Id: I592743c067edef3b90707c075ae20662099d0f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292948 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#944379}
Follow-up to crrev.com/c/3288609: IsCrossFileSystem should now handle the destination folders for copy/move operations, not only the paths for each individual destination entries. In particular, the Downloads folder is a valid destination, and should be handled as "On the Downloads volume and in the Downloads bind-mounted folder". Bug: b:204838286 Change-Id: I533f065ab514a88e29af87336873773e1810067d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292913 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/main@{#944380}
This CL moves:
{ => ash}/components/arc/media_session
This is part of the LaCrOs directory migration
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE
Bug: b:129295708
Test: CI
Change-Id: Ifb9ddca3341385245453061d496e9b1b8f7f55ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3293775
Commit-Queue: Yao Li <yaohuali@google.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Owners-Override: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/main@{#944381}
Bug: 1235480, 1261024, 1261025 Change-Id: I3732d56e200b8def19b8734fb14ba46f798db06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297047 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by: Max Curran <curranmax@chromium.org> Reviewed-by: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/main@{#944382}
The Delegation test was disabled a long time ago for being flaky and became stale. This CL fixes the test. Fixes: 1. The test initially failed because "webkitGetUserMedia" is only available for secure origins, and this test uses the "http" scheme. Modifying the test to load the page from "localhost" fixes this issue. 2. The test then consistently failed with the error "Could not start video source." This led me to guess that the first test case was providing some invalid value, so I changed the usage of "webrtc::kInvalidScreenId" to "webrtc::kFullDesktopScreenId," which fixed the failure. It may be that the first value had different semantics 8 years ago when this test was disabled. It doesn't seem worth it to me to spend more time tracking it down. 3. Though not strictly necessary, I modify the JS test code to report any error capturing the stream to the console. This will be useful if further diagnosis is needed. However, it now fails on some platforms for different reasons, so it is still disabled on those. There are corresponding tracking bugs for each platform with TODOs and failures details. Bug: 301887, 1271673, 1271680, 1271711 Change-Id: Ic65daf75db4036f15d17d78a79f59636498b796a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3291923 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/main@{#944383}
This change removes the flag which is expired in M87. This feature is enabled by default so the flag is no longer needed. Bug: 953690 Bug: 1159076 Change-Id: Ie02d0824a656f362ccc2af2d04f2faab30bb2f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3291757 Commit-Queue: Donna Wu <donna@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#944384}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/41173656ed43..940c740d4eff 2021-11-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id2d21f1b6922d9fa0a9c27d63c0db9faf0055845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297335 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944385}
Roll Chrome Win64 PGO profile from chrome-win64-main-1637625527-80ff8f0b8a39a36dfd943bdb9be31d3490f2ed32.profdata to chrome-win64-main-1637636343-14da4c21b5ab5893b91a9454f15f86e69190d4ee.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6f0594e87ad04098671c474ab421dafb9bc95468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297336 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944386}
This reverts commit 4468f42. Reason for revert: <INSERT REASONING HERE> This CL might break some tests: https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/74578 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28Wayland%29/3485 Original change's description: > Fixed additional failure web tests with real setTimeout 0 > > Currently setTimeout(..., 0) is clamped up to 1ms while which is > not supposed to be in the spec. This CL is intended to fix the tests > that become flaky with > > https://chromium-review.googlesource.com/c/chromium/src/+/3243793/ > > Bug: 402694 > Change-Id: Ibe66bbca3ae1cf3c1f9e4a1e225bf0d162146e79 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3291405 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Commit-Queue: Wanming Lin <wanming.lin@intel.com> > Cr-Commit-Position: refs/heads/main@{#944368} Bug: 402694 Change-Id: Ic90a5ceb77120738982299079a70a62324c7abab No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297251 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#944387}
Roll Chrome Win32 PGO profile from chrome-win32-main-1637625527-072eccc26e131db8b695587c27dd4e3982c5c6f4.profdata to chrome-win32-main-1637636343-2889ed990553da4b25cf3c77d1104fc4900820de.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If7821d835b2a51a0d7c5b45654f641db7866812b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297339 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944388}
This is in preparation of migrating to TypeScript. Bug: 1179821,1271509 Change-Id: Iabe2626641a4b82f635b4ca7e9afafdaaac3e564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3290962 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#944389}
https://skia.googlesource.com/skia.git/+log/2f6c53ff720a..c3db55663e5a 2021-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 4e3ddbd95589 to aaaf70aee209 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: Id31f7cf6419807262623dfeec11ab39349b55041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297344 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944390}
Only a subset of Exynos 9810 cores support the requisite instructions, which causes the crash. Bug: 1272795 Change-Id: Id5c43613674b1dde6ddddc42c22f76e74ed383dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295905 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/main@{#944391}
This CL makes sure the bottom sheet for PWA installs doesn't re-open after user dismisses it. Bug: 1268529 Change-Id: I82b39c68174256be6034cdc3ee0f69ea45f98db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295351 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#944392}
https://android.googlesource.com/platform/external/perfetto.git/+log/514e743cbfd9..d5cb19a57dc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9f3f865866777081975c90abccd78aaef36f9ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297468 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944393}
Bug: 1270913 Change-Id: Ib57d7111bde3a697ab1c45aa8144bb7af836c27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3289294 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#944394}
https://chromium.googlesource.com/vulkan-deps.git/+log/40b07bc7873c..b638c7fb7440 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/7efa90e528..7a0b9b212c * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b21acf16e7..ef2429635d * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b38a667579..e30862971d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com,shrekshao@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng Bug: None Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com,shrekshao@google.com Change-Id: I8ead6b32632e079817143f2abc811c0b2a3da0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297179 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944395}
Skylab bots in ChromeOS are missing vpython environment and have outdated python modules. six doesn't have ensure_str() causing: "AttributeError: 'module' object has no attribute 'ensure_str'". Use ensure_str() only if it is available. This is a temporary solution for b/206008069 to unblock b/205303357. Change-Id: I1a5012f22479889fa002d3d3106ac26915c3cec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296396 Commit-Queue: Denis Nikitin <denik@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#944396}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: Ic533604a1ee699a3d6974acf9b454f19a451155b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297331 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944397}
BUG=b:203753639 TEST=CQ TEST=chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* Change-Id: Ie49665b3c6a6602f7235a8fe67e316129d7573ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3274321 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Paul Moy <pmoy@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kerker Yang <kerker@chromium.org> Cr-Commit-Position: refs/heads/main@{#944398}
Add RestartOptions.share_paths and share any specified paths with a VM when it is first started. This change will allow Terminal app to call CrostiniManager::RestartWithOptions(shared_paths) and immediately launch the terminal where startup progress can be watched, rather than having to show only the spinner while crostini is started and then paths shared, and then terminal launched. Bug: 1028898 Change-Id: I3c145ac2d0a1964ed2f3d2ba1cc026a318cd5bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296060 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/main@{#944399}
https://android.googlesource.com/platform/external/perfetto.git/+log/715528ea109f..d5cb19a57dc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If28adf59a6cd4dada3a04486520519defa9f2374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297180 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944400}
…nch_handler
This CL implements the non-navigation launch behaviour for web apps
that specify
"launch_handler": {
"route_to": "existing-client",
"navigate_existing_client": "never"
}
in their manifest.
https://github.com/WICG/sw-launch/blob/main/launch_handler.md
Bug: 1250223
Change-Id: I188ece36f5ca576c88a1e329fa02893cf082cf0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3287183
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#944401}
Bug: 896689 Change-Id: Iaeb123dfe3081d620196b4a5ad92af3f5831b027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296031 Auto-Submit: Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/main@{#944402}
There is a [restamp] property on the dom-repeat of bookmark folders, which causes the same elements to be used as bookmarks and folders get moved around during drag and drop. The |open_| property was only listening for changes on |openFolders|, and not |folder.id| which can actually change as the |folder| binding gets shifted with the re-use of the same elements for a new ordering. Bug: 1270913 Change-Id: If1e13ca490ded698aea28e1d8fdcff4d0fefd493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297051 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#944403}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1c471b2d244..99ce23509f07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC zmin@google.com,dbertoni@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1271515 Tbr: zmin@google.com,dbertoni@google.com Change-Id: I3709c4d6fe7a5f6dcc1783160762847deec024ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298652 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944602}
Otherwise, reports with network failure will be shown as "Sent: HTTP(0)" which is a bit confusing. Change-Id: Ic85da2b7571dd403fa62d6b35bea06157429b093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295731 Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nan Lin <linnan@chromium.org> Cr-Commit-Position: refs/heads/main@{#944603}
Make sure that the GURL is copied before being used in the block to avoid crash. Fixed: 1266391 Change-Id: I8355f7296b4dfcd59fea6878b2abe7dc1c324752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297855 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme <jlebel@chromium.org> Reviewed-by: Jérôme <jlebel@chromium.org> Cr-Commit-Position: refs/heads/main@{#944604}
This CL changes media device name from /dev/media0 to /dev/media-dec0. This is because both /dev/media0 and /dev/media1 can be used for the purpose even with the same device. This media device is linked to /dev/media-dec0. Note that this is also platform dependent, so we might need to add something else for another platform in the future. Bug: b:203004039 TEST: v4l2_stateless_decoder --video crowd_run_256X144_fr15_bd8_8buf_l1_20210312.ivf on asurada Change-Id: Ia5efd5792c00baf3bfa97e1c99429b95e60e5f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296386 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Steve Cho <stevecho@chromium.org> Cr-Commit-Position: refs/heads/main@{#944605}
Change-Id: I3575ab8493a0eb7931f86f44696ca99658f5372f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296064 Reviewed-by: John Delaney <johnidel@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/main@{#944606}
Using wpt-import in Chromium e7fd13a. With Chromium commits locally applied on WPT: 0252e5b "appcache: remove wpt references to appcache" 53f2931 "Add WPT tests for SameSite cookies in ServiceWorkers with nested frames." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true R=kyleju@google.com No-Export: true Change-Id: I65a220fe7680d74c05c0c68f61463fb3fb97f75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298268 Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by: Kyle Ju <kyleju@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/main@{#944607}
mojom targets
This CL moves smaller mojom targets and unit tests.
{ => ash}/components/arc/mojom (partially)
Bigger mojom targets will be moved in separate CLs.
This is part of the LaCrOs directory migration
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE
Bug: b:129295708
Test: CI
Change-Id: Ic4bee431e05dbc8d635d71a9e76e5f4d539eb592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296857
Commit-Queue: Yao Li <yaohuali@google.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Owners-Override: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/main@{#944608}
This CL will attempt reland crrev.com/c/3293983. It will set the default value of the --additional-apk command line argument to []. Bug: 1233679 Change-Id: I7c75ae2be5dea60d0dabf037cdcee50a0c52ca4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298578 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/main@{#944609}
Before this CL, ShouldOfferFeatureForLink() checked the scheme of the current URL besides that of the link to be shared. The reason is unknown and this is possibly a bug, since the current URL never makes it to the other client anyway. This CL deletes ShouldOfferFeatureForLink() and starts calling ShouldOfferFeatureForPage() with the link URL instead. The latter is renamed to ShouldOfferToSendUrl(), to better reflect its new use. This change is actually a no-op if the share::kShareMenu feature toggle is enabled, because that removes STTS for links, c.f. crbug.com/1273150. The true usefulness of this change is reducing the number of predicates of type "Is STTS allowed", so we can later replace them with a single method that tells in which of the 3 states the STTS bubble is: a) feature enabled, choose target device b) feature enabled but no target device c) feature disabled, offer sign-in promo We also use this opportunity for some code improvements: - Drop the IsIncognitoProfile() check in ShouldOfferFeatureForPage(). This was redundant with the null check of SendTabToSelfSyncService. Worse, it didn't cover the Guest Profile case, where the service is also null. Now the method doesn't depend on profile and can be tested more easily. - Delete IsUserSyncTypeActive() and HasValidTargetDevice(), which were exposed in send_tab_to_self_util.h, but were never directly called in production code, only in tests. Bug: 1219433 Change-Id: Iba5cfa4a2cf47942fd220e8660e7a57e97a0af14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295397 Commit-Queue: Victor Vianna <victorvianna@google.com> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#944610}
Change-Id: I888c0abb2ee049942bfa3fe5f3dfc054e526a1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203522 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/main@{#944611}
Roll Chrome Mac PGO profile from chrome-mac-main-1637668272-a3ea81c0dae720a25d2ce49f9e34dcfcf3d5333f.profdata to chrome-mac-main-1637690235-01b9de8e80dda0810b22d7bb31105ec8059899c6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4881fb3cc1e89e9ec695521209d721cf1b2d8096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298724 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944612}
Fixes the show all builds argument, and makes the logging messages for all revisions clearer. Change-Id: I4210e74e7e47f769e0e49e8ea93f64bbd5a69dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3028983 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/main@{#944613}
https://swiftshader.googlesource.com/SwiftShader.git/+log/9e727fadeb66..17a11cfeb5f1 2021-11-23 capn@google.com Regres: Update test lists @ 9e727fad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-eng+autoroll@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-eng+autoroll@google.com Change-Id: I3a5cdb3c72148177c2f1e73eaad3d650601e5872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298648 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944614}
https://dawn.googlesource.com/dawn.git/+log/8c9e159e76b4..0166526569c6 2021-11-23 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b9e96af0a847 to f2bf9954b331 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC shrekshao@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: shrekshao@google.com Change-Id: I58d24af42e0bffc0a49693d7b26e2a3ed387a34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298713 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944615}
This was found while investigating how to remove non-SharedImage mailboxes. Bug: chromium:1273084 Change-Id: I58be399a81f4b0228cb4791d281416e949959ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298130 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/main@{#944616}
…rty. Bug: 1134497,425829 Change-Id: Ib7e95e8d2ef602fc2887c5f9a9e17da5eb67b625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296181 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#944617}
Migrate throbber notice to ES6 class syntax and move it directly inside components. Also sort some Gaia elements alphabetically in build files. Bug: 1184731 Change-Id: I432a8012944201ae27565eb4c399ff6ad0d11753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3268687 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/main@{#944618}
This reverts commit d3e95ce. Reason for revert: Causes conflicts when reverting https://crrev.com/c/3268917 Original change's description: > [iOS] Move tab helper delegate setup out of BrowserCoordinator > > This CL gets BrowserCoordinator out of the business of setting up > tab helper delegates. This also removes the need for BrowserCoordinator > to be a WebStateListObserver. > > All of the tab helper delegate setup is moved into the tab lifecycle > mediator. The OpenInCoordinator creation and setup was also handled > as part of delegate installation, but this doesn't seem to be necessary, > so it's moved to align with other coordinator creation and shutdown. > > In addition to adding the setup of the new delegates to > TabLifecycleMediator, the install/uninstall code is reorganized to > more clearly group different types of tab helper creation and/or > attachment, and to remove spurious nil checks. > > Bug: 906525 > Change-Id: Ie5fdd31c183fb975e2909236ec7f4c6f4ce9916f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3270675 > Commit-Queue: Mark Cogan <marq@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/main@{#943232} Revert "[iOS] Move tab helper delegate setup out of BrowserCoordinator" This reverts commit f91729a. Reason for revert: Broke NTP animation https://crbug.com/1271622 Original change's description: > Factor BVC's web state delegate installation into a mediator > > Currently the BVC is responsible for setting the delegates of several > tab helpers with UI dependencies. This requires the BVC to observe the > web state list to update these helpers when new tabs are added, which > is outside of a view controller's responsibilities. > > The BVC also implementing these delegate protocols is also a problem, > but not one addressed by this CL. > > This CL factors this job into a mediator (TabLifecycleMediator) which > the BrowserCoordinator owns. It handles injecting UI dependencies into > new web states (and removing them from departing ones). To do this, > the mediator is provided with a slew of objects (factories and other > objects) as well as a catchall delegate which conforms to all of the > tab helper delegate protocols that the BVC implements. > > To facilitate this, this CL adds a category on the BVC which includes > its conformance to those protocols, as well as a few other properties > which are needed as dependencies. This category is only used by the > BVC and BrowserCoordinator. > > A few tab helpers that were being configured in the BVC didn't need to > be, and are moved into AttachTabHelpers(). > > (BrowserCoordinator does similar delegate attachment and unattachment > via WebStateList observation; a follow-up CL also moves this into the > TabLifecycleMediator). > > Change-Id: I09d354a0c4a4172cf4d8a2d9043f7d328451f89a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3268917 > Commit-Queue: Mark Cogan <marq@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/main@{#942613} Bug: 906525 Change-Id: Ic59441d06bc84d4c4a48dce56816c2ce6a67151a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298949 Owners-Override: Justin Cohen <justincohen@chromium.org> Reviewed-by: Adam Trudeau-Arcaro <adamta@google.com> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/main@{#944619}
AX-Relnotes: N/A Bug: N/A Change-Id: Ic62dd34e688b532d1db6ae7f3b3021ee0322e0eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296165 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/main@{#944620}
Also, do not define these keys on Fuchsia as the module location is not useful and there is no legitimate use in obtaining it. Bug: 1263691, 1184980, 1262430 Change-Id: I856b6dbf79312006b96ce2714d999cef7059b454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3188614 Commit-Queue: Mason Bendixen <masonben@chromium.org> Auto-Submit: Mason Bendixen <masonben@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Peter Kvitek <kvitekp@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/main@{#944621}
Roll Chrome Linux PGO profile from chrome-linux-main-1637625527-a7e11685c237070e3140520064a7db5d9ecc3703.profdata to chrome-linux-main-1637690235-df5b552a8cd10a09d54aca77592cadb9c8ace36c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I712d2966a89164ded296595023c60f358d6ea7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298972 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#944622}
The SortButton in AppsContainerView was a button class that shows arrow buttons in tablet mode that can sort the app list on click/tap. As the context menu for sorting is implemented, remove this class and replace the functionality by using the context menu on AppsGridView and AppListItemView. Bug: 1263999 Change-Id: I8de26ab8186af4332195063617912529db15e46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3290605 Reviewed-by: Andrew Xu <andrewxu@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Wen-Chien Wang <wcwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#944623}
pull bot
pushed a commit
that referenced
this pull request
Jan 14, 2022
This reverts commit 6ff1599. Reason for revert: Seems to have caused browser_test failures on linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/19698 rowserTestBase received signal: Segmentation fault. Backtrace: #0 0x563ae696f899 base::debug::CollectStackTrace() #1 0x563ae68d6683 base::debug::StackTrace::StackTrace() #2 0x563ae6ff8293 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f9ac9026040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x563ae7720266 PrefChangeRegistrar::RemoveAll() #5 0x563ae7720222 PrefChangeRegistrar::~PrefChangeRegistrar() #6 0x563ae2f37095 std::__1::unique_ptr<>::reset() #7 0x563ae3696a1b policy::ActiveDirectoryMigrationManager::~ActiveDirectoryMigrationManager() #8 0x563ae3696a38 policy::ActiveDirectoryMigrationManager::~ActiveDirectoryMigrationManager() #9 0x563ae369a699 policy::BrowserPolicyConnectorAsh::~BrowserPolicyConnectorAsh() #10 0x563ae369a6fe policy::BrowserPolicyConnectorAsh::~BrowserPolicyConnectorAsh() #11 0x563ae6a0edbd BrowserProcessImpl::~BrowserProcessImpl() #12 0x563ae6a0edea BrowserProcessImpl::~BrowserProcessImpl() #13 0x563ae6a668e9 browser_shutdown::ShutdownPostThreadsStop() #14 0x563ae6a0e226 ChromeBrowserMainParts::PostDestroyThreads() #15 0x563ae349ef9b ash::ChromeBrowserMainPartsAsh::PostDestroyThreads() #16 0x563ae495d2d9 content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #17 0x563ae495e53c content::BrowserMainRunnerImpl::Shutdown() #18 0x563ae495a9ce content::BrowserMain() #19 0x563ae555e819 content::RunBrowserProcessMain() #20 0x563ae555f8e0 content::ContentMainRunnerImpl::RunBrowser() #21 0x563ae555f431 content::ContentMainRunnerImpl::Run() #22 0x563ae555d209 content::RunContentProcess() #23 0x563ae555d861 content::ContentMain() #24 0x563ae6ff6f2b content::BrowserTestBase::SetUp() #25 0x563ae68bf947 InProcessBrowserTest::SetUp() #26 0x563ae3b0fbed testing::Test::Run() #27 0x563ae3b10520 testing::TestInfo::Run() #28 0x563ae3b10ce1 testing::TestSuite::Run() #29 0x563ae3b1a61a testing::internal::UnitTestImpl::RunAllTests() #30 0x563ae3b1a219 testing::UnitTest::Run() #31 0x563ae69d5af8 base::TestSuite::Run() #32 0x563ae688bfa1 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #33 0x563ae70407b7 content::LaunchTests() #34 0x563ae688e77a LaunchChromeTests() #35 0x563ae688bf23 main #36 0x7f9ac9008bf7 __libc_start_main #37 0x563ae134462a _start Original change's description: > Remote powerwash on Chromad via policy > > Implement remote powerwash on Chromad, using the recently added > ChromadToCloudMigrationEnabled policy. The powerwash will be used to > start the migration of AD managed devices into cloud management. Besides > having the new policy enabled, the device needs to be on the login > screen and the enrollment ID must have already been uploaded to > DMServer. > > Bug: 1209246 > Change-Id: I6a67b8a8a43c28bc5f03f27e96d0415f69b6bc83 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3141873 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Roman Sorokin <rsorokin@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Felipe Andrade <fsandrade@chromium.org> > Cr-Commit-Position: refs/heads/main@{#959123} Bug: 1209246 Change-Id: If067abcf2a9289ebacaeb240b1f67749c305509c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3389555 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#959243}
pull bot
pushed a commit
that referenced
this pull request
Mar 12, 2022
During the tab attaching process, XDGSurfaceWrapperImpl::Configure() can be called and result in a WaylandToplevelWindow::Hide() calls, which actually deletes itself (see pseudo stacktrace below). > #2 0x7f369324c07e ui::WaylandToplevelWindow::Hide() > #3 0x7f36936bfbfa views::DesktopWindowTreeHostPlatform::HideImpl() > #4 0x7f3694691720 aura::WindowTreeHost::Hide() > #5 0x7f36936be274 views::DesktopWindowTreeHostPlatform::Close() > #6 0x7f3693690bcf views::Widget::CloseWithReason() > #7 0x55ab161b4382 Browser::TabStripEmpty() > #8 0x55ab1620e6d0 TabStripModel::SendDetachWebContentsNotifications() > (...) > #21 0x7f369324ef38 ui::WaylandWindow::SetBounds() > #22 0x7f369325141c ui::WaylandWindow::ApplyPendingBounds() > #23 0x7f369324bd47 ui::WaylandToplevelWindow::ApplyPendingBounds() > #24 0x7f3693250f20 ui::WaylandWindow::ProcessPendingBoundsDip() > #25 0x7f369324c932 ui::WaylandToplevelWindow::HandleSurfaceConfigure() > #26 0x7f369325c263 ui::XDGSurfaceWrapperImpl::OnConfigure() > #27 0x7f369325c110 ui::XDGSurfaceWrapperImpl::Configure() > #28 0x7f36932739c5 ffi_call_unix64 To protect against such scenarios, which can hard crash both Lacros and Ash, this CL guards XDGSurfaceWrapperImpl with the WeakPtrFactory pattern, particularly within the context of XDGSurfaceWrapperImpl::OnConfigure(). BUG=1303425 R=nickdiego@igalia.com Change-Id: Ic84b3d5cf2ac11b30a82090f49c99a991e4dd243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3519638 Reviewed-by: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/main@{#980254}
pull bot
pushed a commit
that referenced
this pull request
Aug 31, 2022
This reverts commit 395b2b1. Reason for revert: the following test cases fail - MediaFoundationRendererIntegrationTest.BasicPlayback - MediaFoundationRendererIntegrationTest.BasicPlayback_MediaSource on Windows 10/Asan with the failure log: [ RUN ] MediaFoundationRendererIntegrationTest.BasicPlayback ================================================================= ==644==ERROR: AddressSanitizer: access-violation on unknown address 0x000000000008 (pc 0x7ff6889a1e92 bp 0x00c26c4fe5f0 sp 0x00c26c4fe560 T0) ==644==The signal is caused by a READ memory access. ==644==Hint: address points to the zero page. ==644==*** WARNING: Failed to initialize DbgHelp! *** ==644==*** Most likely this means that the app is already *** ==644==*** using DbgHelp, possibly with incompatible flags. *** ==644==*** Due to technical reasons, symbolization might crash *** ==644==*** or produce wrong results. *** #0 0x7ff6889a1e91 in base::RepeatingCallback<void (const base::UnguessableToken &, const gfx::Size &, base::TimeDelta)>::Run C:\b\s\w\ir\cache\builder\src\base\callback.h:263 #1 0x7ff6889a1e91 in media::MediaFoundationRenderer::RequestNextFrame(void) C:\b\s\w\ir\cache\builder\src\media\renderers\win\media_foundation_renderer.cc:1022:23 #2 0x7ff68899bed8 in media::MediaFoundationRenderer::OnPlaying(void) C:\b\s\w\ir\cache\builder\src\media\renderers\win\media_foundation_renderer.cc:838:3 #3 0x7ff68a04bb3a in base::OnceCallback<void ()>::Run C:\b\s\w\ir\cache\builder\src\base\callback.h:145 #4 0x7ff68a04bb3a in base::TaskAnnotator::RunTaskImpl(struct base::PendingTask &) C:\b\s\w\ir\cache\builder\src\base\task\common\task_annotator.cc:133:32 #5 0x7ff68ac91059 in base::TaskAnnotator::RunTask C:\b\s\w\ir\cache\builder\src\base\task\common\task_annotator.h:72 #6 0x7ff68ac91059 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(class base::LazyNow *) C:\b\s\w\ir\cache\builder\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:422:21 #7 0x7ff68ac90046 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork(void) C:\b\s\w\ir\cache\builder\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:292:41 #8 0x7ff68acc53da in base::MessagePumpDefault::Run(class base::MessagePump::Delegate *) C:\b\s\w\ir\cache\builder\src\base\message_loop\message_pump_default.cc:39:55 #9 0x7ff68ac9316b in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, class base::TimeDelta) C:\b\s\w\ir\cache\builder\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:575:12 #10 0x7ff68960a00c in base::RunLoop::Run(class base::Location const &) C:\b\s\w\ir\cache\builder\src\base\run_loop.cc:141:14 #11 0x7ff68942c9a7 in media::PipelineIntegrationTestBase::RunUntilQuitOrError(class base::RunLoop *) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:697:13 #12 0x7ff689424636 in media::PipelineIntegrationTestBase::RunUntilQuitOrEndedOrError(class base::RunLoop *) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:709:3 #13 0x7ff689424449 in media::PipelineIntegrationTestBase::WaitUntilEndedOrError(void) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:226:5 #14 0x7ff689423ac4 in media::PipelineIntegrationTestBase::WaitUntilOnEnded(void) C:\b\s\w\ir\cache\builder\src\media\test\pipeline_integration_test_base.cc:217:27 #15 0x7ff686ce4597 in media::MediaFoundationRendererIntegrationTest_BasicPlayback_Test::TestBody(void) C:\b\s\w\ir\cache\builder\src\media\renderers\win\media_foundation_renderer_integration_test.cc:92:3 #16 0x7ff6870b0c77 in testing::Test::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2670:5 #17 0x7ff6870b2c3b in testing::TestInfo::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2849:11 #18 0x7ff6870b498e in testing::TestSuite::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:3008:30 #19 0x7ff6870d772f in testing::internal::UnitTestImpl::RunAllTests(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:5866:44 #20 0x7ff6870d6bd5 in testing::UnitTest::Run(void) C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:5440:10 #21 0x7ff6896d7a69 in RUN_ALL_TESTS C:\b\s\w\ir\cache\builder\src\third_party\googletest\src\googletest\include\gtest\gtest.h:2284 #22 0x7ff6896d7a69 in base::TestSuite::Run(void) C:\b\s\w\ir\cache\builder\src\base\test\test_suite.cc:463:16 #23 0x7ff6896dc4ed in base::OnceCallback<int ()>::Run C:\b\s\w\ir\cache\builder\src\base\callback.h:145 #24 0x7ff6896dc4ed in base::`anonymous namespace'::LaunchUnitTestsInternal C:\b\s\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:181:38 #25 0x7ff6896dc0ba in base::LaunchUnitTests(int, char **, class base::OnceCallback<(void)>, unsigned __int64) C:\b\s\w\ir\cache\builder\src\base\test\launcher\unit_test_launcher.cc:272:10 #26 0x7ff686dcc7f9 in main C:\b\s\w\ir\cache\builder\src\media\test\run_all_unittests.cc:52:10 #27 0x7ff68c67712b in invoke_main d:\a01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:78 #28 0x7ff68c67712b in __scrt_common_main_seh d:\a01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 #29 0x7fff384a2773 (C:\Windows\System32\KERNEL32.DLL+0x180012773) #30 0x7fff386e0d50 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: access-violation C:\b\s\w\ir\cache\builder\src\base\callback.h:263 in base::RepeatingCallback<void (const base::UnguessableToken &, const gfx::Size &, base::TimeDelta)>::Run ==644==ABORTING Original change's description: > [MediaFoundation] Request next frame during onPlaying event > > OS: Win10, Win11 > > During OnPlaying event, a frame request should be called to get > the first frame to output at the earliest possible time. This > is the earliest time when a frame is available. Current > implementation waits for render to be called, while > StartPlayingFrom's call for RequestNextFrameBetweenTimestamps > may not output a result if the media engine is not yet ready > to output a frame. > > Bug: 1355520 > Change-Id: Ice60ac41ca4b8cae9b0687626e93017d0a4406f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852409 > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Commit-Queue: Daoyuan Li <daoyuanli@microsoft.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1041097} Bug: 1355520 Change-Id: Ic483e314ce14e3f187691df772515eacea387cb1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3863075 Commit-Queue: Asami Doi <asamidoi@chromium.org> Owners-Override: Asami Doi <asamidoi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1041256}
pull bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
Differently than all other browsers tested (including Firefox/Linux, Chrome/X11, Web, etc), Chromium/Wayland is triggering key auto-repeat logic for modifier keys, eg alt, shift and control. Despite the mismatch in behavior with other major browsers, Lacros (which is based on Ozone/Wayland) is also having problems with left-over auto-repeat logic being ran, after the user performed a no-op alt-tab'ing. Basically, when an alt-tab starts on Ash, off of Lacros: 1/ ozone/wayland can trigger the auto-repeat logic for ALT key; 2/ if the alt-tab is no-op, the lacros can be left-over with the ALT key auto-repeat logic ON. This state breaks any subsequent tab-dragging operation with the following pseude-stack: #1 base::debug::StackTrace::StackTrace() #2 TabStrip::TabDragContextImpl::DestroyDragController() #3 TabDragController::EndDrag() (...) #25 ui::PlatformEventSource::DispatchEvent() #26 ui::WaylandEventSource::OnKeyboardKeyEvent() #27 ui::WaylandKeyboard::DispatchKey() #28 ui::WaylandKeyboard::DispatchKey() #29 ui::EventAutoRepeatHandler::OnRepeatCommit() #30 _ZNO4base12OnceCallbackIFvvEE3RunEv #31 ui::WaylandKeyboard::SyncCallback() At least, two fixes need to be taken here: 1/ not trigger the auto-repeat key logic for modifiers (or somehow reset it); 2/ send a synthetic ALT key released event, when the App Switcher gets started in Ash, off of Lacros. This CL does /1/ above. BUG=1367014 R=nickdiego@igalia.com Change-Id: I7b69c873aef70cacbead10a35d9801fb263774a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4098284 Reviewed-by: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/main@{#1083211}
pull bot
pushed a commit
that referenced
this pull request
Feb 25, 2023
…ew." This reverts commit 508aa18. Reason for revert: Causes IbanBubbleViewFullFormBrowserTest.Local_ClickingHideOrShowIbanValueManageView failurees. from https://ci.chromium.org/ui/p/chromium/builders/ci/linux-ubsan-vptr/21221/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2Fchrome%2Ftest%3Ainteractive_ui_tests%2FIbanBubbleViewFullFormBrowserTest.Local_ClickingHideOrShowIbanValueManageView+VHash%3Ad2ca29b55d68a4ff: ../../chrome/browser/ui/views/autofill/payments/iban_bubble_view_uitest.cc:282:12: runtime error: downcast of address 0x0798015a1b00 which does not point to an object of type 'SaveIbanBubbleView' 0x0798015a1b00: note: object is of type 'autofill::ManageSavedIbanBubbleView' 29 00 00 00 38 f3 68 e6 e4 55 00 00 78 f3 68 e6 e4 55 00 00 c0 ce 6c 01 98 07 00 00 80 18 0b 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'autofill::ManageSavedIbanBubbleView' #0 0x55e4d02f0701 in autofill::IbanBubbleViewFullFormBrowserTest::GetSaveIbanBubbleView() chrome/browser/ui/views/autofill/payments/iban_bubble_view_uitest.cc:282:12 #1 0x55e4d02fb74f in autofill::IbanBubbleViewFullFormBrowserTest::ClickOnDialogView(views::View*) chrome/browser/ui/views/autofill/payments/iban_bubble_view_uitest.cc:345:5 #2 0x55e4d02f6e6e in autofill::IbanBubbleViewFullFormBrowserTest_Local_ClickingHideOrShowIbanValueManageView_Test::RunTestOnMainThread() chrome/browser/ui/views/autofill/payments/iban_bubble_view_uitest.cc:623:3 #3 0x55e4d99bf48e in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:895:7 #4 0x55e4d4a7be0d in Run base/functional/callback.h:152:12 #5 0x55e4d4a7be0d in content::BrowserMainLoop::InterceptMainMessageLoopRun() content/browser/browser_main_loop.cc:1038:36 #6 0x55e4d4a7bf1e in content::BrowserMainLoop::RunMainMessageLoop() content/browser/browser_main_loop.cc:1050:7 #7 0x55e4d4a811f9 in content::BrowserMainRunnerImpl::Run() content/browser/browser_main_runner_impl.cc:158:15 #8 0x55e4d4a75a6d in content::BrowserMain(content::MainFunctionParams) content/browser/browser_main.cc:32:28 #9 0x55e4d6fe2fbe in content::RunBrowserProcessMain(content::MainFunctionParams, content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:716:10 #10 0x55e4d6fe5438 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams, bool) content/app/content_main_runner_impl.cc:1276:10 #11 0x55e4d6fe4f4d in content::ContentMainRunnerImpl::Run() content/app/content_main_runner_impl.cc:1130:12 #12 0x55e4d6fe02ab in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) content/app/content_main.cc:324:36 #13 0x55e4d6fe0935 in content::ContentMain(content::ContentMainParams) content/app/content_main.cc:341:10 #14 0x55e4d99be269 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:575:3 #15 0x55e4d7cec8e0 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:484:20 #16 0x55e4d0875e53 in SyncTest::SetUp() chrome/browser/sync/test/integration/sync_test.cc:300:24 #17 0x55e4d0e00c17 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2665:3 #18 0x55e4d0e0265e in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2849:11 #19 0x55e4d0e042fb in testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:3008:30 #20 0x55e4d0e1a210 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5866:44 #21 0x55e4d0e18dc8 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:5440:10 #22 0x55e4daaaa4a0 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2284:73 #23 0x55e4daaaa4a0 in base::TestSuite::Run() base/test/test_suite.cc:454:16 #24 0x55e4d7cb6b48 in ChromeTestSuiteRunner::RunTestSuiteInternal(ChromeTestSuite*) chrome/test/base/chrome_test_launcher.cc:95:22 #25 0x55e4d03f6416 in InteractiveUITestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/interactive_ui_tests_main.cc:134:12 #26 0x55e4d99fb844 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:415:31 #27 0x55e4d7cb722e in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:318:10 #28 0x55e4d03f63a1 in main chrome/test/base/interactive_ui_tests_main.cc:176:10 #29 0x7fbe2824bc86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86) (BuildId: f7307432a8b162377e77a182b6cc2e53d771ec4b) #30 0x55e4cff4a029 in _start (/b/s/w/ir/out/Release/interactive_ui_tests+0xc8b2029) (BuildId: b65d070fe6c272ab) also: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20CFI/24652/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2Fchrome%2Ftest%3Ainteractive_ui_tests%2FIbanBubbleViewFullFormBrowserTest.Local_ClickingHideOrShowIbanValueManageView+VHash%3A18b587341aed5390 Original change's description: > [IBAN local save] Add eye icon to manage saved IBAN bubble view. > > This CL introduce Eye Icon to manage saved IBAN bubble view, which can > reveal full IBAN value or show masked IBAN on clicking. > > Screenshot: > https://screenshot.googleplex.com/3rtMkB6f6UhSL47 > > Mock: > https://screenshot.googleplex.com/FkAmHC4aPtzt44d > > Bug: 1349109 > Change-Id: I51afa60384ff1065785e8351f355eaa66c76fdd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4237378 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Qihui Zhao <qihuizhao@google.com> > Reviewed-by: Vinny Persky <vinnypersky@google.com> > Cr-Commit-Position: refs/heads/main@{#1109451} Bug: 1349109 Change-Id: I473c317aaf5d70e538e6ced970ecc4294491d069 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4291366 Commit-Queue: Brian Begnoche <bcb@chromium.org> Owners-Override: Brian Begnoche <bcb@chromium.org> Auto-Submit: Brian Begnoche <bcb@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1109581}
pull bot
pushed a commit
that referenced
this pull request
May 21, 2024
Attempting to initialize the GPU triggers MSan failures in GL with eager
checks enabled in MSan:
Uninitialized bytes in strlen at offset 0 inside [0x70200013dec0, 30)
==589==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x7fffeeba96de in glLabelObjectEXT (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x4f6de)
#1 0x7fffeeba9b10 in glLabelObjectEXT (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x4fb10)
#2 0x7fffeeb879a3 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x2d9a3)
#3 0x7fffeeb894c0 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x2f4c0)
#4 0x7fffeeb8e400 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x34400)
#5 0x7fffeeb8f384 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x35384)
#6 0x7fffeeb8bd9a (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x31d9a)
#7 0x7fffecceb484 in queryExtensionsString third_party/angle/src/libANGLE/renderer/gl/glx/FunctionsGLX.cpp:354:12
#8 0x7fffecceb484 in rx::FunctionsGLX::initialize(_XDisplay*, int, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>*) third_party/angle/src/libANGLE/renderer/gl/glx/FunctionsGLX.cpp:223:30
#9 0x7fffeccdada2 in rx::DisplayGLX::initialize(egl::Display*) third_party/angle/src/libANGLE/renderer/gl/glx/DisplayGLX.cpp:114:15
#10 0x7fffec70f649 in egl::Display::initialize() third_party/angle/src/libANGLE/Display.cpp:1082:36
#11 0x7fffec0bed17 in egl::Initialize(egl::Thread*, egl::Display*, int*, int*) third_party/angle/src/libGLESv2/egl_stubs.cpp:514:5
#12 0x7fffec0c6319 in EGL_Initialize third_party/angle/src/libGLESv2/entry_points_egl_autogen.cpp:571:27
#13 0x7fffefc4000d in eglInitialize third_party/angle/src/libEGL/libEGL_autogen.cpp:177:12
#14 0x5555868ec92a in gl::GLDisplayEGL::InitializeDisplay(bool, std::__Cr::vector<gl::DisplayType, std::__Cr::allocator<gl::DisplayType>>, gl::EGLDisplayPlatform, gl::GLDisplayEGL*) ui/gl/gl_display.cc:769:10
#15 0x5555868eb310 in gl::GLDisplayEGL::Initialize(bool, std::__Cr::vector<gl::DisplayType, std::__Cr::allocator<gl::DisplayType>>, gl::EGLDisplayPlatform) ui/gl/gl_display.cc:660:8
#16 0x55556c6f1957 in ui::GLOzoneEGL::InitializeGLOneOffPlatform(bool, std::__Cr::vector<gl::DisplayType, std::__Cr::allocator<gl::DisplayType>>, gl::GpuPreference) ui/ozone/common/gl_ozone_egl.cc:25:17
#17 0x55558b1a8999 in gl::init::InitializeGLOneOffPlatform(gl::GpuPreference) ui/gl/init/gl_initializer_ozone.cc:27:26
#18 0x55558b1a6978 in gl::init::InitializeGLOneOffPlatformImplementation(bool, bool, bool, gl::GpuPreference) ui/gl/init/gl_factory.cc:211:24
#19 0x55558b1a6208 in gl::init::(anonymous namespace)::InitializeGLOneOffPlatformHelper(bool, gl::GpuPreference) ui/gl/init/gl_factory.cc:135:10
#20 0x55558b1a662d in gl::init::InitializeGLNoExtensionsOneOff(bool, gl::GpuPreference) ui/gl/init/gl_factory.cc:166:10
#21 0x55558b227379 in gpu::GpuInit::InitializeAndStartSandbox(base::CommandLine*, gpu::GpuPreferences const&) gpu/ipc/service/gpu_init.cc:495:18
#22 0x55559ab41ce4 in content::GpuMain(content::MainFunctionParams) content/gpu/gpu_main.cc:358:39
#23 0x55557b5888da in content::RunZygote(content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:685:14
#24 0x55557b58abad in content::RunOtherNamedProcessTypeMain(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, content::MainFunctionParams, content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:789:12
#25 0x55557b58e4fe in content::ContentMainRunnerImpl::Run() content/app/content_main_runner_impl.cc:1156:10
#26 0x55557b585aaf in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) content/app/content_main.cc:332:36
#27 0x55557b58644a in content::ContentMain(content::ContentMainParams) content/app/content_main.cc:345:10
#28 0x555580df9c37 in content::LaunchTestsInternal(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:385:12
#29 0x555580dfab58 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:504:10
#30 0x555582b8afec in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:392:10
#31 0x55557d422a0e in main chrome/test/base/browser_tests_main.cc:60:10
#32 0x7ffff48456c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
#33 0x7ffff4845784 in __libc_start_main csu/../csu/libc-start.c:360:3
#34 0x55555e647029 in _start (/usr/local/google/home/dcheng/src/chrome/src/out/msan/browser_tests+0x90f3029) (BuildId: 6cbc295b16ac1107)
Uninitialized value was created by a heap allocation
#0 0x55555e675a22 in malloc /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cpp:1021:3
#1 0x7ffff489b087 in __vasprintf_internal libio/vasprintf.c:116:16
#2 0x4ae8d349882b18ff (<unknown module>)
Bug: 40240570
Change-Id: If59faa297e214b7219ebb4c5c9572b44a33ee070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548826
Reviewed-by: Elad Alon <eladalon@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1303583}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )