[pull] main from chromium:main #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This CL make users of //components/arc:arc point to //ash/components/arc:arc. It also cleans up unused deps of //components/arc:arc and //ash/components/arc:arc, after the move. It also does some clean-up on some meta-files, like DEPS. This is part of the LaCrOs directory migration https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE Bug: b:129295708 Bug: 1164001 Test: CI Change-Id: Idc9dfdcbdbc3d490c76a147583e94539efda6a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298437 Commit-Queue: Yao Li <yaohuali@google.com> Reviewed-by: James Cook <jamescook@chromium.org> Owners-Override: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#947860}
https://chromium.googlesource.com/openscreen.git/+log/f1c6841fc07d..ae15ed85690e 2021-12-03 jophba@chromium.org Add SessionConfig validation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Iecd02f377202f9c346cd7b7abef423328fd505a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314035 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/main@{#947861}
This CL will add skew tests for version 96.0.4664.81. See crbug.com/1041619 and crbug.com/1099017 for more information. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: I04164cff66585c0c410adc0d5b5d47308f3c364b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314079 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947862}
This CL will add skew tests for version 97.0.4692.40. See crbug.com/1041619 and crbug.com/1099017 for more information. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: I8226c2a8be96d62c31c843d1a150338e1e5376f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314216 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947863}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: Ie28c0a3d4c11d7d70a225f70cf62291d30363135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314119 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947864}
Will be used in a follow up CL by the holding space feature to improve UI based on specific danger and mixed content type states. Bug: 1275353 Change-Id: Ia93f96e14c8e9ae815a243447cddd66831fea141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309897 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#947865}
The flags have been renamed to make it clear that they only apply to Windows (see associated bug). If you're reviewing this CL, please verify your code's usage of the flag to ensure that the behavior is as intended. Thanks! This CL was uploaded by git cl split. R=fdegros@chromium.org Bug: 1244149 Change-Id: I3aa932b5ef4903f5dacf0ba8339d7fda04e1207f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313717 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: François Degros <fdegros@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/main@{#947866}
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3e68015b7f43..98be56f2e011 2021-12-03 ajgo@chromium.org [windows_sdk] allow env json to not be relative If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1250098 Tbr: ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com Change-Id: If38abe9f5d943fb130b978f683cf5791f975a414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314237 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947867}
kEnableWebAppUninstallFromOsSettings feature enables Windows OS Setting registration for web app. The registered app can be uninstalled from the OS Settings or Controls. There is a web app type that can't be uninstalled from the user such as policy app in that we shouldn't register the OS settings either. The fix is to check app user uninstall capability as a registration threshold. Bug: 1266825 Change-Id: I428ba925e001cf2e947f342ad81d728f0e267d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3265247 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Sunggook Chue <sunggch@microsoft.com> Cr-Commit-Position: refs/heads/main@{#947868}
This is a UX decision that selecting the calculator result should NOT completely change the user's search query. Also remove an unused reference to OmniboxDisplayType, to prepare for the removal of the enum. Bug: 1226459 Change-Id: I25b45e4bff8cc2cbda6857a775f27c9b44380ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312142 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/main@{#947869}
* This is an automated release commit. * Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: If3e396d9f5ad8fa45058664c3de5a2caf44c8b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313861 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947870}
Bug: 1268156 Change-Id: I7fa5a8de6cc0373b511f19514e97fb43a69ca912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3268621 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/main@{#947871}
Some Drive notifications were only appearing if there was a listener. This was only fine in legacy as the background page would always be listening. This changes it so in SWA mode, the File Manager url is always added as a listener so events can be sent to the SystemNotificationManager if no windows are open. This also changes the Drive Confirm dialog to always appear as a system notification too. Bug: b:194637696 Change-Id: I39b0756d8b73c4e3e4f6fab6298b7743e36d3602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312513 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/main@{#947872}
Bug: 1276201, 1276199, 1276206, 1276207, 1276208, 1276209 Change-Id: I914dcd06a73eb8848d2ac450eb83c74da4f7b9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313362 Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/main@{#947873}
This CL will fix the existing web platform test for background sync test in a fenced frame. Currently assert code is never called due to the lack of await operator for test functions. Also by having inappropriate scope parameter for the service worker registration, the service worker never becomes ready and can not write expected values to server. The problem was found while working on this CL, FYI. https://crrev.com/c/3310158 Change-Id: I030c5e6575975c8091ab986faecf5ac3ab43d529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310458 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Shunya Shishido <sisidovski@google.com> Cr-Commit-Position: refs/heads/main@{#947874}
Passed the test this morning (83%). The GuestOS team has agreed to share metrics knowledge for each of its top-level categories (crostini, borealis, and pluginvm so-far), so this change arbitrarily chooses crostini as the defining owners file and adds a reference to it in borealis' directory. Bug: n/a Change-Id: Ia9b6e480ecb49796319a267e18cdd4b80e55e151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314037 Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/main@{#947875}
This fixes the problem where there is a large gap between the title and the subtitle when there is no account and the identity controller is in the top. Problem and fix: http://shortn/_MV5OcJnrHl Bug: 1273303 Change-Id: I7171d9b67e99efdf6e712ae325bcc2465096d4f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3301002 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/main@{#947876}
https://dawn.googlesource.com/dawn.git/+log/959f1da63760..b6c1a51775ae 2021-12-02 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 29babe0fdc44 to f3052589f723 (3 revisions) 2021-12-02 bajones@chromium.org Implement GPUCommandEncoder::ClearBuffer 2021-12-02 shrekshao@google.com Fix google3 license related issues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Ie96e82862f210742e8d557949ef342d5ed3b6ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314197 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947877}
https://chromium.googlesource.com/infra/infra.git/+log/2927dee37b79..2892a4983327 2021-12-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll luci-py from 255883efe75d to d9f53f0fe5c4 (1 revision) 2021-12-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll luci-go from a54b827335b5 to 545ddc36596a (1 revision) 2021-12-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll chromiumos/infra/proto from 188745602b54 to 7b099f8ccb39 (1 revision) 2021-12-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll chromiumos/config from e388c4d5e07c to a6cd8a0525b0 (1 revision) 2021-12-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll chromiumos/infra/proto from 3c9632354953 to 188745602b54 (1 revision) 2021-12-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2021-12-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll chromiumos/config from 14e43ce29008 to e388c4d5e07c (1 revision) 2021-12-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll luci-py from f7fef3f3dd04 to 255883efe75d (1 revision) 2021-12-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2021-12-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll luci-py from a997c5990609 to f7fef3f3dd04 (1 revision) 2021-12-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll luci-go from 8ecf7d6b9b8e to a54b827335b5 (1 revision) 2021-12-03 chanli@chromium.org [Weetbix] Remove unused indexes 2021-12-03 gregorynisbet@google.com [crosskylabadmin] Add but do not use Paris config settings. 2021-12-03 nqmtuan@google.com [Findit] Add instruction to main page 2021-12-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll luci-go from f7994e168d57 to 8ecf7d6b9b8e (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-chromium Please CC tikuta@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: tikuta@chromium.org Change-Id: I03cc0dee5f631cc43cdf2019c13ba4cd07380373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314241 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947878}
Inspiration for this fix was taken from libvpx/examples/vpx_temporal_svc_encoder.c Also more thorough testing for SVC encoding results Bug: 1275319 Change-Id: Ifb75697fdc36c00d7d6bbc7c5d3b584fbfa7a548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312046 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/main@{#947879}
This CL made python code under build/android/ compatible with pylint-2.7 while avoiding changes that cause pylint-1.5 warnings. Changes in this CL may not be trivial. There can be a risk to change the logic unexpectedly. For build/android/gyp/extract_unwind_tables_tests.py, the function has been removed, and this CL tried to simulate the removed function while avoiding File I/O issues. Bug: 1262303 Change-Id: Ia34d14673f60c40433933c8dbd865ef8509c8533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308350 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/main@{#947880}
Add network request timeouts for: 1. update interest group requests. 2. worklet fetches. 3. trusted data fetches. Bug: b/192445811 Change-Id: I101ce9ddc28d94e131e498f55b0823cc2da53e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3279628 Commit-Queue: Qingxin Wu <qingxinwu@google.com> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/main@{#947881}
This adds a test that enables the feature for resizing docked magnifier, drags the separator, and verifies that the magnified viewport resizes. AX-Relnotes: N/A. Bug: 1267522 Change-Id: Icff9bd25b4cea0171e4d70dd98b0f8c24d99da27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3311988 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/main@{#947882}
Enable up/down button functions when the event list view is shown. Clicking on the button will scroll for 1 row each time. Bug: 1238927 Change-Id: I1e4a015c8a77fe18b08b10e5250416211004704b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312610 Commit-Queue: Jiaming Cheng <jiamingc@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/main@{#947883}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13da370a50cd..52958c6ec4fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1275170 Tbr: horo@google.com Change-Id: I88db1e20b2146fa64e34561ab4dee9c4ca3f003f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314242 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947884}
Change the Files SWA dialog to be of frame kind kNnonClient instead of kDialog [1]. This makes the dialog to have the same look and feel as the legacy dialog and allows to customize the dialog to be movable, re-sizable and the title bar color. [1] https://source.chromium.org/chromium/chromium/src/+/main:ui/views/controls/webview/web_dialog_view.cc;l=226-230;drc=0e45c020c43b1a9f6d2870ff7f92b30a2f03a458 Bug: b:197814219, b:197928829 b:197812760 Change-Id: Id68d0df64aceea940feb9ab7628cf54fee251544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312515 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Bo Majewski <majewski@chromium.org> Cr-Commit-Position: refs/heads/main@{#947885}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4dae36a5..81017394 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iffc70eae3c74ab5103613692dbb1697f81d02796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3311275 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947886}
(1) Finch feature is renamed as QuickDim. (2) Add two extra parameters for power_manager to use. Bug: chromium:1241704 Change-Id: I14716292843f07e5bc38fd83f768d95ad892c431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308340 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Michael Martis <martis@chromium.org> Commit-Queue: Guoxing Zhao <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/main@{#947887}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/402308b66643..ebebd5834bda 2021-12-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia92ab584c7d68cd1eeb99647d7e74c790b932387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314200 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947888}
ash::kAppIDKey was always checked when updating ash::kAppIDKey and ash::kShelfIDKey. The only effect of this bug was unnecessary no-op updates to ash::kShelfIDKey (since app IDs and shelf IDs serialise differently and can never be equal). Bug: 1203992 Change-Id: I020b6143944e1f04e52ee70ce6c9aaf33d6f33a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314040 Auto-Submit: Alexander Bolodurin <alexbn@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexander Bolodurin <alexbn@chromium.org> Cr-Commit-Position: refs/heads/main@{#947889}
This CL adds data structures to support color syncing. In detail, this CL does the following things: (1) Add a feature flag called `kLauncherItemColorSync` to enable/disable the synchronization on app list item colors. Color syncing is enabled only when app list sorting is enabled. (2) Add color enum type and the message type that carries color information in app_list_specifics.proto (3) In app_list_syncable_service.cc, add the code to: (i) Fetch colors from sync data (ii) Update the color stored in the sync data with the value retrieved from app list item (iii) Transfer item colors to another sync item (iv) Save and fetch colors from local data. Issues to address: (1) Given that the old OS code will not sync colors, this CL only allows meaningful colors to be propagated. Is it possible that the new color should be empty? But I think the chance of this edge case is very tiny. (2) In this CL, when the icon of `ChromeAppListItem` is set, the colors stored in sync items are not updated. The subsequent CLs will handle it. This CL should not bring any noticeable changes. Bug: 1270898 Change-Id: Ib38b040227cacf5e6cbaa30fa8daee017374abee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3305772 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/main@{#947900}
The flags have been renamed to make it clear that they only apply to Windows (see associated bug). If you're reviewing this CL, please verify your code's usage of the flag to ensure that the behavior is as intended. Thanks! This CL was uploaded by git cl split. R=alexmos@chromium.org Bug: 1244149 Change-Id: I337a7aa817e66a13817f660baa193855bcba017c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313719 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#947901}
This CL updates the color of the control buttons for ARC notifications to match it with the refreshed Chrome notifications. Bug: b:208899982 Test: manual - notifications are shown with the flag enabled. Change-Id: Icdbe43d291dacb2149fe9e6e4411773f316c4bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314046 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Toshiki Kikuchi <toshikikikuchi@chromium.org> Cr-Commit-Position: refs/heads/main@{#947902}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52958c6ec4fc..dfbb212ff221 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1269213,chromium:1273052 Tbr: horo@google.com Change-Id: I1985dc78c8e08447ae94f4db279b7a7ed10ad988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313794 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947903}
Change-Id: Id2ef5d51a04b4d3539a1fcede88db584686b9c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313757 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/main@{#947904}
A transform establishes a containing block for "everything", including fixed-positioned descendants. Letting spanners escape this seems strange, and it causes trouble for accessibility in our implementation. See w3c/csswg-drafts#6805 Bug: 1267847, 1225860 Change-Id: Ibcf9af327824a4683d4b33935c3bc28abe61f998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310883 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#947905}
If a block fits in the current fragmentainer, don't let overflowing children pull it over to the next fragmentainer because of less appealing breaks inside. Instead overflow the fragmentainer. This is a special rule that is required in order to print Google Docs correctly (maybe there are other reasons too). Gecko also does this. EdgeHTML also does something similar. See crbug.com/507972 The legacy block fragmentation engine also had a workaround for Google Docs, although simpler and weirder (if a line doesn't fit in the current fragmentainer, but won't fit in the next one either, just leave it where it is, even if we had already made some progress in the current fragmentainer). In a way, crbug.com/178742#c8 is related, which is about overflow inside monolithic content, and how we let it overflow the fragmentainer. The logic in IsNodeFullyGrown() was very similar to what we needed here, so remove it and share code and logic. Bug: 1242348 Change-Id: Ibc26576d3096f59b629e1ef8c5f725621d8094e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310887 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#947906}
https://webrtc.googlesource.com/src.git/+log/8f25690d549d..adf7dc34f036 2021-12-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 80cfe1b..d934d80 (947754:947870) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie43e4d5b453578b0158402557b37fe47ce15a6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314419 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947907}
https://chromium.googlesource.com/vulkan-deps.git/+log/09e892902929..d4645fdba0d5 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/0e1396862c..ec5ea2d6cb * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/993b82fe63..29414ae1fd * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d0a827a9f3..c75a1a46f3 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/a152371654..ea61f32f24 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/36cc581621..143eb773e4 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/b50a0f786e..08f87babad * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c6bafff88f..81195dfecb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com,kainino@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng Bug: chromium:1276023 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com,kainino@google.com Change-Id: I2ce0a9b775993aaf2b5841eaf525d28f2e3f5c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314278 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947908}
Bug: 1276290, 1276044 Change-Id: Ia45de16f284fe81986126d43747bc74887174c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312935 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/main@{#947909}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/81017394..614a9188 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9bb5b55096bf54d9a94ba0eab2e61b41ef8af703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313801 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947910}
Roll Chrome Linux PGO profile from chrome-linux-main-1638489589-596dd2f44b3a467d1b853b190ee3340b2a2477c5.profdata to chrome-linux-main-1638510714-6c67f979136374d7f0514ab00aa7278c749c7e6c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If0a4340060e7559c2fa3aa202f82d351197ef77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314433 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947911}
We hit a reentrancy check at LocalFrameView::UpdateLifecyclePhases when running wpt/resize-observer/iframe-same-origin.html. This is caused by a bug in the test infrastructure, not a production code. Mark the test as crashy on every platform to remove the flakiness. Bug: 1270820, 626703, 1275806 Change-Id: I4fd0c74a1a6d22959e3d9fa41852df824d542f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310338 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/main@{#947912}
Roll Chrome Mac PGO profile from chrome-mac-main-1638489589-3b117dd109d840d8c61278b96db976fcddb93c57.profdata to chrome-mac-main-1638510714-202da105cfb68636a32b9bef81bc9d243342d97d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I60d3c9760a1cf185d8aa30d38a3fc9fc52f9bcac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314431 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947913}
Add build flag to build with the prebuilt library. Bug: b/206058055 Test: manual Change-Id: If3469c05f72363ccaadbff1ac629503cf91f0728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3285631 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/main@{#947914}
This CL reveals the smart privacy settings subpage if _either_ snooping protection or quick dim is enabled. It also hooks up a preference to, and a setting to allow for deep linking to, the quick dim toggle. Note that the preference is not yet used anywhere, but will be shorty. The CL also includes limited renaming of smart screen lock -> quick dim, to combat some of the heterogenous feature naming that we've been guilty of so far. Modified translate strings should not yet be translated since they are only prospective and will definitely change after UX review. Bug: chromium:1262869, chromium:1241706 Change-Id: Ia170cbcf3f37c717c588ca24fd5cf76bf494d82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312666 Commit-Queue: Michael Martis <martis@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#947915}
https://chromium.googlesource.com/infra/infra.git/+log/f9ac0b5e43be..3de46a51120f 2021-12-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll chromiumos/config from a6cd8a0525b0 to 62e2b735451d (1 revision) 2021-12-03 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll luci-go from 545ddc36596a to 7038d49d16be (1 revision) 2021-12-03 iannucci@chromium.org Disable experiment_reasons. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-chromium Please CC tikuta@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: tikuta@chromium.org Change-Id: I9e532c2e9abc0733290f3ffacef92b4def1625a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314432 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947916}
crrev.com/c/3313633 extended the timeout of show-picker.tentative.html. But after crrev.com/c/3120336, slow tests are not allowed to mark Timeout. This is causing "webkit_lint" failure on builder. So this CL updates TestExpectations to mark as Skip. Bug: 1276304 Change-Id: I1208999ef5954a954cbedd2631f3da27225480eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314461 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/main@{#947917}
Roll Chrome Win64 PGO profile from chrome-win64-main-1638500245-9346128b31ef1110e47b26ff8bfffffa979d0d04.profdata to chrome-win64-main-1638510714-bdaebb7ac67df8e3ad15ac7ac55bdacde93b133a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I30085dd7636ab5c17ff1f48c104cfadea6dd8faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314426 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947918}
In order to make delegated compositing work with rounded corners as they are supposed to work, the entire rounded corners rect for each quad must be set. Otherwise, they are applied to each quad instead of being applied to quads as if they are composited. See DirectRenderer::ShouldApplyRoundedCorner for more details. Moreover, the rounded corners are sent in dip and must be translated from dip to px. Bug: 1263496 Change-Id: I9469cc179f08e26a4c51cf48cb4fcea65162cbf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295602 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Peter McNeeley <petermcneeley@google.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/main@{#947919}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfbb212ff221..1d1dc276afe9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: horo@google.com Change-Id: I92ecc5552d9858d51a4f9bcd6d13110998fb68d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314430 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947920}
To make settings and close buttons big enough for touchscreen users, ChromeVox panel height is changed to 44 pixels and the target area around the two buttons is increased to 36 pixels. Screenshots: https://screenshot.googleplex.com/BNVAuJQgxsEJpWC.png Bug: 869886 Change-Id: Idbcaf8214e0cc80cadbaa2ad815c4b1aacde788a Ax-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313119 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Akihiro Ota <akihiroota@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/main@{#947921}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ebebd5834bda..09e65fc25e2f 2021-12-03 jacktfranklin@chromium.org Clear sinon stubs between each unit test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib175cf51b28fbad641e8e5ae922710727d1669dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314598 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947922}
Roll Chrome Win32 PGO profile from chrome-win32-main-1638500245-fd8863827353a5a98372f1b554211185887b101e.profdata to chrome-win32-main-1638510714-32ddff5acb046b82de454eadb9d0b89238b21caf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3c46e69598b32c9e60e2532d26482bc82f38ff2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314429 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#947923}
A recent CL (since reverted for other reason) subtly changed the behavior of overlapping --vmodule entries, breaking the existing "first match is effective" logic. Add some gtests to cover this behavior, as this can be highly confusing if it changes unannounced. See https://chromium-review.googlesource.com/c/chromium/src/+/3298331 for the revert of a CL that would've broken two of the new tests here. Bug: 489441, 1238262 Change-Id: Ie2310d8d4dd7637b39fffdee68a67be6e97f3a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306463 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Cr-Commit-Position: refs/heads/main@{#947924}
pull bot
pushed a commit
that referenced
this pull request
Jan 14, 2022
This reverts commit 6ff1599. Reason for revert: Seems to have caused browser_test failures on linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/19698 rowserTestBase received signal: Segmentation fault. Backtrace: #0 0x563ae696f899 base::debug::CollectStackTrace() #1 0x563ae68d6683 base::debug::StackTrace::StackTrace() #2 0x563ae6ff8293 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f9ac9026040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f) #4 0x563ae7720266 PrefChangeRegistrar::RemoveAll() #5 0x563ae7720222 PrefChangeRegistrar::~PrefChangeRegistrar() #6 0x563ae2f37095 std::__1::unique_ptr<>::reset() #7 0x563ae3696a1b policy::ActiveDirectoryMigrationManager::~ActiveDirectoryMigrationManager() #8 0x563ae3696a38 policy::ActiveDirectoryMigrationManager::~ActiveDirectoryMigrationManager() #9 0x563ae369a699 policy::BrowserPolicyConnectorAsh::~BrowserPolicyConnectorAsh() #10 0x563ae369a6fe policy::BrowserPolicyConnectorAsh::~BrowserPolicyConnectorAsh() #11 0x563ae6a0edbd BrowserProcessImpl::~BrowserProcessImpl() #12 0x563ae6a0edea BrowserProcessImpl::~BrowserProcessImpl() #13 0x563ae6a668e9 browser_shutdown::ShutdownPostThreadsStop() #14 0x563ae6a0e226 ChromeBrowserMainParts::PostDestroyThreads() #15 0x563ae349ef9b ash::ChromeBrowserMainPartsAsh::PostDestroyThreads() #16 0x563ae495d2d9 content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #17 0x563ae495e53c content::BrowserMainRunnerImpl::Shutdown() #18 0x563ae495a9ce content::BrowserMain() #19 0x563ae555e819 content::RunBrowserProcessMain() #20 0x563ae555f8e0 content::ContentMainRunnerImpl::RunBrowser() #21 0x563ae555f431 content::ContentMainRunnerImpl::Run() #22 0x563ae555d209 content::RunContentProcess() #23 0x563ae555d861 content::ContentMain() #24 0x563ae6ff6f2b content::BrowserTestBase::SetUp() #25 0x563ae68bf947 InProcessBrowserTest::SetUp() #26 0x563ae3b0fbed testing::Test::Run() #27 0x563ae3b10520 testing::TestInfo::Run() #28 0x563ae3b10ce1 testing::TestSuite::Run() #29 0x563ae3b1a61a testing::internal::UnitTestImpl::RunAllTests() #30 0x563ae3b1a219 testing::UnitTest::Run() #31 0x563ae69d5af8 base::TestSuite::Run() #32 0x563ae688bfa1 BrowserTestSuiteRunnerChromeOS::RunTestSuite() #33 0x563ae70407b7 content::LaunchTests() #34 0x563ae688e77a LaunchChromeTests() #35 0x563ae688bf23 main #36 0x7f9ac9008bf7 __libc_start_main #37 0x563ae134462a _start Original change's description: > Remote powerwash on Chromad via policy > > Implement remote powerwash on Chromad, using the recently added > ChromadToCloudMigrationEnabled policy. The powerwash will be used to > start the migration of AD managed devices into cloud management. Besides > having the new policy enabled, the device needs to be on the login > screen and the enrollment ID must have already been uploaded to > DMServer. > > Bug: 1209246 > Change-Id: I6a67b8a8a43c28bc5f03f27e96d0415f69b6bc83 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3141873 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Roman Sorokin <rsorokin@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Felipe Andrade <fsandrade@chromium.org> > Cr-Commit-Position: refs/heads/main@{#959123} Bug: 1209246 Change-Id: If067abcf2a9289ebacaeb240b1f67749c305509c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3389555 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#959243}
pull bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
This CL makes C++ unit tests workable with/without the RubyLineBreakbale flag. * delete_selection_command_test.cc: With RubyLineBreakable, `<ruby> </ruby>` is removed like a normal inline element. The test requires a space after the caret remains after DeleteSelectionCommand. So using non-space character instead of <ruby> is enough. * selection_modifier_test.cc: <ruby> doesn't match to the requirement of some tests because <ruby> is not an atomic-inline any longer. This CL replaces <ruby> with <b>, which is display:inline-block in the tests. * text_offset_mapping_test.cc: <ruby> and <rt> are inline now. So the whole contents should be selected. * inline_items_builder_test.cc: It's hard to make a test similar to InlineItemsBuilderTest.HasRuby with RubyLineBreakable. So, we disable the test if RubyLineBreakable is enabled, and add a HasRuby check to InlineItemsBuilderTest.OpenCloseRubyColumns. * line_breaker_test.cc: Make it have a correct lifecycle state. * layout_ruby_base_test.cc: Support of new layout tree structure. * layout_ruby_column_test.cc: Skip if RubyLineBreakable is enabled. The test doesn't make sense with RubyLineBreakable. Bug: 324111880 Change-Id: I3595ed2bdf4970eaeaea5e012d6f7ff3c7fe43c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5459058 Reviewed-by: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1289815}
pull bot
pushed a commit
that referenced
this pull request
May 21, 2024
Attempting to initialize the GPU triggers MSan failures in GL with eager
checks enabled in MSan:
Uninitialized bytes in strlen at offset 0 inside [0x70200013dec0, 30)
==589==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x7fffeeba96de in glLabelObjectEXT (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x4f6de)
#1 0x7fffeeba9b10 in glLabelObjectEXT (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x4fb10)
#2 0x7fffeeb879a3 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x2d9a3)
#3 0x7fffeeb894c0 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x2f4c0)
#4 0x7fffeeb8e400 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x34400)
#5 0x7fffeeb8f384 (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x35384)
#6 0x7fffeeb8bd9a (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x31d9a)
#7 0x7fffecceb484 in queryExtensionsString third_party/angle/src/libANGLE/renderer/gl/glx/FunctionsGLX.cpp:354:12
#8 0x7fffecceb484 in rx::FunctionsGLX::initialize(_XDisplay*, int, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>*) third_party/angle/src/libANGLE/renderer/gl/glx/FunctionsGLX.cpp:223:30
#9 0x7fffeccdada2 in rx::DisplayGLX::initialize(egl::Display*) third_party/angle/src/libANGLE/renderer/gl/glx/DisplayGLX.cpp:114:15
#10 0x7fffec70f649 in egl::Display::initialize() third_party/angle/src/libANGLE/Display.cpp:1082:36
#11 0x7fffec0bed17 in egl::Initialize(egl::Thread*, egl::Display*, int*, int*) third_party/angle/src/libGLESv2/egl_stubs.cpp:514:5
#12 0x7fffec0c6319 in EGL_Initialize third_party/angle/src/libGLESv2/entry_points_egl_autogen.cpp:571:27
#13 0x7fffefc4000d in eglInitialize third_party/angle/src/libEGL/libEGL_autogen.cpp:177:12
#14 0x5555868ec92a in gl::GLDisplayEGL::InitializeDisplay(bool, std::__Cr::vector<gl::DisplayType, std::__Cr::allocator<gl::DisplayType>>, gl::EGLDisplayPlatform, gl::GLDisplayEGL*) ui/gl/gl_display.cc:769:10
#15 0x5555868eb310 in gl::GLDisplayEGL::Initialize(bool, std::__Cr::vector<gl::DisplayType, std::__Cr::allocator<gl::DisplayType>>, gl::EGLDisplayPlatform) ui/gl/gl_display.cc:660:8
#16 0x55556c6f1957 in ui::GLOzoneEGL::InitializeGLOneOffPlatform(bool, std::__Cr::vector<gl::DisplayType, std::__Cr::allocator<gl::DisplayType>>, gl::GpuPreference) ui/ozone/common/gl_ozone_egl.cc:25:17
#17 0x55558b1a8999 in gl::init::InitializeGLOneOffPlatform(gl::GpuPreference) ui/gl/init/gl_initializer_ozone.cc:27:26
#18 0x55558b1a6978 in gl::init::InitializeGLOneOffPlatformImplementation(bool, bool, bool, gl::GpuPreference) ui/gl/init/gl_factory.cc:211:24
#19 0x55558b1a6208 in gl::init::(anonymous namespace)::InitializeGLOneOffPlatformHelper(bool, gl::GpuPreference) ui/gl/init/gl_factory.cc:135:10
#20 0x55558b1a662d in gl::init::InitializeGLNoExtensionsOneOff(bool, gl::GpuPreference) ui/gl/init/gl_factory.cc:166:10
#21 0x55558b227379 in gpu::GpuInit::InitializeAndStartSandbox(base::CommandLine*, gpu::GpuPreferences const&) gpu/ipc/service/gpu_init.cc:495:18
#22 0x55559ab41ce4 in content::GpuMain(content::MainFunctionParams) content/gpu/gpu_main.cc:358:39
#23 0x55557b5888da in content::RunZygote(content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:685:14
#24 0x55557b58abad in content::RunOtherNamedProcessTypeMain(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, content::MainFunctionParams, content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:789:12
#25 0x55557b58e4fe in content::ContentMainRunnerImpl::Run() content/app/content_main_runner_impl.cc:1156:10
#26 0x55557b585aaf in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) content/app/content_main.cc:332:36
#27 0x55557b58644a in content::ContentMain(content::ContentMainParams) content/app/content_main.cc:345:10
#28 0x555580df9c37 in content::LaunchTestsInternal(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:385:12
#29 0x555580dfab58 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:504:10
#30 0x555582b8afec in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:392:10
#31 0x55557d422a0e in main chrome/test/base/browser_tests_main.cc:60:10
#32 0x7ffff48456c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
#33 0x7ffff4845784 in __libc_start_main csu/../csu/libc-start.c:360:3
#34 0x55555e647029 in _start (/usr/local/google/home/dcheng/src/chrome/src/out/msan/browser_tests+0x90f3029) (BuildId: 6cbc295b16ac1107)
Uninitialized value was created by a heap allocation
#0 0x55555e675a22 in malloc /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cpp:1021:3
#1 0x7ffff489b087 in __vasprintf_internal libio/vasprintf.c:116:16
#2 0x4ae8d349882b18ff (<unknown module>)
Bug: 40240570
Change-Id: If59faa297e214b7219ebb4c5c9572b44a33ee070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548826
Reviewed-by: Elad Alon <eladalon@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1303583}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )