Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a README #2

Merged
merged 4 commits into from
Sep 22, 2020
Merged

Create a README #2

merged 4 commits into from
Sep 22, 2020

Conversation

github-learning-lab[bot]
Copy link
Contributor

Step 2: Edit the README.md

👋 @FaisalAfroz, Mona has created a README and needs your help making it great. ✨

Why you need a README.md

The README.md is the landing page for your project. It helps people understand, at a glance, whether your project is something that will be useful to them.

README.md files typically include information on:

  • What the project does
  • The features and benefits of the project
  • How users can get started with the project
  • Where users can get help with your project
  • Who maintains and contributes to the project

Check it out

Mona's README.md is missing some of the information above. Will you help Mona by replacing the placeholder text? I have suggested some changes below. Apply the suggested changes, or modify the file directly if you wish!

⌨️ Activity: Editing the README.md

You can follow the manual steps below, or accept the suggested changes in the following comments.

  1. Edit README.md on this branch, or manually change it in the Files Changed tab.
  2. Find the two placeholder texts labeled DESCRIPTION PLACEHOLDER and FEATURES PLACEHOLDER.
  3. Replace each placeholder with some bulleted information that may be helpful to new users.
  4. After editing the README.md file, scroll down and click the Commit changes button.

I'll respond when I detect a commit on this branch.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: github-learning-lab[bot] <37936606+github-learning-lab[bot]@users.noreply.github.com>
@github-learning-lab
Copy link
Contributor Author

I was looking for you to replace the features placeholder, but it looks like it's still there. Marketing gave us a with a few bullets for the features (they are so good at this stuff). Here is what they recommended:

Welcome new users with maintainer defined comments the first time your users:

  • Create a new issue
  • Open a new pull request
  • Merge their first pull request

Do you mind adding it to the README.md in this pull request where Mona put the placeholder?

⌨️ Activity: Add project features

You can accept the suggested changes, or make the change manually as follows:

  1. Access the Files changed tab in this pull request.
  2. Click the icon to the right of the file to edit the README.md.
  3. Find the text marked FEATURES PLACEHOLDER and add the text recommended above.
  4. After editing the README.md file, scroll down and click the Commit changes button.

I'll respond when I detect a commit on this branch.

Co-authored-by: github-learning-lab[bot] <37936606+github-learning-lab[bot]@users.noreply.github.com>
@github-learning-lab
Copy link
Contributor Author

Step 3: Approve and merge the pull request.

This README.md is looking great! Let's go ahead and merge it. There's a lot more to do!

⌨️ Activity: Approve the pull request

  1. Clicking on this quicklink
  2. Select Approve
  3. Click Submit review.

You can also approve by clicking on Files changed, clicking on Review changes, selecting Approve and then Submit review.


I'll respond when you've approved this pull request.

@github-learning-lab github-learning-lab bot merged commit a67812d into master Sep 22, 2020
@github-learning-lab
Copy link
Contributor Author

The README.md is a great introduction, but some documentation will help users feel even more supported as they start using the app. Mona has created a draft. Can you help?


Check out the pull request.

@FaisalAfroz FaisalAfroz deleted the add-readme branch September 22, 2020 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants