Document available methods for fr_BE locale
#46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the documentation to add currently undocumented methods that are available provided by the `fr_BE` locale. Also document generic methods (e.g. city names) that have customizations for `fr_BE`
|
Hi? 👋 |
bram-pkg
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the providers for the
fr_BElocale have a few bugs. And they could also be greatly improved.But before proposing any code change, I thought it would make sense to update the docs so that they reflect the actual state of the locale. Right now, quite a few things are still undocumented.
So this PR updates the docs to add currently missing methods and it also documents “standard” methods (e.g.
cityName()) that have undocumented customizations forfr_BE.