Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new user add email addr need save twice #227

Closed
1 task done
anschein opened this issue Sep 18, 2022 · 4 comments · Fixed by #760
Closed
1 task done

new user add email addr need save twice #227

anschein opened this issue Sep 18, 2022 · 4 comments · Fixed by #760
Labels
bug Something isn't working good first issue Good for newcomers released

Comments

@anschein
Copy link

Description

import emby account,and edit there email,when first time click save button,lost input email and back to user name,but after input the email addr again,the save button works

Version

1.1.1

Steps to Reproduce

As Description

Screenshots

No response

Logs

No response

Platform

desktop

Device

desktop pc

Operating System

win11

Browser

chrome

Additional Context

No response

Code of Conduct

  • I agree to follow Overseerr's Code of Conduct
@Fallenbagel Fallenbagel added the bug Something isn't working label Sep 19, 2022
@serverless83
Copy link

This bug is still present in 1.6.0 version.

@Fallenbagel Fallenbagel added the good first issue Good for newcomers label Apr 21, 2024
@noybman
Copy link

noybman commented Apr 21, 2024

Still an issue today in 1.8.1.
I decided to "import users", then manually went through each one and hit "save", now users can get it right on their first try (perhaps). It seemed to work for me a few times so far.

this makes me think something needs to be written to the database on import and it is not written until saved at least once?

gauthier-th added a commit to gauthier-th/jellyseerr that referenced this issue May 22, 2024
@gauthier-th
fix(api): save user email on the first try
49abd03 
fix Fallenbagel#227
@gauthier-th gauthier-th mentioned this issue May 22, 2024
Merged
3 tasks
@gauthier-th
Copy link
Collaborator

Fixed in #760.

Fallenbagel added a commit that referenced this issue May 23, 2024
@gauthier-th @Fallenbagel
fix(api): save user email on the first try (#760)
0bbcfdc 
* fix(api): save user email on the first try

fix #227

* fix(api): remove todo

* fix(logging): handle media server connection refused error/toast (#748)

* fix(logging): handle media server connection refused error/toast

Properly log as connection refused if the jellyfin/emby server is unreachable. Previously it used to
throw a credentials error which lead to a lot of confusion

* refactor(i8n): extract translation keys

* refactor(auth): error message for a more consistent format

* refactor(auth/errors): use custom error types and error codes instead of abusing error messages

* refactor(i8n): replace connection refused translation key with invalidurl

* fix(error): combine auth and api error class into a single one called network error

* fix(error): use the new network error and network error codes in auth/api

* refactor(error): rename NetworkError to ApiError

---------

Co-authored-by: Fallenbagel <98979876+Fallenbagel@users.noreply.github.com>
@Fallenbagel
Copy link
Owner

🎉 This issue has been resolved in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(api): save user email on the first try gauthier-th/jellyseerr
5 participants
@noybman @serverless83 @gauthier-th @anschein @Fallenbagel