[Bug] "Play in 4K" visible in Issues despite content not being 4K

[OdinVex]

Description

I've got an episode with an issue unrelated to video dimensions but the "Play in 4K on Jellyfin" button is still visible/usable when viewed from the Issues section of that episode. The regular content viewed does not have 4K content and only shows "Play on Jellyfin". Dimensions in this case are 1280x960.

Version

1.7.0

Steps to Reproduce

1. Create an issue for non-4K content (in this case 1280x960).
2. Viewed on right, "Play in 4K on Jellyfin".

Screenshots

No response

Logs

N/A

Platform

desktop

Device

Custom

Operating System

Manjaro Linux x64

Browser

LibreWolf (Firefox-fork)

Additional Context

I do not have any 4K Radarr/Sonarr either. I don't differentiate.

Code of Conduct

• I agree to follow Jellyseerr's Code of Conduct

[Fallenbagel]

I cannot replicate this. Check your services > sonarr/radarr do you have default 4k server checked?

[OdinVex]

No, I don't have any 4K server/services. It only affects Issues for Series. I managed to replicate it with a different Series as well. It does NOT show "Play in 4K" at the Series page, only in the Issues page for a Series. If it were a "4K" issue I'd expect it to show that button on both.

Edit: I can create a phony Issue for any Series and they have the same problem. Only on the Issues page is there an erroneous "Play in 4K on Jellyfin" button.

Edit: And to doubly-clarify, "4K Server" is unchecked and there is only one instance of Radarr and Sonarr, neither are 4K.

[Fallenbagel]

Can you check develop tag. I still can't replicate this.

[OdinVex]

Edit: Both latest and develop are affected.

Edit: A short note, Movies are not affected by this issue, only Series, even old series that are 4:3 640x480 NTSCs (1960s...).

Edit: I'm not sure if it matters or helps, but both "Play" buttons have the same URI.

*Screenshot is on a 4K monitor (desktop client, non-mobile), no connection to content of course.*

[OdinVex]

Some setup background: Jellyfin only, using non-local accounts (require signing in with Jellyfin login), and the only funny thing in the logs is on startup:

2024-03-10T05:50:00.111Z [error][Jellyfin API]: Something went wrong while getting library content from the Jellyfin server: connect ECONNREFUSED JELLYFIN_INSTANCE_URI
2024-03-10T05:50:00.123Z [error][Jellyfin Sync]: Sync interrupted {"errorMessage":"Invalid auth token"}

Never saw any API key input during installation of Jellyseerr (I don't use Plex). Maybe this could be related? Full-scan doesn't seem to be working anymore, either:

2024-03-10T05:59:56.882Z [info][Jellyfin Sync]: Jellyfin Sync Starting {"sessionId":"93bd26f8-90c8-4a0c-be59-945203becf67"}
2024-03-10T05:59:56.925Z [info][Jellyfin Sync]: Full Scan Complete

Edit: Forced Jellyseerr to start using the external interface, able to reconnect and rescan. Still shows that "Play in 4K on Jellyfin" issue, but scan hasn't completed. (Yes, docker is set to Host, as is Jellyfin, so localhost was valid over a month ago.)

[Fallenbagel]

Your connection with jellyfin is messed up. That might be why.

As you can see from my screenshot it's a series. And it's develop tag. I think this is more of a configuration issue and I would suggest you hop onto discord so we can follow through.

[OdinVex]

I don't Discord, I'll just wander through trying to figure out how it determines whether something is 4K or not.

[Fallenbagel]

I don't Discord, I'll just wander through trying to figure out how it determines whether something is 4K or not.

First you need to fix your jellyfin connection. I would suggest checking if the container can reach. Or try a complete fresh test container.

[OdinVex]

First you need to fix your jellyfin connection. I would suggest checking if the container can reach. Or try a complete fresh test container.

I did, "Edit: Forced Jellyseerr to start using the external interface, able to reconnect and rescan. Still shows that "Play in 4K on Jellyfin" issue, but scan hasn't completed. (Yes, docker is set to Host, as is Jellyfin, so localhost was valid over a month ago.)"

Edit: Started clean, same issue, any series. 4K is NOT enabled on either Radarr or Sonarr in Jellyseerr or otherwise.

[Fallenbagel]

I can't recreate it still. I have checked on new instances, new instances, new machines, non of it has 4k in it. This might be an issue from your jellyfin api too. Try a new instance with new jellyfin instance i guess.

[OdinVex]

That is unreasonable, given the size of the database and the time it takes to scan (Jellyfin's threading and DB backend is utterly in need of a complete rewrite). How does Jellyseerr come to think of anything as 4K? I'd rather debug it from that end.

[Fallenbagel]

That is unreasonable, given the size of the database and the time it takes to scan (Jellyfin's threading and DB backend is utterly in need of a complete rewrite). How does Jellyseerr come to think of anything as 4K? I'd rather debug it from that end.

I'm talking about a test jellyfin instance with just 1 show...

It looks at the video dimensions.

[OdinVex]

I'm talking about a test jellyfin instance with just 1 show...

Ah, right.

It looks at the video dimensions.

Any way I can see that process/information? It's 640x480, old NTSC stuff. Edit: Besides, why would it be correct on the Series page but not the Issues page? This just sounds like an Issues page bug.

[Fallenbagel]

Any way I can see that process/information? It's 640x480, old NTSC stuff. Edit: Besides, why would it be correct on the Series page but not the Issues page? This just sounds like an Issues page bug.

It does sound like a bug yes. But if I can't recreate/face the same bug, I can't fix it 🤷‍♂️😔

Desktop view (previously i sent mobile view. Both are series):

[Fallenbagel]

Any way I can see that process/information? It's 640x480, old NTSC stuff. Edit: Besides, why would it be correct on the Series page but not the Issues page? This just sounds like an Issues page bug.

It does sound like a bug yes. But if I can't recreate/face the same bug, I can't fix it 🤷‍♂️😔
If you figure it out, feel free to open a pr.

Desktop view (previously i sent mobile view. Both are series):

[OdinVex]

That looks mobile in Desktop View, not an actual desktop browser (or one with a small resolution and css media-specific sizes kicking in).

Edit: Great, more Sqlite usage. *sigh* Anyway, status4k is set to 1 (true) on all shows in the sqlite db, regardless of actual content. Whatever means it has of detecting content is broken and it is assuming all is (edit: Yes, even on new Jellyseerr and multiple new Jellyfin instances, I used one show per instance just to test that too). ffprobe: Stream #0:0: Video: h264 (High), yuv420p(progressive), 640x480 [SAR 1:1 DAR 4:3], 23.98 fps, 23.98 tbr, 1k tbn (default)

[Fallenbagel]

That looks mobile in Desktop View, not an actual desktop browser (or one with a small resolution and css media-specific sizes kicking in).

Oh yes sorry I attached the wrong screenshot lol hold on

[OdinVex]

Under both media and season status4k is set to 1 even though no content is 4K. Curious, could the Add4kStatusFields migration have caused something? Is 4K status altered by full scans?

Edit: "status4k" integer NOT NULL DEFAULT (1) You've assigned it true by default (./server/migration/1610370640747-Add4kStatusFields.ts)?

[Fallenbagel]

Admin, sonarr unconfigured:

Admin, sonarr configured:

Admin, different browser, different instance, sonarr 4k configured but no 4k media:

Admin, different browser, different instances, different locale:

User view, no 4k:

[OdinVex]

Admin, different browser, different instance, sonarr 4k configured but no 4k media

If no 4K media then why does it say 4K? Also, see the comment earlier I made on migrations. Curious why it defaults to 4k for migrations and why it doesn't correct it on full scan. Since migration is ran even on new installs that seems like a curious thing if the server's not scanning when it should. (It populates on new instances, that connection thing was a fluke...)

[Fallenbagel]

Under both media and season status4k is set to 1 even though no content is 4K. Curious, could the Add4kStatusFields migration have caused something? Is 4K status altered by full scans?

Edit: "status4k" integer NOT NULL DEFAULT (1) You've assigned it true by default (./server/migration/1610370640747-Add4kStatusFields.ts)?

Could you link to the line and file? I'll have a look when I reach home

[OdinVex]

https://github.com/Fallenbagel/jellyseerr/blob/develop/server/migration/1610370640747-Add4kStatusFields.ts#L8
https://github.com/Fallenbagel/jellyseerr/blob/develop/server/migration/1610370640747-Add4kStatusFields.ts#L21

The migration assumes content is 4K because there was never a status before to differentiate. This is ran on every single new instance. I have no idea when Jellyseerr determines a content is 4K or not (when, such as full scan? old content that is scanned again?)

[Fallenbagel]

Admin, different browser, different instance, sonarr 4k configured but no 4k media

If no 4K media then why does it say 4K? Also, see the comment earlier I made on migrations. Curious why it defaults to 4k for migrations and why it doesn't correct it on full scan. Since migration is ran even on new installs that seems like a curious thing if the server's not scanning when it should. (It populates on new instances, that connection thing was a fluke...)

I meant. No 4k media in jellyfin. It's available in sonarr thats why

[Fallenbagel]

Under both media and season status4k is set to 1 even though no content is 4K. Curious, could the Add4kStatusFields migration have caused something? Is 4K status altered by full scans?

Edit: "status4k" integer NOT NULL DEFAULT (1) You've assigned it true by default (./server/migration/1610370640747-Add4kStatusFields.ts)?

About this, it came from overseerr:
https://github.com/sct/overseerr/blob/develop/server%2Fmigration%2F1610370640747-Add4kStatusFields.ts#L8

[OdinVex]

I meant. No 4k media in jellyfin. It's available in sonarr thats why

What does that have to do with the actual media available? It's supposed to be looking at Jellyfin, isn't it? Besides, my Sonarr doesn't have 4K at all.

About this, it came from overseerr:

No idea why they made an assumption like that...

Edit: So now I've just got to figure out when it detects 4K and how, then find out why it's not overwriting 4K status (or is and is setting it to true, incorrectly).

[Fallenbagel]

https://github.com/Fallenbagel/jellyseerr/blob/develop/server/migration/1610370640747-Add4kStatusFields.ts#L8
https://github.com/Fallenbagel/jellyseerr/blob/develop/server/migration/1610370640747-Add4kStatusFields.ts#L21

The migration assumes content is 4K because there was never a status before to differentiate. This is ran on every single new instance. I have no idea when Jellyseerr determines a content is 4K or not (when, such as full scan? old content that is scanned again?)

Jellyseerr determines if its 4k or not during the scan. The logic for it is there on the scanner job file:
https://github.com/Fallenbagel/jellyseerr/blob/develop/server%2Flib%2Fscanners%2Fjellyfin%2Findex.ts#L261-L357

[Fallenbagel]

I meant. No 4k media in jellyfin. It's available in sonarr thats why

What does that have to do with the actual media available? It's supposed to be looking at Jellyfin, isn't it? Besides, my Sonarr doesn't have 4K at all.

No. You can have availability from both sonarr and jellyfin. Seperately. That's what the enable scan option does.

So you can have a library added for 4k but not synced with jellyseerr but it's available on your 4k sonarr. Then it can appear

[OdinVex]

I was just looking at the Sonarr one, the 4K logic is convoluted for sure. Line 85->139. For the Jellyfin scanner, wouldn't season logic for 4K start at 237 rather than 261?

[Fallenbagel]

I was just looking at the Sonarr one, the 4K logic is convoluted for sure. Line 85->139. For the Jellyfin scanner, wouldn't season logic for 4K start at 237 rather than 261?

Oh yes that's where. Sorry I'm on mobile rn(gh app is a bit weird to select line). But yeah you get the gist. It's very convoluted on how we have to process jellyfin 4k media too. Despite jellyfin api having a is4K param in their get items api, that param isn't used anywhere (left out legacy code from emby) so we have to look at the resolutions to determine.

[OdinVex]

Oh yes that's where. Sorry I'm on mobile rn(gh app is a bit weird to select line).

All good, I know the quirks of mobile as well. :)

But yeah you get the gist. It's very convoluted on how we have to process jellyfin 4k media too. Despite jellyfin api having a is4K param in their get items api, that param isn't used anywhere (left out legacy code from emby) so we have to look at the resolutions to determine.

The width of all those episodes is 640... Every single item. I even started doing just a single file and it still thinks it is 4K.

Edit: Removed mention of Sonarr, its logic appears to be fine. The convoluted logic in the Jellyfin scanner will take some time, I'm unfamiliar with this language.

[OdinVex]

          const current4kSeasonAvailable = (
            media?.seasons.filter(
              (season) => season.status4k === MediaStatus.AVAILABLE
            ) ?? []
          ).length;

If that migration runs (which sets status4k true)...then this would be true, and it's constanting current4kSeasonAvailable...that's assuming status4k here reflects what was in the database?

existingSeason.status4k =
                  (this.enable4kShow && total4k >= season.episode_count) ||
                  existingSeason.status4k === MediaStatus.AVAILABLE

I think this is all stemming from migrations, but I could be wrong.

Edit: Removed unrelated 'status' which is apparently about availability rather than 4K-status.

Edit: This is all in the Jellyfin Scanner. I'm not familiar with Jellyseerr enough to draw a conclusion, plus I'm more of an Asm/C/C++ kind of person.

[Fallenbagel]

I'll have a look too in the weekends. Try to recreate your issue. If you wanna give it a go, from the top of my head I would do:

1. Check the api first see if the item that returns has 4k set.
2. Since it only seems to be messing up on issues page, maybe console log the item see what's up.

I'll also add a label to this issue so if there's someone else who can replicate this exact issue, they could look into it c:

[OdinVex]

Since it only seems to be messing up on issues page, maybe console log the item see what's up.

It only shows on the Issues page for Seasons (not Movies)....and yet the sqlite database shows "status4k=1" (for movies and seasons). I sometimes manually import content but it's never 4K. ¯\(ツ)/¯

Edit: I stopped the Jellyseerr instance and manually set status4k to 0 in media and seasons, started it back up (verified db was correctly adjusted and such, it's fine). Still shows 4K for Season Issues.

Edit: The only strings I can find for 'Play in 4K' are:

./src/components/IssueDetails/index.tsx:  play4konplex: 'Play in 4K on {mediaServerName}',
./src/i18n/locale/en.json:  "components.IssueDetails.play4konplex": "Play in 4K on {mediaServerName}",

Is the naming of Plex in the code that persistent? o.o I don't use Plex at all but apparently it's used for anything 4K. I took a peek at IssueDetail/index.tsx to see the logic behind displaying the button and it'll display if mediaUrl4k is set to anything non-null. The only locations that var is set is in ./server/entity/Media.ts, once if Plex or once if Jellyfin, specifically if jellyfinMediaId4k is set to non-null. Following that back around...to migrations which sets it to an empty string (empty but is not null, so maybe it triggers?) and also the Jellyfin Scanner/Availability Sync based on conditions. Haven't gone any further at the moment.

[Fallenbagel]

Since it only seems to be messing up on issues page, maybe console log the item see what's up.

It only shows on the Issues page for Seasons (not Movies)....and yet the sqlite database shows "status4k=1" (for movies and seasons). I sometimes manually import content but it's never 4K. ¯\(ツ)/¯

Edit: I stopped the Jellyseerr instance and manually set status4k to 0 in media and seasons, started it back up (verified db was correctly adjusted and such, it's fine). Still shows 4K for Season Issues.

Hmm. Well ill try to see if i can debug even though I can't recreate it 🤔

[OdinVex]

Sanity check of settings.json

{
"clientId": "REMOVED",
"vapidPrivate": "REMOVED",
"vapidPublic": "REMOVED",
"main": {
"apiKey": "REMOVED==",
"applicationTitle": "Jellyseerr",
"applicationUrl": "REMOVED",
"csrfProtection": false,
"cacheImages": true,
"defaultPermissions": 4194336,
"defaultQuotas": {
"movie": {
"quotaLimit": 0,
"quotaDays": 7
},
"tv": {
"quotaLimit": 0,
"quotaDays": 7
}
},
"hideAvailable": false,
"localLogin": false,
"newPlexLogin": true,
"region": "US",
"originalLanguage": "",
"trustProxy": false,
"mediaServerType": 2,
"partialRequestsEnabled": true,
"locale": "en"
},
"plex": {
"name": "",
"ip": "",
"port": 32400,
"useSsl": false,
"libraries": []
},
"jellyfin": {
"name": "",
"hostname": "REMOVED",
"externalHostname": "REMOVED",
"jellyfinForgotPasswordUrl": "",
"libraries": [
{
"id": "REMOVED",
"name": "Movies",
"enabled": true,
"type": "movie"
},
{
"id": "REMOVED",
"name": "Shows",
"enabled": true,
"type": "show"
}
],
"serverId": "REMOVED"
},
"tautulli": {},
"radarr": [
{
"name": "Radarr",
"hostname": "REMOVED",
"port": 7878,
"apiKey": "REMOVED",
"useSsl": false,
"baseUrl": "/Radarr",
"activeProfileId": 1,
"activeProfileName": "Any",
"activeDirectory": "/REMOVED",
"is4k": false,
"minimumAvailability": "released",
"tags": [],
"isDefault": true,
"externalUrl": "REMOVED/Radarr",
"syncEnabled": true,
"preventSearch": false,
"tagRequests": false,
"id": 0
}
],
"sonarr": [
{
"name": "Sonarr",
"hostname": "REMOVED",
"port": 8989,
"apiKey": "REMOVED",
"useSsl": false,
"baseUrl": "/Sonarr",
"activeProfileId": 1,
"activeLanguageProfileId": 1,
"activeProfileName": "Any",
"activeDirectory": "/REMOVED",
"activeAnimeProfileId": 1,
"activeAnimeLanguageProfileId": 1,
"activeAnimeProfileName": "Any",
"activeAnimeDirectory": "/REMOVED",
"tags": [],
"animeTags": [],
"is4k": false,
"isDefault": true,
"enableSeasonFolders": true,
"externalUrl": "REMOVED/Sonarr",
"syncEnabled": true,
"preventSearch": false,
"tagRequests": false,
"id": 0
}
],
"public": {
"initialized": true
},
"notifications": {
"agents": {
"email": {
"enabled": false,
"options": {
"userEmailRequired": false,
"emailFrom": "",
"smtpHost": "",
"smtpPort": 587,
"secure": false,
"ignoreTls": false,
"requireTls": false,
"allowSelfSigned": false,
"senderName": "Jellyseerr"
}
},
"discord": {
"enabled": false,
"types": 0,
"options": {
"webhookUrl": "",
"enableMentions": true
}
},
"lunasea": {
"enabled": false,
"types": 0,
"options": {
"webhookUrl": ""
}
},
"slack": {
"enabled": false,
"types": 0,
"options": {
"webhookUrl": ""
}
},
"telegram": {
"enabled": false,
"types": 0,
"options": {
"botAPI": "",
"chatId": "",
"sendSilently": false
}
},
"pushbullet": {
"enabled": false,
"types": 0,
"options": {
"accessToken": ""
}
},
"pushover": {
"enabled": false,
"types": 0,
"options": {
"accessToken": "",
"userToken": "",
"sound": ""
}
},
"webhook": {
"enabled": false,
"types": 0,
"options": {
"webhookUrl": "",
"jsonPayload": "REMOVED"
}
},
"webpush": {
"enabled": false,
"options": {}
},
"gotify": {
"enabled": true,
"types": 4062,
"options": {
"url": "REMOVED",
"token": "REMOVED"
}
}
}
},
"jobs": {
"plex-recently-added-scan": {
"schedule": "0 */5 * * * *"
},
"plex-full-scan": {
"schedule": "0 0 3 * * *"
},
"plex-watchlist-sync": {
"schedule": "0 */10 * * * *"
},
"radarr-scan": {
"schedule": "0 0 4 * * *"
},
"sonarr-scan": {
"schedule": "0 30 4 * * *"
},
"availability-sync": {
"schedule": "0 0 5 * * *"
},
"download-sync": {
"schedule": "0 * * * * *"
},
"download-sync-reset": {
"schedule": "0 0 1 * * *"
},
"jellyfin-recently-added-scan": {
"schedule": "0 */5 * * * *"
},
"jellyfin-full-scan": {
"schedule": "0 0 3 * * *"
},
"image-cache-cleanup": {
"schedule": "0 0 5 * * *"
},
"jellyfin-recently-added-sync": {
"schedule": "0 */5 * * * *"
},
"jellyfin-full-sync": {
"schedule": "0 0 3 * * *"
}
}
}

I can see 4K is disabled there, too.

[OdinVex]

I've traced the issue down to jellyfinMediaId4k being set for entries, so it's just been an absolute majority of Seasons, not all. Sometimes jellyfinMediaId4k matches jellyfinMediaId, sometimes it doesn't. But since none of my content is 4K it's baffling as to why jellyfinMediaId4k is getting set to begin with.

Edit: Removed brain-fart-quality analysis of code, not used to this language's style.

Edit: After NULL-ing jellyfinMediaId4k the Series are fine and show up correctly in Issues. I wonder why in other places they showed up as non-4K but in Issues they showed up as 4K.

Edit: I deleted the database and did a full rescan, filed the issue I was having...and it's back to saying 4K (all content...Seasons show as 4K in Issues, Movies don't). I'm just going to patch it out for now.

[Fallenbagel]

@OdinVex found the issue and fixed it c:

[OdinVex]

Is there a summary regarding why it would easily happen to me but not for you? Unfamiliar with the project's internals.

[Fallenbagel]

Is there a summary regarding why it would easily happen to me but not for you? Unfamiliar with the project's internals.

I was able to recreate it on a completely new instance. The issue was that the Id was being set irregardless of whether or not 4k content was present instead of checking and setting conditionally. Movies were already setting it conditionally, but shows weren't.

[Fallenbagel]

🎉 This issue has been resolved in version 1.8.0 🎉

The release is available on:

• v1.8.0
• GitHub release

Your semantic-release bot 📦🚀