Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bypasses not executing correctly #1134

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Fix bypasses not executing correctly #1134

merged 1 commit into from
Oct 1, 2023

Conversation

driedpampas
Copy link
Contributor

@driedpampas driedpampas commented Sep 29, 2023 •
edited
Loading

Fix(es):

  • fix: background code not executing
  • fix: code error preventing bypasses from executing
  • I made sure there are no unnecessary changes in the code;
  • Tested on Chromium (Includes Opera, Brave, Vivaldi, Edge, etc);
  • Tested on Firefox.

@github-actions
Copy link

github-actions bot commented Sep 29, 2023 •
edited
Loading

Download the artifacts for this pull request:

@driedpampas
Copy link
Contributor Author

I need testers cause I can't use my vm for too long and I don't have access to firefox nigtly or dev on host.

@driedpampas
Copy link
Contributor Author

once it's ready ill remove the main.yml change

@driedpampas
Copy link
Contributor Author

also with these changes two tabs will open when installing the extension but the consent one is thankfully the last one so it's focused

@driedpampas
Copy link
Contributor Author

should probably fix #1130

@undeadjess undeadjess mentioned this pull request Sep 30, 2023
Closed
@driedpampas driedpampas changed the title fix: bg code not executing correctly on firefox fix: extension not working Sep 30, 2023
@driedpampas driedpampas changed the title fix: extension not working fix: bg code not executing correctly on firefox Oct 1, 2023
@NotAProton NotAProton changed the title fix: bg code not executing correctly on firefox Fix bypasses not executing correctly Oct 1, 2023
@lostdusty lostdusty linked an issue Oct 1, 2023 that may be closed by this pull request
[Bug] FastForward MV3 on Firefox broken after AMO relisting #1130
Closed
@lostdusty lostdusty merged commit 50e7f7b into FastForwardTeam:main Oct 1, 2023
4 checks passed
@lostdusty lostdusty added the hacktoberfest-accepted For the hacktoberfest event label Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted For the hacktoberfest event
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] FastForward MV3 on Firefox broken after AMO relisting
2 participants
@driedpampas @lostdusty