Add quotes for all values listed in https://yaml.org/type/bool.html #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeSmaha
added a commit
to GuillaumeSmaha/jackson-dataformats-text
that referenced
this pull request
Jun 28, 2019
Fix FasterXML#129 - Backport of FasterXML#137 for 2.9
GuillaumeSmaha
added a commit
to GuillaumeSmaha/jackson-dataformats-text
that referenced
this pull request
Jun 28, 2019
Fix FasterXML#129 - Backport of FasterXML#137 for 2.9
GuillaumeSmaha
added a commit
to GuillaumeSmaha/jackson-dataformats-text
that referenced
this pull request
Jun 28, 2019
Fix FasterXML#129 - Backport of FasterXML#137 for 2.9
GuillaumeSmaha
added a commit
to GuillaumeSmaha/openapi-generator
that referenced
this pull request
Jun 28, 2019
quotes around string value and fix compatibility with parser using yaml 1.1. Fix OpenAPITools#3196 In spec 1.1, some words without quotes can be implicitly converted to a boolean like "yes" or "on" (See https://yaml.org/type/bool.html) In v3.core.util.Yaml with MINIMIZE_QUOTES enabled, the formatter created a YAML but forget to protect some words. PRs are created to fix this in the formatter: - FasterXML/jackson-dataformats-text#137 - FasterXML/jackson-dataformats-text#138 Until the PRs will be merged and released, this patch fix it by re-adding quotes.
|
Quick question: have I already asked for a CLA? If not (this is your first contribution), I would need it (but just once, not for further contributions). Document is here: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and the usual way is to print, fill & sign, scan, email to Thank you in advance! |
|
@cowtowncoder I filled the CLA and sent it by email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #129