Skip to content

ci: tidy conditional checks #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

ci: tidy conditional checks #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cebde2
ci: tidy conditional checks
Fdawgs Sep 23, 2025
eca65ee
style: tidy conditional checks
Fdawgs Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ permissions:
jobs:
dependency-review:
name: Dependency Review
if: >
github.event.pull_request.draft == false &&
github.event_name == 'pull_request'
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
permissions:
contents: read
Expand All @@ -46,7 +44,6 @@ jobs:

lint:
name: Lint Code
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
permissions:
contents: read
Expand Down Expand Up @@ -83,8 +80,8 @@ jobs:
commit-lint:
name: Lint Commit Messages
if: >
github.event.pull_request.draft == false &&
github.actor != 'dependabot[bot]'
github.event_name == 'push' ||
(github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]')
runs-on: ubuntu-latest
permissions:
contents: read
Expand All @@ -102,7 +99,6 @@ jobs:

unit-tests:
name: Unit Tests
if: github.event.pull_request.draft == false
strategy:
matrix:
node-version: [20, 22, 24]
Expand Down Expand Up @@ -139,9 +135,7 @@ jobs:
coverage:
name: Aggregate Coverage Calculations
needs: unit-tests
if: >
github.event.pull_request.draft == false &&
github.repository == 'Fdawgs/fastify-json-to-xml'
if: github.repository == 'Fdawgs/fastify-json-to-xml'
runs-on: ubuntu-latest
permissions:
contents: read
Expand All @@ -154,10 +148,9 @@ jobs:

automerge:
name: Automerge Dependabot PRs
needs: unit-tests
needs: [dependency-review, lint, unit-tests]
if: >
github.event_name == 'pull_request' &&
github.event.pull_request.draft == false &&
github.event.pull_request.head.repo.full_name == github.repository &&
github.event.pull_request.user.login == 'dependabot[bot]'
runs-on: ubuntu-latest
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ permissions:
jobs:
build:
name: CodeQL Analysis
if: github.event.pull_request.draft == false
strategy:
matrix:
languages: ["actions", "javascript-typescript"]
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/link-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ permissions:
jobs:
link-check:
name: Link Check
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
permissions:
contents: read
Expand Down
Loading