Skip to content

test(index): use describe.each()() for duplicate test suites #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2023
Merged

test(index): use describe.each()() for duplicate test suites #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 31 additions & 37 deletions src/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,55 +87,49 @@ describe("JSON-To-XML plugin", () => {
{
testName:
"'application/xml' as only value in accept HTTP request header",
request: {
headers: {
accept: "application/xml",
},
headers: {
accept: "application/xml",
},
},
{
testName:
"'application/xml' before 'application/json' in accept HTTP request header",
request: {
headers: {
accept: "application/xml, application/json",
},
headers: {
accept: "application/xml, application/json",
},
},
];
xmlTests.forEach((testObject) => {
describe(`${testObject.testName}`, () => {
test("Should return HTTP status code 500 due to invalid XML characters", async () => {
const response = await server.inject({
method: "GET",
url: "/no-replace",
headers: testObject.request.headers,
});

expect(response.payload).toBe(
'<?xml version="1.0" encoding="UTF-8"?><response><statusCode>500</statusCode><error>Internal Server Error</error><message>in XML document > element "response": element name "$test-key" should not contain characters not allowed in XML names</message></response>'
);
expect(response.headers["content-type"]).toBe(
"application/xml; charset=utf-8"
);
expect(response.statusCode).toBe(500);
describe.each(xmlTests)("$testName", ({ headers }) => {
test("Should return HTTP status code 500 due to invalid XML characters", async () => {
const response = await server.inject({
method: "GET",
url: "/no-replace",
headers,
});

test("Should return XML payload with invalid XML characters replaced", async () => {
const response = await server.inject({
method: "GET",
url: "/replace",
headers: testObject.request.headers,
});
expect(response.payload).toBe(
'<?xml version="1.0" encoding="UTF-8"?><response><statusCode>500</statusCode><error>Internal Server Error</error><message>in XML document > element "response": element name "$test-key" should not contain characters not allowed in XML names</message></response>'
);
expect(response.headers["content-type"]).toBe(
"application/xml; charset=utf-8"
);
expect(response.statusCode).toBe(500);
});

expect(response.payload).toBe(
'<?xml version="1.0" encoding="UTF-8"?><response><test-key>test-value</test-key><�test-key>test-value</�test-key></response>'
);
expect(response.headers["content-type"]).toBe(
"application/xml; charset=utf-8"
);
expect(response.statusCode).toBe(200);
test("Should return XML payload with invalid XML characters replaced", async () => {
const response = await server.inject({
method: "GET",
url: "/replace",
headers,
});

expect(response.payload).toBe(
'<?xml version="1.0" encoding="UTF-8"?><response><test-key>test-value</test-key><�test-key>test-value</�test-key></response>'
);
expect(response.headers["content-type"]).toBe(
"application/xml; charset=utf-8"
);
expect(response.statusCode).toBe(200);
});
});
});
Expand Down