Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this normal behavior for "pxcltr" #82

Closed
Cactusolo opened this issue May 14, 2018 · 14 comments
Closed

Is this normal behavior for "pxcltr" #82

Cactusolo opened this issue May 14, 2018 · 14 comments

Comments

@Cactusolo
Copy link

Hi,

I was told that "pxcltr" is meant to remove 'knuckles' (i.e. 2-degree nodes), node annotations, etc, to keep a plain format.

However, I used cmd like:
pxcltr -l -t Coweeta_ottid_nw_rename.tre
and
pxcltr -t Coweeta_ottid_nw_rename.tre

But the results are the same, still keeping some internal labels, eg:

...

|| ++ mrcaott784ott8526
|| || +---------------------------+ Asplenium montanum
|| ||
|| || +----------------------------+ Polypodium virginianum
|| || |
|| |+-++mrcaott8526ott9790---------+ Polystichum acrostichoides
|| | ||
|| ++ mrcaott784ott5078tt21809------+ Dryopteris intermedia
|| || | ++ mrcaott49169ott87323
|| || +-++mrcaott21809ott49169----+ Dryopteris goldiana
|| || |
|| +-+|mrcaott784ott11449-------------+ Dryopteris marginalis
|| | ||
|| | |+-------------------------------+ Adiantum pedatum
|| | |
|| | |+-------------------------------+ Pteridium aquilinum
|| ++ ott56622106
|| || +-------------------------------+ Dennstaedtia punctilobula
|| ||
|| || +--------------------------------+ Osmunda cinnamomea
|| |+-+ ott41629
|+-+ mrcaott784ott3223-----------------+ Osmunda claytoniana
| |
| | +--------------------------------+ Botrychium alabamense
| |+-+ mrcaott33066ott113196
| ++ mrcaott33066ott756444------------+ Botrychium dissectum
| |
| +----------------------------------+ Botrychium virginianum
|
| +-----------------------------------+ Selaginella apoda
|+-+ mrcaott3661ott18736
|| +-----------------------------------+ Isoetes engelmannii
||
++ ott6133720--------------------------+ Lycopodium clavatum
| |
+---ott719013-------------------------+ Lycopodium lucidulum
|
+-----------------------------------+ Lycopodium flabelliforme

Please let me know if you need tree file.

Thanks!

@josephwb
Copy link
Member

Sorry but that is unreadable! Do you have the newicks for both input and output?

@Cactusolo
Copy link
Author

Cactusolo commented May 14, 2018 via email

@josephwb
Copy link
Member

As far as I can see all knuckles are removed.

$ pxlstr -t phy.tre 
tree #: 0
rooted: false
binary: false
nterminal: 589
ninternal: 1943
branch lengths: false
rttipvar: NA
treelength: NA
ultrametric: NA
rootheight: NA

$pxlstr -t clean.tre 
tree #: 0
rooted: true
binary: false
nterminal: 589
ninternal: 435
branch lengths: false
rttipvar: NA
treelength: NA
ultrametric: NA
rootheight: NA

As for the node names: phyx treats names and annotations differently. I may not have implemented this fully. Should be a quick fix.

@Cactusolo
Copy link
Author

Cactusolo commented May 14, 2018 via email

@josephwb
Copy link
Member

Yup this was a loose end #73 (comment). Will fix it this evening. Sorry about the trouble.

@josephwb
Copy link
Member

Actually I will get to this tomorrow.

@Cactusolo
Copy link
Author

Cactusolo commented May 14, 2018 via email

@josephwb
Copy link
Member

Oof. Should be working with this 940b927.

@josephwb
Copy link
Member

@Cactusolo please close if this works for you.

@Cactusolo
Copy link
Author

Cactusolo commented May 15, 2018 via email

@Cactusolo
Copy link
Author

Cactusolo commented May 15, 2018 via email

@josephwb
Copy link
Member

Got it. Although most phyx programs are so lightweight and only run on a single core that I don't see any advantage in putting it on a cluster. But cool that you are!

@Cactusolo
Copy link
Author

Thanks man! It works perfectly! 💯 👍

PS, I did most of my work remotely. Though I have home-brewed phyx on my mac, which conveniently not with me today :)

@Cactusolo
Copy link
Author

Cactusolo commented May 16, 2018

@josephwb I close this issue now, thanks for all the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants