Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync and update golangci-lint configurations #1205

Merged
merged 29 commits into from
Nov 9, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 3, 2022

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 3, 2022
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Oct 3, 2022
@AlekSi AlekSi self-assigned this Oct 3, 2022
@vercel
Copy link

vercel bot commented Oct 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Nov 8, 2022 at 11:52AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 3, 2022 18:45 Inactive
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #1205 (3c01eda) into main (0b83d17) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
+ Coverage   67.21%   67.23%   +0.02%     
==========================================
  Files         279      279              
  Lines       13358    13358              
==========================================
+ Hits         8978     8981       +3     
+ Misses       3450     3447       -3     
  Partials      930      930              
Impacted Files Coverage Δ
internal/handlers/pg/pgdb/settings.go 41.35% <0.00%> (-4.52%) ⬇️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 85.23% <0.00%> (+0.57%) ⬆️
internal/handlers/tigris/tigrisdb/databases.go 74.35% <0.00%> (+7.69%) ⬆️
internal/handlers/tigris/tigrisdb/errors.go 52.17% <0.00%> (+13.04%) ⬆️
Flag Coverage Δ
integration 63.33% <ø> (+0.02%) ⬆️
mongodb 14.03% <ø> (-0.04%) ⬇️
pg 52.55% <ø> (-0.03%) ⬇️
tigris 35.20% <ø> (+0.02%) ⬆️
unit 26.02% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview October 4, 2022 07:07 Inactive
@vercel vercel bot temporarily deployed to Preview October 5, 2022 21:29 Inactive
@vercel vercel bot temporarily deployed to Preview October 6, 2022 07:53 Inactive
@vercel vercel bot temporarily deployed to Preview October 11, 2022 18:28 Inactive
@vercel vercel bot temporarily deployed to Preview October 12, 2022 07:05 Inactive
@vercel vercel bot temporarily deployed to Preview October 12, 2022 07:09 Inactive
@vercel vercel bot temporarily deployed to Preview October 12, 2022 07:44 Inactive
@AlekSi AlekSi modified the milestones: v0.6.0 Alpha, v0.6.1 Oct 26, 2022
# Conflicts:
#	.golangci.yml
#	integration/Taskfile.yml
@vercel vercel bot temporarily deployed to Preview November 6, 2022 12:58 Inactive
@vercel vercel bot temporarily deployed to Preview November 6, 2022 12:59 Inactive
@AlekSi
Copy link
Member Author

AlekSi commented Nov 7, 2022

There is a bug, will fix after release

@vercel vercel bot temporarily deployed to Preview November 7, 2022 10:34 Inactive
@vercel vercel bot temporarily deployed to Preview November 7, 2022 10:51 Inactive
@vercel vercel bot temporarily deployed to Preview November 7, 2022 11:31 Inactive
@AlekSi AlekSi requested a review from chilagrow November 7, 2022 11:36
@AlekSi AlekSi requested a review from noisersup November 7, 2022 11:36
@AlekSi AlekSi removed the do not merge PRs that should not be merged label Nov 7, 2022
@AlekSi AlekSi enabled auto-merge (squash) November 7, 2022 11:37
@vercel vercel bot temporarily deployed to Preview November 7, 2022 11:38 Inactive
@vercel vercel bot temporarily deployed to Preview November 8, 2022 02:54 Inactive
@vercel vercel bot temporarily deployed to Preview November 8, 2022 08:54 Inactive
@AlekSi AlekSi added the do not merge PRs that should not be merged label Nov 8, 2022
@vercel vercel bot temporarily deployed to Preview November 8, 2022 09:14 Inactive
@vercel vercel bot temporarily deployed to Preview November 8, 2022 11:52 Inactive
@AlekSi AlekSi removed the do not merge PRs that should not be merged label Nov 9, 2022
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 4042eca into FerretDB:main Nov 9, 2022
@AlekSi AlekSi deleted the golangci-lint branch November 9, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants