Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cancel in-progress CI runs #1378

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Do not cancel in-progress CI runs #1378

merged 3 commits into from
Nov 8, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 7, 2022

Description

That should make restarts easier.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

That should make restarts easier.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 7, 2022
@AlekSi AlekSi added this to the v0.6.2 milestone Nov 7, 2022
@AlekSi AlekSi self-assigned this Nov 7, 2022
@vercel
Copy link

vercel bot commented Nov 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Nov 8, 2022 at 8:56AM (UTC)

@AlekSi AlekSi requested review from a team, w84thesun, rumyantseva, chilagrow and noisersup and removed request for a team November 7, 2022 12:54
@AlekSi AlekSi enabled auto-merge (squash) November 7, 2022 12:54
@vercel vercel bot temporarily deployed to Preview November 7, 2022 12:55 Inactive
@vercel vercel bot temporarily deployed to Preview November 8, 2022 02:51 Inactive
@vercel vercel bot temporarily deployed to Preview November 8, 2022 08:56 Inactive
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #1378 (ab3a32b) into main (8168644) will increase coverage by 19.88%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1378       +/-   ##
===========================================
+ Coverage   47.28%   67.17%   +19.88%     
===========================================
  Files         279      279               
  Lines       13233    13233               
===========================================
+ Hits         6257     8889     +2632     
+ Misses       6228     3409     -2819     
- Partials      748      935      +187     
Impacted Files Coverage Δ
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/clientconn/conn.go 44.70% <0.00%> (+0.68%) ⬆️
integration/helpers.go 87.23% <0.00%> (+1.06%) ⬆️
internal/handlers/pg/pgdb/collections.go 50.00% <0.00%> (+2.27%) ⬆️
internal/types/document_validation.go 96.15% <0.00%> (+2.56%) ⬆️
internal/handlers/pg/pgdb/tables.go 64.70% <0.00%> (+2.94%) ⬆️
internal/handlers/pg/pgdb/databases.go 55.00% <0.00%> (+5.00%) ⬆️
internal/handlers/pg/pgdb/settings.go 45.86% <0.00%> (+6.76%) ⬆️
internal/handlers/common/limit.go 75.00% <0.00%> (+8.33%) ⬆️
internal/types/document.go 87.77% <0.00%> (+10.00%) ⬆️
... and 51 more
Flag Coverage Δ
integration 63.25% <ø> (+25.34%) ⬆️
mongodb 14.18% <ø> (-0.01%) ⬇️
pg 52.38% <ø> (?)
tigris 35.28% <ø> (-0.03%) ⬇️
unit 26.26% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi merged commit cd6e7c4 into FerretDB:main Nov 8, 2022
@AlekSi AlekSi deleted the cancel branch November 8, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants