Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make telemetry page visible in documentation sidebar #1393

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

Fashander
Copy link
Member

Description

Closes #1392 .

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Fashander Fashander added the documentation Something user-visible is badly or not documented label Nov 10, 2022
@Fashander Fashander requested review from a team November 10, 2022 14:38
@Fashander Fashander self-assigned this Nov 10, 2022
@vercel
Copy link

vercel bot commented Nov 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Nov 15, 2022 at 9:48AM (UTC)

@vercel vercel bot temporarily deployed to Preview November 10, 2022 14:42 Inactive
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #1393 (2c2c5c4) into main (dab245d) will increase coverage by 7.69%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1393      +/-   ##
==========================================
+ Coverage   59.69%   67.38%   +7.69%     
==========================================
  Files         279      279              
  Lines       13353    13353              
==========================================
+ Hits         7971     8998    +1027     
+ Misses       4586     3424    -1162     
- Partials      796      931     +135     
Impacted Files Coverage Δ
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 84.65% <0.00%> (ø)
integration/helpers.go 87.62% <0.00%> (+0.51%) ⬆️
internal/handlers/common/params.go 95.52% <0.00%> (+1.62%) ⬆️
integration/setup/common.go 93.89% <0.00%> (+4.58%) ⬆️
internal/handlers/tigris/tjson/schema.go 79.73% <0.00%> (+5.22%) ⬆️
integration/setup/setup.go 87.03% <0.00%> (+5.55%) ⬆️
internal/handlers/tigris/tigrisdb/collections.go 60.00% <0.00%> (+5.71%) ⬆️
integration/shareddata/shareddata.go 85.33% <0.00%> (+8.00%) ⬆️
integration/setup/setup_compat.go 86.61% <0.00%> (+11.02%) ⬆️
... and 33 more
Flag Coverage Δ
integration 63.49% <ø> (+10.82%) ⬆️
mongodb 14.07% <ø> (-0.03%) ⬇️
pg 52.58% <ø> (-0.03%) ⬇️
tigris 35.34% <ø> (?)
unit 26.07% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview November 14, 2022 10:47 Inactive
@Fashander Fashander requested review from a team, w84thesun, chilagrow, noisersup and b1ron and removed request for a team November 15, 2022 08:11
@noisersup noisersup self-requested a review November 15, 2022 09:48
@vercel vercel bot temporarily deployed to Preview November 15, 2022 09:48 Inactive
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one thing aside:

|Sprint |❌ PR for project "Engineering" has "Sprint" field unset; it should be set. |

@AlekSi AlekSi enabled auto-merge (squash) November 15, 2022 10:33
@AlekSi AlekSi merged commit 42a7559 into FerretDB:main Nov 15, 2022
w84thesun pushed a commit to w84thesun/FerretDB that referenced this pull request Nov 15, 2022
@AlekSi AlekSi added this to the v0.6.2 milestone Nov 21, 2022
@Fashander Fashander deleted the Reorder-telemetry-page branch February 1, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder telemetry page in documentation
4 participants