Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues for the Unix listener #1397

Merged
merged 39 commits into from
Nov 18, 2022
Merged

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Nov 14, 2022

Description

Closes #1295.

  • test-integration-pg runs on unix socket, -target-unix-socket is already specified in Taskfile.yml.
  • We don't support unix socket on windows, windows always uses TCP.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/bug Some user-visible feature works incorrectly label Nov 14, 2022
@chilagrow chilagrow self-assigned this Nov 14, 2022
@vercel
Copy link

vercel bot commented Nov 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Nov 18, 2022 at 5:35PM (UTC)

@vercel vercel bot temporarily deployed to Preview November 14, 2022 06:45 Inactive
@chilagrow chilagrow changed the title Fix issues for the Unix listener Fix issues for the Unix listener Nov 14, 2022
@vercel vercel bot temporarily deployed to Preview November 15, 2022 03:12 Inactive
@vercel vercel bot temporarily deployed to Preview November 16, 2022 09:19 Inactive
@vercel vercel bot temporarily deployed to Preview November 16, 2022 09:31 Inactive
@vercel vercel bot temporarily deployed to Preview November 17, 2022 01:54 Inactive
@vercel vercel bot temporarily deployed to Preview November 17, 2022 02:31 Inactive
@vercel vercel bot temporarily deployed to Preview November 17, 2022 02:35 Inactive
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #1397 (4753eb9) into main (1a1885e) will decrease coverage by 0.17%.
The diff coverage is 87.91%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1397      +/-   ##
==========================================
- Coverage   67.93%   67.75%   -0.18%     
==========================================
  Files         279      279              
  Lines       13500    13540      +40     
==========================================
+ Hits         9171     9174       +3     
- Misses       3411     3436      +25     
- Partials      918      930      +12     
Impacted Files Coverage Δ
internal/handlers/pg/msg_explain.go 58.33% <0.00%> (-3.64%) ⬇️
integration/setup/setup_compat.go 84.84% <75.00%> (-1.77%) ⬇️
integration/setup/common_unix.go 85.29% <84.84%> (-14.71%) ⬇️
integration/setup/setup.go 87.17% <93.33%> (+0.14%) ⬆️
integration/setup/common.go 93.84% <100.00%> (-0.10%) ⬇️
internal/handlers/tigris/msg_listdatabases.go 45.07% <0.00%> (-5.64%) ⬇️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 84.65% <0.00%> (-1.73%) ⬇️
... and 2 more
Flag Coverage Δ
integration 63.99% <87.91%> (-0.02%) ⬇️
mongodb 14.09% <28.57%> (-0.13%) ⬇️
pg 53.14% <83.51%> (-0.01%) ⬇️
tigris 36.24% <64.83%> (+0.04%) ⬆️
unit 26.41% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview November 17, 2022 03:11 Inactive
@vercel vercel bot temporarily deployed to Preview November 17, 2022 03:19 Inactive
@vercel vercel bot temporarily deployed to Preview November 17, 2022 03:44 Inactive
@vercel vercel bot temporarily deployed to Preview November 17, 2022 03:59 Inactive
@vercel vercel bot temporarily deployed to Preview November 18, 2022 07:16 Inactive
@vercel vercel bot temporarily deployed to Preview November 18, 2022 07:45 Inactive
@vercel vercel bot temporarily deployed to Preview November 18, 2022 09:13 Inactive
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it on Windows, looks like everything is working fine. A typo fix is needed.

integration/commands_administration_test.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview November 18, 2022 09:29 Inactive
@vercel
Copy link

vercel bot commented Nov 18, 2022

Deployment failed with the following error:

Resource is limited - try again in 52 minutes (more than 100, code: "api-deployments-free-per-day").

@vercel vercel bot temporarily deployed to Preview November 18, 2022 12:29 Inactive
@vercel vercel bot temporarily deployed to Preview November 18, 2022 17:17 Inactive
rumyantseva
rumyantseva previously approved these changes Nov 18, 2022
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tests pass on my env.

@vercel vercel bot temporarily deployed to Preview November 18, 2022 17:35 Inactive
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit 4f53809 into FerretDB:main Nov 18, 2022
@AlekSi AlekSi added this to the v0.6.2 milestone Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/bug Some user-visible feature works incorrectly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issues for the Unix listener
4 participants