Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lowercase directory names #1408

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Use lowercase directory names #1408

merged 2 commits into from
Nov 16, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 16, 2022

Description

For consistency.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Nov 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 11:31AM (UTC)

@AlekSi AlekSi changed the title Commands Use lowercase directory names Nov 16, 2022
@AlekSi AlekSi added this to the v0.6.2 milestone Nov 16, 2022
@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 16, 2022
@AlekSi AlekSi self-assigned this Nov 16, 2022
@AlekSi AlekSi marked this pull request as ready for review November 16, 2022 11:19
@AlekSi AlekSi requested review from a team, Fashander, w84thesun, rumyantseva, chilagrow and noisersup and removed request for a team November 16, 2022 11:19
w84thesun
w84thesun previously approved these changes Nov 16, 2022
@AlekSi AlekSi marked this pull request as draft November 16, 2022 11:20
@AlekSi AlekSi added the do not merge PRs that should not be merged label Nov 16, 2022
@AlekSi
Copy link
Member Author

AlekSi commented Nov 16, 2022

Sorry, it is broken, one moment

Fashander
Fashander previously approved these changes Nov 16, 2022
@vercel vercel bot temporarily deployed to Preview November 16, 2022 11:21 Inactive
@AlekSi AlekSi dismissed stale reviews from Fashander and w84thesun via 10e6486 November 16, 2022 11:24
@AlekSi AlekSi marked this pull request as ready for review November 16, 2022 11:25
@AlekSi AlekSi removed the do not merge PRs that should not be merged label Nov 16, 2022
@AlekSi AlekSi requested a review from a team November 16, 2022 11:25
@AlekSi AlekSi requested a review from a team November 16, 2022 11:25
@AlekSi AlekSi enabled auto-merge (squash) November 16, 2022 11:25
@vercel vercel bot temporarily deployed to Preview November 16, 2022 11:26 Inactive
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #1408 (4445f0d) into main (a30ba77) will decrease coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1408      +/-   ##
==========================================
- Coverage   67.40%   67.31%   -0.10%     
==========================================
  Files         279      279              
  Lines       13353    13353              
==========================================
- Hits         9001     8988      -13     
- Misses       3426     3441      +15     
+ Partials      926      924       -2     
Impacted Files Coverage Δ
internal/handlers/tigris/tigrisdb/errors.go 32.14% <0.00%> (-10.72%) ⬇️
internal/handlers/tigris/msg_create.go 67.60% <0.00%> (-7.05%) ⬇️
internal/handlers/tigris/tigrisdb/collections.go 54.28% <0.00%> (-5.72%) ⬇️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 84.65% <0.00%> (ø)
Flag Coverage Δ
integration 63.41% <ø> (-0.10%) ⬇️
mongodb 14.03% <ø> (-0.03%) ⬇️
pg 52.63% <ø> (-0.03%) ⬇️
tigris 35.22% <ø> (-0.10%) ⬇️
unit 26.07% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview November 16, 2022 11:31 Inactive
@AlekSi AlekSi merged commit c4b8343 into FerretDB:main Nov 16, 2022
@AlekSi AlekSi deleted the commands branch November 16, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants