Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor telemetry cleanup #1446

Merged
merged 6 commits into from
Nov 17, 2022
Merged

Minor telemetry cleanup #1446

merged 6 commits into from
Nov 17, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Nov 16, 2022

Description

Refs #1323.
Refs #1443.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Nov 16, 2022
@AlekSi AlekSi added this to the v0.6.2 milestone Nov 16, 2022
@AlekSi AlekSi self-assigned this Nov 16, 2022
@AlekSi AlekSi requested a review from a team as a code owner November 16, 2022 16:15
@vercel
Copy link

vercel bot commented Nov 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 5:55PM (UTC)

@AlekSi AlekSi added the do not merge PRs that should not be merged label Nov 16, 2022
@AlekSi AlekSi enabled auto-merge (squash) November 16, 2022 16:16
@vercel vercel bot temporarily deployed to Preview November 16, 2022 16:16 Inactive
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #1446 (c2db90a) into main (ca4a67c) will increase coverage by 0.07%.
The diff coverage is 93.10%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1446      +/-   ##
==========================================
+ Coverage   67.43%   67.51%   +0.07%     
==========================================
  Files         279      279              
  Lines       13408    13409       +1     
==========================================
+ Hits         9042     9053      +11     
+ Misses       3440     3427      -13     
- Partials      926      929       +3     
Impacted Files Coverage Δ
internal/util/state/metrics.go 88.23% <ø> (ø)
internal/util/telemetry/reporter.go 6.41% <83.33%> (+1.92%) ⬆️
internal/util/telemetry/telemetry.go 90.62% <95.00%> (+0.14%) ⬆️
internal/handlers/common/serverstatus.go 88.23% <100.00%> (-0.45%) ⬇️
internal/handlers/pg/msg_getlog.go 81.44% <100.00%> (+0.19%) ⬆️
internal/handlers/tigris/msg_getlog.go 78.78% <100.00%> (+0.21%) ⬆️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 84.65% <0.00%> (ø)
internal/handlers/tigris/tigrisdb/collections.go 60.00% <0.00%> (+5.71%) ⬆️
internal/handlers/tigris/msg_create.go 74.64% <0.00%> (+7.04%) ⬆️
... and 1 more
Flag Coverage Δ
integration 63.50% <100.00%> (+0.05%) ⬆️
mongodb 14.04% <0.00%> (-0.01%) ⬇️
pg 52.68% <66.66%> (-0.04%) ⬇️
tigris 35.48% <66.66%> (+0.04%) ⬆️
unit 26.17% <82.75%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improvements! 🙂 From this point I can see that there were couple of places when the code from last PR could be more consistent to the whole codebase. I just left one comment to discuss

internal/util/telemetry/reporter.go Show resolved Hide resolved
internal/util/telemetry/telemetry.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview November 16, 2022 16:44 Inactive
noisersup
noisersup previously approved these changes Nov 16, 2022
@vercel vercel bot temporarily deployed to Preview November 16, 2022 16:50 Inactive
@AlekSi AlekSi removed the do not merge PRs that should not be merged label Nov 16, 2022
@AlekSi AlekSi requested review from chilagrow and removed request for a team November 16, 2022 16:52
@vercel vercel bot temporarily deployed to Preview November 16, 2022 16:56 Inactive
@vercel vercel bot temporarily deployed to Preview November 16, 2022 17:55 Inactive
@AlekSi AlekSi merged commit c6d9b6b into FerretDB:main Nov 17, 2022
@AlekSi AlekSi deleted the cleanup branch November 17, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants