Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow - in database names #1582

Merged

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Nov 28, 2022

Description

Closes #1321.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added the code/enhancement Some user-visible feature could work better label Nov 28, 2022
@w84thesun w84thesun added this to the v0.7.0 milestone Nov 28, 2022
@w84thesun w84thesun self-assigned this Nov 28, 2022
@vercel
Copy link

vercel bot commented Nov 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Nov 28, 2022 at 5:55PM (UTC)

@vercel vercel bot temporarily deployed to Preview November 28, 2022 11:16 Inactive
@vercel vercel bot temporarily deployed to Preview November 28, 2022 14:17 Inactive
@vercel vercel bot temporarily deployed to Preview November 28, 2022 14:29 Inactive
@vercel vercel bot temporarily deployed to Preview November 28, 2022 14:57 Inactive
@vercel vercel bot temporarily deployed to Preview November 28, 2022 15:12 Inactive
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #1582 (e50e4fa) into main (278ac31) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1582      +/-   ##
==========================================
- Coverage   67.60%   67.58%   -0.03%     
==========================================
  Files         284      284              
  Lines       13782    13782              
==========================================
- Hits         9317     9314       -3     
- Misses       3506     3508       +2     
- Partials      959      960       +1     
Impacted Files Coverage Δ
internal/handlers/pg/pgdb/databases.go 65.00% <ø> (ø)
internal/util/testutil/db.go 87.30% <100.00%> (ø)
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 84.56% <0.00%> (ø)
Flag Coverage Δ
integration 63.50% <100.00%> (-0.03%) ⬇️
mongodb 13.92% <100.00%> (-0.03%) ⬇️
pg 52.23% <100.00%> (-0.03%) ⬇️
tigris 36.80% <100.00%> (-0.01%) ⬇️
unit 26.83% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview November 28, 2022 16:18 Inactive
@vercel vercel bot temporarily deployed to Preview November 28, 2022 16:27 Inactive
@vercel vercel bot temporarily deployed to Preview November 28, 2022 17:06 Inactive
@w84thesun w84thesun requested review from a team, rumyantseva, chilagrow and noisersup and removed request for a team November 28, 2022 17:16
@w84thesun w84thesun marked this pull request as ready for review November 28, 2022 17:16
@w84thesun w84thesun requested a review from a team November 28, 2022 17:16
@w84thesun w84thesun requested a review from a team as a code owner November 28, 2022 17:16
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I see you also have a dance tests' draft.

@vercel vercel bot temporarily deployed to Preview November 28, 2022 17:55 Inactive
@w84thesun w84thesun merged commit babb750 into FerretDB:main Nov 28, 2022
@w84thesun w84thesun deleted the issue-1321-allow-dashes-in-database-names branch November 28, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow dashes (-) in database names
3 participants