Add findandmodify to the common.Commands map

[b1ron]

Description

Closes #1727.

Readiness checklist

• I added unit tests for new functionality or bug fixes.
• I added integration tests for new functionality or bug fixes.
• I added compatibility tests for new functionality or bug fixes.
• I made spot refactorings.
• I updated user documentation.
• I ran task all, and it passed.
• I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
• I checked comments rendering with task godocs.
• I ensured that the title is good enough for the changelog.
• (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
• I marked all done items in this checklist.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
ferret-db	✅ Ready (Inspect)	Visit Preview	Jan 2, 2023 at 0:48AM (UTC)

[codecov]

Codecov Report

Merging #1730 (29cbfc8) into main (c323091) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1730      +/-   ##
==========================================
- Coverage   69.07%   69.01%   -0.07%     
==========================================
  Files         301      301              
  Lines       14297    14303       +6     
==========================================
- Hits         9876     9871       -5     
- Misses       3493     3496       +3     
- Partials      928      936       +8     

Impacted Files	Coverage Δ
internal/handlers/common/msg_listcommands.go	100.00% <100.00%> (ø)
internal/handlers/pg/pgdb/collections.go	64.56% <0.00%> (-4.73%)	⬇️
build/version/version.go	63.01% <0.00%> (-4.11%)	⬇️
internal/handlers/pg/pgdb/database_metadata.go	81.92% <0.00%> (-3.62%)	⬇️
internal/clientconn/conn.go	44.34% <0.00%> (-2.61%)	⬇️
internal/clientconn/listener.go	77.84% <0.00%> (-1.71%)	⬇️
internal/handlers/common/filter.go	84.86% <0.00%> (ø)
internal/handlers/tigris/tigrisdb/collections.go	66.66% <0.00%> (+4.76%)	⬆️
internal/handlers/tigris/msg_create.go	74.64% <0.00%> (+7.04%)	⬆️
... and 1 more

Flag	Coverage Δ
integration	64.40% <100.00%> (+<0.01%)	⬆️
mongodb	5.97% <0.00%> (-0.01%)	⬇️
pg	52.98% <100.00%> (-0.09%)	⬇️
tigris	38.92% <100.00%> (+0.11%)	⬆️
unit	28.95% <0.00%> (-0.24%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[noisersup]

LGTM!

[b1ron]

@noisersup I pushed another commit to clean up a bit. PTAL.

[AlekSi]

Let's also update TestCommandsDiagnosticListCommands

[rumyantseva]

So, in this solution, we use a separate ignoreLowercaseCmds map to store "ignored" values. I like it because it stores the exact things we don't want to show (lower-cased commands). On the other hand, if we have more duplicates, we must remember to add them to ignoreLowercaseCmds too.

Another potential way would be to iterate through Commands, store unique commands in a map and check for duplicates (for example, like we did here - https://github.com/FerretDB/FerretDB/blob/main/internal/types/document_validation.go#L71).

But I like your solution more because with your solution we don't need to take care of letters lower/upper case etc.

[rumyantseva]

@b1ron linter complains a little bit because empty structs in your map can be set simpler (just {} instead of struct{}{}), please take a look.

[b1ron]

@b1ron linter complains a little bit because empty structs in your map can be set simpler (just {} instead of struct{}{}), please take a look.

Yes will fix that. Thanks!

[rumyantseva]

LGTM