Support findAndModify

[w84thesun]

Closes #164.

[codecov]

Codecov Report

Merging #548 (3045a58) into main (638e107) will increase coverage by 1.47%.
The diff coverage is 80.06%.

@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
+ Coverage   61.80%   63.28%   +1.47%     
==========================================
  Files         122      122              
  Lines        6928     7157     +229     
==========================================
+ Hits         4282     4529     +247     
+ Misses       2121     2081      -40     
- Partials      525      547      +22     

Impacted Files	Coverage Δ
internal/handlers/common/error.go	84.48% <ø> (ø)
internal/handlers/common/errorcode_string.go	80.00% <ø> (ø)
internal/handlers/pg/msg_insert.go	40.90% <40.00%> (-3.54%)	⬇️
internal/handlers/pg/msg_update.go	48.93% <70.00%> (+0.04%)	⬆️
internal/handlers/pg/msg_delete.go	46.00% <76.19%> (+0.25%)	⬆️
internal/handlers/pg/msg_findandmodify.go	78.73% <83.03%> (+78.73%)	⬆️
internal/handlers/common/params.go	90.69% <100.00%> (+2.12%)	⬆️
internal/types/types.go	85.88% <0.00%> (+2.35%)	⬆️
internal/handlers/common/limit.go	75.00% <0.00%> (+8.33%)	⬆️

Flag	Coverage Δ
FerretDB	57.39% <80.06%> (+1.71%)	⬆️
MongoDB	6.29% <1.30%> (-0.16%)	⬇️
integration	57.42% <80.06%> (+1.71%)	⬆️
unit	25.09% <1.30%> (-0.81%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[seeforschauer]

some checks (i.e. inclusion/exclusion) of user input are in $elemMatch PR #551.

[seeforschauer]

Would you please add more tests,

• Cannot specify both an update and remove=true
• Cannot specify both upsert=true and remove=true
• Cannot specify both new=true and remove=true; 'remove' always returns the deleted document
• Cannot specify arrayFilters and remove=true
• Cannot specify arrayFilters and a pipeline update

Thank you.

[w84thesun]

Thanks, I've missed those checks.

• Cannot specify arrayFilters and remove=true
• Cannot specify arrayFilters and a pipeline update

I don't sure we support arrayFilters right now. Although we definitely don't support pipeline updates.

I've added other 3 tests.

[seeforschauer]

Thank you!

I don't sure we support arrayFilters right now. Although we definitely don't support pipeline updates.

Maybe mention somewhere in the issue description that the findAndModify is supported w/o arrayFilters and pipeline updates?

[w84thesun]

Thank you!

I don't sure we support arrayFilters right now. Although we definitely don't support pipeline updates.

Maybe mention somewhere in the issue description that the findAndModify is supported w/o arrayFilters and pipeline updates?

arrayFilters are already mentioned in the issue and marked as unimplemented.