Unify Dirichlets and affine constraints #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
reviewed
Oct 26, 2022
fredrikekre
force-pushed
the
eb_rework_ac
branch
from
f00a07a
to
0de7278
Compare
Codecov ReportBase: 92.36% // Head: 92.31% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 92.36% 92.31% -0.05%
==========================================
Files 22 22
Lines 3783 3776 -7
==========================================
- Hits 3494 3486 -8
- Misses 289 290 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fredrikekre
reviewed
Oct 26, 2022
This patch unifies the representation of `Dirichlet` and `AffineConstraint`s in the `ConstraintHandler`. `Dirichlet` is now more or less just special case of `AffineConstraint`. As a result, conflicting constraints on DoFs are handled more consistently: the constraint added last to the `ConstraintHandler` now always override any previous constraints. Conflicting constraints could previously cause problems when a DoF where prescribed by both `Dirichlet` and `AffineConstraint`. Co-authored-by: Elias <elias.isak.borjesson@gmail.com> Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
fredrikekre
force-pushed
the
eb_rework_ac
branch
from
73266c6
to
785c23a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is possible for Dirichlet and affine constraints to lock the same dof. This PR unifies Dirichlets and Affine constraints and makes it impossible for a dof to be locked by both affine and Dirichlet constraints.
If two conflicting constraints are added (prescribing the same dof), the most recently added constraint will be used.