-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AffineConstraint for nonzero b and nonlinear problem + docfixes #575
Conversation
Codecov ReportBase: 92.76% // Head: 92.76% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #575 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 28 28
Lines 4202 4202
=======================================
Hits 3898 3898
Misses 304 304
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, just some nits.
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
Windows test failure is unrelated to this PR, it also occurs on master. |
This PR fixes an issue recently discussed on Slack. The test code and derivations are included here for reference.
In addition, it adds further docstrings relevant when using AffineConstraints.
Test code
Without this PR, the nonlinear problem doesn't converge. With this PR, the code shows how the wrong results are obtained if using the `a=-K\r` instead of `a=K\f` for the linear solution method, which this PR documents.Analytical solution
Spring
|------$c$ ------|
|--$k$ --|-- $k$ --|--> $f$
Kinematical constraints
Free body diagrams
<-$ku_1$ -- (1) -- $f_c$ ->
<-$(f_c+ku_3)$ -- (3) -- $f$ ->
where$f_c$ is the affine constraint force and $f$ is the external force
Equilibrium