suggest addAll only for more than 3 repeated add and fix the marked…

… position
Feuermagier · Apr 6, 2024 · 49e6adb · 49e6adb
1 parent 6e603b3
commit 49e6adb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/autograder-core/src/main/java/de/firemage/autograder/core/check/api/CollectionAddAll.java b/autograder-core/src/main/java/de/firemage/autograder/core/check/api/CollectionAddAll.java
@@ -39,6 +39,8 @@
     ProblemType.COMMON_REIMPLEMENTATION_ADD_ALL
 })
 public class CollectionAddAll extends IntegratedCheck {
+    private static final int MIN_ADD_ALL_SIZE = 4;
+
     private record AddInvocation(
         CtVariableReference<?> collection,
         CtExecutableReference<?> executableReference,
@@ -117,9 +119,13 @@ private void reportProblem(CtVariable<?> ctVariable, List<? extends CtExpression
             return;
         }
 
+        if (addedValues.size() < MIN_ADD_ALL_SIZE) {
+            return;
+        }
+
 
         addLocalProblem(
-            ctVariable,
+            addedValues.get(0).getParent(CtStatement.class),
             new LocalizedMessage(
                 "common-reimplementation",
                 Map.of(

diff --git a/...grader-core/src/test/java/de/firemage/autograder/core/check/api/TestCollectionAddAll.java b/...grader-core/src/test/java/de/firemage/autograder/core/check/api/TestCollectionAddAll.java
@@ -48,12 +48,13 @@ public void foo(List<String> list) {
                         list.add(" ");
                         list.add("a");
                         list.add("b");
+                        list.add("c");
                     }
                 }
                 """
         ), PROBLEM_TYPES);
 
-        assertEqualsReimplementation(problems.next(), "list.addAll(List.of(\" \", \"a\", \"b\"))");
+        assertEqualsReimplementation(problems.next(), "list.addAll(List.of(\" \", \"a\", \"b\", \"c\"))");
 
         problems.assertExhausted();
     }