Skip to content

Conversation

qvalentin
Copy link
Member

@open-schnick can you test, my Docker installtion is broken :(

@qvalentin qvalentin marked this pull request as ready for review November 17, 2020 16:45
@qvalentin
Copy link
Member Author

I know that everything is hard coded, but if we use variables the user has to run a script to replace them, so this could be better for windows user for example.

Copy link
Member

@open-schnick open-schnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah looks fine to me. Maybe we should think more about what files the user needs to download and which are redundant. -> github workflow deployment or smth?

@qvalentin
Copy link
Member Author

yeah looks fine to me. Maybe we should think more about what files the user needs to download and which are redundant. -> github workflow deployment or smth?

yeah, just zip everything important and publish it as a release

@open-schnick open-schnick merged commit e025471 into master Nov 18, 2020
@open-schnick open-schnick deleted the feature/compose branch November 18, 2020 10:19
Gimleux pushed a commit that referenced this pull request May 20, 2021
* v1 Docker compose, FF-145

* changed version to latest FF-145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants