This repository was archived by the owner on Apr 5, 2024. It is now read-only.
FF-301 - Download Endpoint #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* FF-397 added basic download steps * FF-397 add more Screnarios for bad cases
qvalentin
approved these changes
May 17, 2021
src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemBusinessService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemHelperService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/filefighter/rest/domain/filesystem/rest/FileSystemRestService.java
Outdated
Show resolved
Hide resolved
* add setting of token as cookie * add authenticationWithAccessToken method to AuthenticationService * Minor changes, renaming and fixing. Co-authored-by: open-schnick <jonathan.burst@gmx.de>
qvalentin
approved these changes
May 18, 2021
qvalentin
reviewed
May 18, 2021
src/main/java/de/filefighter/rest/domain/filesystem/rest/FileSystemRestController.java
Outdated
Show resolved
Hide resolved
Gimleux
pushed a commit
that referenced
this pull request
May 20, 2021
* Added basic structure * FF-397 Download Cucumber Tests (#107) * FF-397 added basic download steps * FF-397 add more Screnarios for bad cases * updated basic structure with response header * Made Queries better * wrote the download logic * kinda works * fixed the paths again * Running Integrationtests * Removed nested class * Using cookies for download auth auth (#113) * add setting of token as cookie * add authenticationWithAccessToken method to AuthenticationService * Minor changes, renaming and fixing. Co-authored-by: open-schnick <jonathan.burst@gmx.de> * Download endpoint can now be used with cookies * Integration tested the cookie usage * Bumped up the version to v0.0.9 * Fixed a bug where the wrong folder was set as header Co-authored-by: valentin <36446499+qvalentin@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.