Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Conversation

open-schnick
Copy link
Member

No description provided.

@open-schnick open-schnick added the Feature Feature Label label Nov 9, 2020
@open-schnick open-schnick requested a review from a team November 9, 2020 10:32
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #19 (2934bac) into master (b756b26) will increase coverage by 0.84%.
The diff coverage is 82.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #19      +/-   ##
============================================
+ Coverage     65.30%   66.15%   +0.84%     
- Complexity      156      168      +12     
============================================
  Files            52       54       +2     
  Lines           490      517      +27     
  Branches         19       21       +2     
============================================
+ Hits            320      342      +22     
- Misses          163      169       +6     
+ Partials          7        6       -1     
Impacted Files Coverage Δ Complexity Δ
...ilefighter/rest/configuration/PrepareDataBase.java 12.65% <0.00%> (-0.50%) 4.00 <0.00> (ø)
...in/token/exceptions/AccessTokenNotFoundAdvise.java 33.33% <0.00%> (ø) 1.00 <0.00> (ø)
...omain/user/exceptions/UserAlreadyExistsAdvise.java 33.33% <0.00%> (ø) 1.00 <0.00> (ø)
...user/exceptions/UserNotAuthenticatedException.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...ions/RequestDidntMeetFormalRequirementsAdvise.java 33.33% <33.33%> (ø) 1.00 <1.00> (?)
...s/RequestDidntMeetFormalRequirementsException.java 50.00% <50.00%> (ø) 1.00 <1.00> (?)
...ain/token/business/AccessTokenBusinessService.java 100.00% <100.00%> (ø) 13.00 <3.00> (+3.00)
...rest/domain/user/business/UserBusinessService.java 100.00% <100.00%> (ø) 20.00 <3.00> (+3.00)
.../rest/domain/user/data/persistance/UserEntity.java 100.00% <100.00%> (+37.50%) 9.00 <8.00> (+4.00)
...in/user/exceptions/UserNotAuthenticatedAdvise.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b756b26...2934bac. Read the comment docs.

@open-schnick open-schnick marked this pull request as draft November 9, 2020 10:35
@open-schnick open-schnick marked this pull request as ready for review November 9, 2020 10:48
@open-schnick open-schnick merged commit 278aa57 into master Nov 10, 2020
@open-schnick open-schnick deleted the feature/findUser branch November 10, 2020 13:49
Gimleux pushed a commit that referenced this pull request May 20, 2021
* Wrote Steps.

* Fixed advises, added basic exception and advise

* Changed response messages, fixed feature files

* Implemented logic for finding users. Fixed some exceptions.

* Wrote Unit tests, added comment.

* Added missed Unit Test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Feature Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants