This repository was archived by the owner on Apr 5, 2024. It is now read-only.
FF-109, FF-110 Rework Authentication Architecture #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ups. fix broke tests. |
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
============================================
+ Coverage 61.66% 62.19% +0.53%
- Complexity 172 175 +3
============================================
Files 55 56 +1
Lines 566 574 +8
Branches 23 25 +2
============================================
+ Hits 349 357 +8
Misses 211 211
Partials 6 6
Continue to review full report at Codecov.
|
qvalentin
approved these changes
Nov 14, 2020
| byte[] decodedValue = Base64.getDecoder().decode(base64encodedUserAndPassword); | ||
| decodedUsernameUndPassword = new String(decodedValue, StandardCharsets.UTF_8.toString()); | ||
| } catch (UnsupportedEncodingException | IllegalArgumentException ex) { | ||
| LOG.warn("Found UnsupportedEncodingException in {}", base64encodedUserAndPassword); |
There was a problem hiding this comment.
maybe you shoud not log the password :)
|
|
||
| String[] split = decodedUsernameUndPassword.strip().split(":"); | ||
|
|
||
| if (split.length != 2) |
There was a problem hiding this comment.
so ":" is not allowed in the password?
Gimleux
pushed a commit
that referenced
this pull request
May 20, 2021
* FF-109 Rework BusinessServices Logic * FF-110 Fixed Tests and Bugs. * Fixed Tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As always, changed some .feature files. Updated Tests and businessServices.