This repository was archived by the owner on Apr 5, 2024. It is now read-only.
Feature/cucumber #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@open-schnick i need some feedback before i can continue with the task |
open-schnick
commented
Oct 27, 2020
src/test/cucumber/de/filefighter/rest/ViewFolderContents.feature
Outdated
Show resolved
Hide resolved
|
@qvalentin i added some comments to the code itself. |
|
Didnt check the tests locally. |
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=========================================
Coverage 52.04% 52.04%
Complexity 83 83
=========================================
Files 43 43
Lines 294 294
Branches 5 5
=========================================
Hits 153 153
Misses 141 141
Continue to review full report at Codecov.
|
|
@qvalentin Tests are looking good, i would change the arg names in the steps files to something better, and change arg types, so i dont have to parse them in the tests. |
# Conflicts: # src/main/java/de/filefighter/rest/domain/permission/data/dto/PermissionSet.java
Gimleux
pushed a commit
that referenced
this pull request
May 20, 2021
* Added Cucumber Integration * fixed pipeline. * added missing $ * FF-65 added basic steps * changed Description and addded Background * fixed some typos, added some comments, created steps files removed dummy test. * cleaning of .feature file * FF-65 added bad cases for Permissions feature file * redone ViewFolderContents.feature * FF-65 cleaning of feature files, added java classes for steps. * ViewFolderContentsSteps now extends SpringIntegrationTest * added cucumber run config. * added two scenarios, fixed all the datatypes (better regenerate step functions) * regenerate step functions and remove duplicates * FF-65 fixed test failure because of duplicate step function * FF-65 fixed steps, added comments. * renamed role to group * fixed deletion of line Co-authored-by: qvalentin <valentin.theodor@web.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.