Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Feature/user registration steps #30

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Feature/user registration steps #30

merged 3 commits into from
Nov 17, 2020

Conversation

qvalentin
Copy link
Member

  • serialize User to JSON: you maybe want to move this method
  • userWithIdIsInGroupWithId: userEntity.setGroupIds(groudIds); was not working idk why?

@codecov
Copy link

codecov bot commented Nov 15, 2020 •
edited
Loading

Codecov Report

Merging #30 (f219320) into master (c5c4dd9) will decrease coverage by 0.10%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #30      +/-   ##
============================================
- Coverage     61.86%   61.75%   -0.11%     
  Complexity      173      173              
============================================
  Files            55       55              
  Lines           569      570       +1     
  Branches         25       25              
============================================
  Hits            352      352              
- Misses          211      212       +1     
  Partials          6        6
Impacted Files Coverage Δ Complexity Δ
.../rest/domain/user/data/persistance/UserEntity.java 50.00% <57.14%> (-5.56%) 5.00 <4.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c4dd9...f219320. Read the comment docs.

@open-schnick
Copy link
Member

  • serialize User to JSON: you maybe want to move this method
  • userWithIdIsInGroupWithId: userEntity.setGroupIds(groudIds); was not working idk why?

create me a bug task, then i will look into it.

@open-schnick
Copy link
Member

gonna take a look at this tomorrow.

@qvalentin
Copy link
Member Author

@open-schnick then we merge this?

open-schnick
open-schnick reviewed Nov 17, 2020
View reviewed changes
Copy link
Member

@open-schnick open-schnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-schnick then we merge this?

sadly not.

@open-schnick open-schnick marked this pull request as ready for review November 17, 2020 08:52
@open-schnick open-schnick merged commit d2f1eb4 into master Nov 17, 2020
@open-schnick open-schnick deleted the feature/UserRegistrationSteps branch November 17, 2020 08:53
Gimleux pushed a commit that referenced this pull request May 20, 2021
@qvalentin @open-schnick
FF-104 user registration steps (#30)
5bb2d7a 
* added the steps FF-104

* added repo.save

* fixed "user with id is in group with id" step.

Co-authored-by: open-schnick <jonathan.burst@gmx.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@open-schnick open-schnick open-schnick approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qvalentin @open-schnick