This repository was archived by the owner on Apr 5, 2024. It is now read-only.
Logic for UserRegistration. #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qvalentin
commented
Nov 17, 2020
src/main/java/de/filefighter/rest/domain/user/business/UserBusinessService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/filefighter/rest/domain/user/business/UserBusinessService.java
Show resolved
Hide resolved
qvalentin
commented
Nov 17, 2020
src/main/java/de/filefighter/rest/domain/user/business/UserAuthorizationService.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
============================================
+ Coverage 62.08% 69.77% +7.68%
- Complexity 175 210 +35
============================================
Files 56 57 +1
Lines 575 655 +80
Branches 25 38 +13
============================================
+ Hits 357 457 +100
+ Misses 212 189 -23
- Partials 6 9 +3
Continue to review full report at Codecov.
|
Comment on lines
+52
to
+55
| <dependency> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpclient</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
fixing a bug in restTemplate. Overwriting the default httpRequestFactory.
Gimleux
approved these changes
Nov 19, 2020
Gimleux
pushed a commit
that referenced
this pull request
May 20, 2021
* WIP writing logic for UserRegistration. * FF-103 wrote logic and unit tests. * Added additional ExpectionHandler, and HealthCheck change. * FF-103 added configuration key for password check. * FF-103 Running cucumber tests works. * FF-103 Reworked server response to use httpStatus messages instead of strings. * FF-103 Implemented changes requested by @qvalentin, fixed some bugs. * Fixed Maven Test Execution. * updated version and date. Co-authored-by: open-schnick <jonathan.burst@gmx.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just so i can already comment on it.