This repository was archived by the owner on Apr 5, 2024. It is now read-only.
Feature/ff 106 #34
Merged
Feature/ff 106 #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests need to be fixed, Unit test to be written. @qvalentin @Gimleux can you write more scenarios that you want to test e.g. user groups, when an admin user wants to change a different user etc.. |
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
============================================
+ Coverage 69.77% 72.10% +2.33%
- Complexity 210 234 +24
============================================
Files 57 59 +2
Lines 655 717 +62
Branches 38 52 +14
============================================
+ Hits 457 517 +60
Misses 189 189
- Partials 9 11 +2
Continue to review full report at Codecov.
|
qvalentin
approved these changes
Nov 21, 2020
| String username = userToUpdate.getUsername(); | ||
| if (null != username) { | ||
| if (!stringIsValid(username)) | ||
| throw new UserNotUpdatedException("Wanted to change username, but username was not valid."); |
|
|
||
| Query query = new Query(); | ||
| query.addCriteria(Criteria.where("userId").is(userId)); | ||
| mongoTemplate.findAndModify(query, newUpdate, UserEntity.class); |
| } | ||
| if (password != null) { | ||
| jsonString.append("\"password\": \"").append(password).append(username != null?"\",":""); | ||
| jsonString.append("\"password\": \"").append(password).append(username != null ? "\"," : "\""); |
Gimleux
pushed a commit
that referenced
this pull request
May 20, 2021
* fixed tests, added shallow logic. * updated feature files, and step def. * FF-106 Write Logic for User Edit * Tweaked Cucumber Steps. Fixed Serialization. * Added additional check, fixed some bugs. * FF-106 Wrote UnitTests for User Edit * Damn you password check. * Bumped Version to v0.0.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.