Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Conversation

open-schnick
Copy link
Member

No description provided.

@open-schnick open-schnick added the Feature Feature Label label Oct 29, 2020
@open-schnick open-schnick requested a review from a team October 29, 2020 13:56
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #5 into master will increase coverage by 1.90%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #5      +/-   ##
============================================
+ Coverage     52.04%   53.94%   +1.90%     
- Complexity       83       92       +9     
============================================
  Files            43       47       +4     
  Lines           294      317      +23     
  Branches          5        5              
============================================
+ Hits            153      171      +18     
- Misses          141      146       +5     
Impacted Files Coverage Δ Complexity Δ
...rmission/data/dto/request/PermissionRecipient.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../domain/permission/rest/PermissionRestService.java 25.00% <ø> (ø) 1.00 <0.00> (ø)
...rest/domain/permission/data/dto/PermissionSet.java 60.00% <60.00%> (+60.00%) 1.00 <1.00> (+1.00)
...permission/data/dto/request/PermissionRequest.java 66.66% <66.66%> (ø) 3.00 <3.00> (?)
...sion/data/dto/request/PermissionRecipientType.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...in/permission/data/dto/request/PermissionType.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...main/permission/rest/PermissionRestController.java 100.00% <100.00%> (+60.00%) 4.00 <2.00> (+3.00)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1062738...b64f6dc. Read the comment docs.

Copy link
Member

@qvalentin qvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addUsersOrGroupsToPermissionSetForFileOrFolderWithAccessToken nice function name

@open-schnick open-schnick merged commit d5ede4e into master Oct 29, 2020
@open-schnick open-schnick deleted the feature/reworkPermissionController branch October 29, 2020 18:27
Gimleux pushed a commit that referenced this pull request May 20, 2021
* reworked PermissionController and dtos

* added unit test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Feature Feature Label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants